| Message ID | 1301948324-27186-3-git-send-email-stefan.ringel@arcor.de (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Mon, 04 Apr 2011 17:19:38 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1Q6qFO-00037z-6N for mchehab@pedra; Mon, 04 Apr 2011 17:19:38 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Mon, 04 Apr 2011 17:19:38 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Q6qEz-0003TH-Qp; Mon, 04 Apr 2011 20:19:14 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755592Ab1DDUTA (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 4 Apr 2011 16:19:00 -0400 Received: from mail-in-10.arcor-online.net ([151.189.21.50]:33557 "EHLO mail-in-10.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755578Ab1DDUS7 (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 4 Apr 2011 16:18:59 -0400 Received: from mail-in-17-z2.arcor-online.net (mail-in-17-z2.arcor-online.net [151.189.8.34]) by mx.arcor.de (Postfix) with ESMTP id 15D4F2D6919; Mon, 4 Apr 2011 22:18:58 +0200 (CEST) Received: from mail-in-02.arcor-online.net (mail-in-02.arcor-online.net [151.189.21.42]) by mail-in-17-z2.arcor-online.net (Postfix) with ESMTP id 0FA8B366118; Mon, 4 Apr 2011 22:18:58 +0200 (CEST) Received: from localhost.localdomain (dslb-094-222-027-138.pools.arcor-ip.net [94.222.27.138]) (Authenticated sender: stefan.ringel@arcor.de) by mail-in-02.arcor-online.net (Postfix) with ESMTPA id C774130CF1; Mon, 4 Apr 2011 22:18:57 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-02.arcor-online.net C774130CF1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1301948338; bh=37L+3NByoKWxp6HUKRE9pgXePg6fCqJwQE0q8Q6IGdU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=LRs/qhmh8ZAmuJOkCkKCArIWwkE18Dzs+P8kYVW+JjFeVFmTczYEAWB0GSI9QZTZU kZJi0ACGyV/PgiWpfFf64kJJ7PLx/9FZw/ij0wU+53SXGLjalZck2B1MrAOE4vhUNG StURLYZ3T9qd2GFLwhjzmRBw4m7OmJbgW59xuCAU= From: stefan.ringel@arcor.de To: linux-media@vger.kernel.org Cc: mchehab@redhat.com, d.belimov@gmail.com, Stefan Ringel <stefan.ringel@arcor.de> Subject: [PATCH 3/5] tm6000: add audio mode parameter Date: Mon, 4 Apr 2011 22:18:42 +0200 Message-Id: <1301948324-27186-3-git-send-email-stefan.ringel@arcor.de> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> References: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Stefan Ringel
April 4, 2011, 8:18 p.m. UTC
From: Stefan Ringel <stefan.ringel@arcor.de> add audio mode parameter Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de> --- drivers/staging/tm6000/tm6000-stds.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
Comments
Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: > From: Stefan Ringel <stefan.ringel@arcor.de> > > add audio mode parameter Why we need a parameter for it? It should be determined based on the standard. > > Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de> > --- > drivers/staging/tm6000/tm6000-stds.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c > index da3e51b..a9e1921 100644 > --- a/drivers/staging/tm6000/tm6000-stds.c > +++ b/drivers/staging/tm6000/tm6000-stds.c > @@ -22,12 +22,17 @@ > #include "tm6000.h" > #include "tm6000-regs.h" > > +static unsigned int tm6010_a_mode; > +module_param(tm6010_a_mode, int, 0644); > +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); > + > struct tm6000_reg_settings { > unsigned char req; > unsigned char reg; > unsigned char value; > }; > > +/* must be updated */ > enum tm6000_audio_std { > BG_NICAM, > BTSC, -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: > Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >> From: Stefan Ringel<stefan.ringel@arcor.de> >> >> add audio mode parameter > Why we need a parameter for it? It should be determined based on > the standard. > tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio? >> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >> --- >> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c >> index da3e51b..a9e1921 100644 >> --- a/drivers/staging/tm6000/tm6000-stds.c >> +++ b/drivers/staging/tm6000/tm6000-stds.c >> @@ -22,12 +22,17 @@ >> #include "tm6000.h" >> #include "tm6000-regs.h" >> >> +static unsigned int tm6010_a_mode; >> +module_param(tm6010_a_mode, int, 0644); >> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); >> + >> struct tm6000_reg_settings { >> unsigned char req; >> unsigned char reg; >> unsigned char value; >> }; >> >> +/* must be updated */ >> enum tm6000_audio_std { >> BG_NICAM, >> BTSC, -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em 20-04-2011 05:36, Stefan Ringel escreveu: > Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: >> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>> From: Stefan Ringel<stefan.ringel@arcor.de> >>> >>> add audio mode parameter >> Why we need a parameter for it? It should be determined based on >> the standard. >> > tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio? I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio decoding. >>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>> --- >>> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >>> 1 files changed, 5 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c >>> index da3e51b..a9e1921 100644 >>> --- a/drivers/staging/tm6000/tm6000-stds.c >>> +++ b/drivers/staging/tm6000/tm6000-stds.c >>> @@ -22,12 +22,17 @@ >>> #include "tm6000.h" >>> #include "tm6000-regs.h" >>> >>> +static unsigned int tm6010_a_mode; >>> +module_param(tm6010_a_mode, int, 0644); >>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); >>> + >>> struct tm6000_reg_settings { >>> unsigned char req; >>> unsigned char reg; >>> unsigned char value; >>> }; >>> >>> +/* must be updated */ >>> enum tm6000_audio_std { >>> BG_NICAM, >>> BTSC, > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab: > Em 20-04-2011 05:36, Stefan Ringel escreveu: >> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: >>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>> From: Stefan Ringel<stefan.ringel@arcor.de> >>>> >>>> add audio mode parameter >>> Why we need a parameter for it? It should be determined based on >>> the standard. >>> >> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio? > I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with > my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio > decoding. > In the next patch I will send it. A preview I have send to be test ( https://patchwork.kernel.org/patch/722021/ ). >>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>>> --- >>>> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >>>> 1 files changed, 5 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c >>>> index da3e51b..a9e1921 100644 >>>> --- a/drivers/staging/tm6000/tm6000-stds.c >>>> +++ b/drivers/staging/tm6000/tm6000-stds.c >>>> @@ -22,12 +22,17 @@ >>>> #include "tm6000.h" >>>> #include "tm6000-regs.h" >>>> >>>> +static unsigned int tm6010_a_mode; >>>> +module_param(tm6010_a_mode, int, 0644); >>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); >>>> + >>>> struct tm6000_reg_settings { >>>> unsigned char req; >>>> unsigned char reg; >>>> unsigned char value; >>>> }; >>>> >>>> +/* must be updated */ >>>> enum tm6000_audio_std { >>>> BG_NICAM, >>>> BTSC, >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em 03-05-2011 11:25, Stefan Ringel arcor escreveu: > Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab: >> Em 20-04-2011 05:36, Stefan Ringel escreveu: >>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: >>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>>> From: Stefan Ringel<stefan.ringel@arcor.de> >>>>> >>>>> add audio mode parameter >>>> Why we need a parameter for it? It should be determined based on >>>> the standard. >>>> >>> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio? >> I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with >> my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio >> decoding. >> > In the next patch I will send it. A preview I have send to be test ( > https://patchwork.kernel.org/patch/722021/ ). I tested your preview. Didn't make any difference. >>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>>>> --- >>>>> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >>>>> 1 files changed, 5 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c >>>>> index da3e51b..a9e1921 100644 >>>>> --- a/drivers/staging/tm6000/tm6000-stds.c >>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c >>>>> @@ -22,12 +22,17 @@ >>>>> #include "tm6000.h" >>>>> #include "tm6000-regs.h" >>>>> >>>>> +static unsigned int tm6010_a_mode; >>>>> +module_param(tm6010_a_mode, int, 0644); >>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); >>>>> + >>>>> struct tm6000_reg_settings { >>>>> unsigned char req; >>>>> unsigned char reg; >>>>> unsigned char value; >>>>> }; >>>>> >>>>> +/* must be updated */ >>>>> enum tm6000_audio_std { >>>>> BG_NICAM, >>>>> BTSC, >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 03.05.2011 16:42, schrieb Mauro Carvalho Chehab: > Em 03-05-2011 11:25, Stefan Ringel arcor escreveu: >> Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab: >>> Em 20-04-2011 05:36, Stefan Ringel escreveu: >>>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: >>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>>>> From: Stefan Ringel<stefan.ringel@arcor.de> >>>>>> >>>>>> add audio mode parameter >>>>> Why we need a parameter for it? It should be determined based on >>>>> the standard. >>>>> >>>> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio? >>> I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with >>> my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio >>> decoding. >>> >> In the next patch I will send it. A preview I have send to be test ( >> https://patchwork.kernel.org/patch/722021/ ). > I tested your preview. Didn't make any difference. Has you test with all setting variants? (BG_A2 works auto and A2 audio mode). >>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>>>>> --- >>>>>> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >>>>>> 1 files changed, 5 insertions(+), 0 deletions(-) >>>>>> >>>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c >>>>>> index da3e51b..a9e1921 100644 >>>>>> --- a/drivers/staging/tm6000/tm6000-stds.c >>>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c >>>>>> @@ -22,12 +22,17 @@ >>>>>> #include "tm6000.h" >>>>>> #include "tm6000-regs.h" >>>>>> >>>>>> +static unsigned int tm6010_a_mode; >>>>>> +module_param(tm6010_a_mode, int, 0644); >>>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); >>>>>> + >>>>>> struct tm6000_reg_settings { >>>>>> unsigned char req; >>>>>> unsigned char reg; >>>>>> unsigned char value; >>>>>> }; >>>>>> >>>>>> +/* must be updated */ >>>>>> enum tm6000_audio_std { >>>>>> BG_NICAM, >>>>>> BTSC, >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 03.05.2011 16:52, schrieb Stefan Ringel: > Am 03.05.2011 16:42, schrieb Mauro Carvalho Chehab: >> Em 03-05-2011 11:25, Stefan Ringel arcor escreveu: >>> Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab: >>>> Em 20-04-2011 05:36, Stefan Ringel escreveu: >>>>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: >>>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>>>>> From: Stefan Ringel<stefan.ringel@arcor.de> >>>>>>> >>>>>>> add audio mode parameter >>>>>> Why we need a parameter for it? It should be determined based on >>>>>> the standard. >>>>>> >>>>> tm6010 has a sif decoder, and I think if auto detect doesn't work, >>>>> use can set the audio standard, which it has in your region. Or >>>>> it's better if users can see image but can hear audio? >>>> I did some tests with SIF and MTS here. None of them were capable >>>> of working with BTSC signals with >>>> my devices. Adding a parameter won't help it at all. What we need >>>> to do is to fix the audio >>>> decoding. >>>> >>> In the next patch I will send it. A preview I have send to be test ( >>> https://patchwork.kernel.org/patch/722021/ ). >> I tested your preview. Didn't make any difference. > Has you test with all setting variants? (BG_A2 works auto and A2 audio > mode). I use mplayer, and have in the first use the wrong parameter. Now I know the right parameter for mplayer: mplayer -vc rawyuy2 -ac pcm -ao alsa:device=hw=0.0 -tv driver=v4l2:device=/dev/video2:input=0:outfmt=yv12:freq=210.25:normid=3:alsa:adevice=hw.2,0:amode=1:immediatemode=0 -fs tv:// >>>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>>>>>> --- >>>>>>> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >>>>>>> 1 files changed, 5 insertions(+), 0 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c >>>>>>> b/drivers/staging/tm6000/tm6000-stds.c >>>>>>> index da3e51b..a9e1921 100644 >>>>>>> --- a/drivers/staging/tm6000/tm6000-stds.c >>>>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c >>>>>>> @@ -22,12 +22,17 @@ >>>>>>> #include "tm6000.h" >>>>>>> #include "tm6000-regs.h" >>>>>>> >>>>>>> +static unsigned int tm6010_a_mode; >>>>>>> +module_param(tm6010_a_mode, int, 0644); >>>>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 >>>>>>> only)"); >>>>>>> + >>>>>>> struct tm6000_reg_settings { >>>>>>> unsigned char req; >>>>>>> unsigned char reg; >>>>>>> unsigned char value; >>>>>>> }; >>>>>>> >>>>>>> +/* must be updated */ >>>>>>> enum tm6000_audio_std { >>>>>>> BG_NICAM, >>>>>>> BTSC, >>>>> -- >>>>> To unsubscribe from this list: send the line "unsubscribe >>>>> linux-media" in >>>>> the body of a message to majordomo@vger.kernel.org >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-media" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c index da3e51b..a9e1921 100644 --- a/drivers/staging/tm6000/tm6000-stds.c +++ b/drivers/staging/tm6000/tm6000-stds.c @@ -22,12 +22,17 @@ #include "tm6000.h" #include "tm6000-regs.h" +static unsigned int tm6010_a_mode; +module_param(tm6010_a_mode, int, 0644); +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); + struct tm6000_reg_settings { unsigned char req; unsigned char reg; unsigned char value; }; +/* must be updated */ enum tm6000_audio_std { BG_NICAM, BTSC,