Message ID | 4D5D9D10.2060709@gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Thu, 17 Feb 2011 20:13:32 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1PqC6N-0004mu-Ri for mchehab@pedra; Thu, 17 Feb 2011 20:13:32 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Thu, 17 Feb 2011 20:13:31 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PqC4W-0001yB-Fi; Thu, 17 Feb 2011 22:11:36 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849Ab1BQWLe (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Thu, 17 Feb 2011 17:11:34 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:65196 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788Ab1BQWLd (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 17 Feb 2011 17:11:33 -0500 Received: by fxm20 with SMTP id 20so3111973fxm.19 for <linux-media@vger.kernel.org>; Thu, 17 Feb 2011 14:11:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type; bh=ZJjwg9iBJ13CMcvMVv4RH8tZCMOE/lrGkmZodTn6SpY=; b=Ymbmix5yQ7/GohJbgxkYKhW8e3JzM4BYHIzON6zgz6rd6Mw7I0/L8LXhYuLCXncVuH cCXHP46pmPNTFoc9XOJhnDeNYLPChAFaUA2UVbxiYgnmHI7TIxMZH29NsjRpa11cNUeR HDLmZpPpEJKH9w+b6ih/LEi20w9nXP/6O3IOc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; b=NfhHWyZGmHN5hJF79klfDfe9YRtTtRxqyFPJESEYuc8syVoUZeZ6fDTK0eane/ZmVn 8M/InX1mDud7elorapVe6sfF7H9XGTaxVGnYS9ISPFCT+TLF78lGjv0rfk9WduIlio6z e35damSoCdLuIZ6/BMe85hjEETmtVZfhVrxg8= Received: by 10.223.70.141 with SMTP id d13mr1260139faj.111.1297980692040; Thu, 17 Feb 2011 14:11:32 -0800 (PST) Received: from nuna.kompudera.dma ([161.53.230.61]) by mx.google.com with ESMTPS id n7sm750156fam.11.2011.02.17.14.11.29 (version=SSLv3 cipher=OTHER); Thu, 17 Feb 2011 14:11:30 -0800 (PST) Message-ID: <4D5D9D10.2060709@gmail.com> Date: Thu, 17 Feb 2011 23:11:28 +0100 From: poma <pomidorabelisima@gmail.com> User-Agent: Thunderbird 2.0.0.24 (X11/20101213) MIME-Version: 1.0 To: linux-media@vger.kernel.org, Antti Palosaari <crope@iki.fi>, andrew.williams@joratech.com, lindsay.mathieson@gmail.com, skandalfo@gmail.com, news004@upsilon.org.uk Subject: Re: Afatech AF9015 & dual tuner - dual_mode B.R.O.K.E.N. References: <4D5B5FE2.5000302@gmail.com> <4D5CE929.4050102@gmail.com> In-Reply-To: <4D5CE929.4050102@gmail.com> Content-Type: multipart/mixed; boundary="------------040504060607060302010405" Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
poma
Feb. 17, 2011, 10:11 p.m. UTC
poma wrote: > poma wrote: >> To num_adapters = 2, or num_adapters = 1: that is the question! > > In dual tuner mode, after a while device become unrensponsive, > eventually after S5 aka 'Soft Off' system doesn't even boot! > Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to > RAM'. > Antti, please consider adding 'dual_mode' parameter back. > > "dvb_usb_af9015 dual_mode=0" > > Devices to consider: > > Not Only TV/LifeView DUAL DVB-T USB LV52T > (equivalent to TerraTec Cinergy T Stick Dual RC) > Afatech AF9013/AF9015 & 2x MaxLinear MxL5007T > http://www.notonlytv.net/p_lv52t.html > > KWorld USB Dual DVB-T TV Stick (DVB-T 399U) > Afatech AF9013/AF9015 & 2x MaxLinear MxL5003S > http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73 > > DigitalNow TinyTwin DVB-T Receiver > Afatech AF9013/AF9015 & 2x MaxLinear MxL5005S > http://www.digitalnow.com.au/product_pages/TinyTwin.html > > http://www.spinics.net/lists/linux-dvb/msg31616.html > http://www.spinics.net/lists/linux-dvb/msg31621.html This patch restore dvb_usb_af9015 'dual mode' parameter - "disable dual mode by default because it is buggy". Enabled mode: options dvb_usb_af9015 dual_mode=1 in modprobe referent file. .. --- a/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-01-10 16:24:45.000000000 +0100 +++ b/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-02-17 21:58:42.099040739 +0100 @@ -40,6 +40,9 @@ static int dvb_usb_af9015_remote; module_param_named(remote, dvb_usb_af9015_remote, int, 0644); MODULE_PARM_DESC(remote, "select remote"); +static int dvb_usb_af9015_dual_mode; +module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644); +MODULE_PARM_DESC(dual_mode, "enable dual mode"); DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); static DEFINE_MUTEX(af9015_usb_mutex); @@ -841,6 +844,9 @@ goto error; af9015_config.dual_mode = val; deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode); + /* disable dual mode by default because it is buggy */ + if (!dvb_usb_af9015_dual_mode) + af9015_config.dual_mode = 0; /* Set adapter0 buffer size according to USB port speed, adapter1 buffer size can be static because it is enabled only USB2.0 */ .. rgds, poma
Comments
Hi Antti, I'm assuming that you're reviewing this patchset, so, I'll update patchwork status accordingly. Mauro Em 17-02-2011 20:11, poma escreveu: > poma wrote: >> poma wrote: >>> To num_adapters = 2, or num_adapters = 1: that is the question! >> >> In dual tuner mode, after a while device become unrensponsive, >> eventually after S5 aka 'Soft Off' system doesn't even boot! >> Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to RAM'. >> Antti, please consider adding 'dual_mode' parameter back. >> >> "dvb_usb_af9015 dual_mode=0" >> >> Devices to consider: >> >> Not Only TV/LifeView DUAL DVB-T USB LV52T >> (equivalent to TerraTec Cinergy T Stick Dual RC) >> Afatech AF9013/AF9015 & 2x MaxLinear MxL5007T >> http://www.notonlytv.net/p_lv52t.html >> >> KWorld USB Dual DVB-T TV Stick (DVB-T 399U) >> Afatech AF9013/AF9015 & 2x MaxLinear MxL5003S >> http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73 >> >> DigitalNow TinyTwin DVB-T Receiver >> Afatech AF9013/AF9015 & 2x MaxLinear MxL5005S >> http://www.digitalnow.com.au/product_pages/TinyTwin.html >> >> http://www.spinics.net/lists/linux-dvb/msg31616.html >> http://www.spinics.net/lists/linux-dvb/msg31621.html > > This patch restore dvb_usb_af9015 'dual mode' parameter - "disable dual mode by default because it is buggy". > Enabled mode: > options dvb_usb_af9015 dual_mode=1 > in modprobe referent file. > > .. > --- a/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-01-10 16:24:45.000000000 +0100 > +++ b/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-02-17 21:58:42.099040739 +0100 > @@ -40,6 +40,9 @@ > static int dvb_usb_af9015_remote; > module_param_named(remote, dvb_usb_af9015_remote, int, 0644); > MODULE_PARM_DESC(remote, "select remote"); > +static int dvb_usb_af9015_dual_mode; > +module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644); > +MODULE_PARM_DESC(dual_mode, "enable dual mode"); > DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); > > static DEFINE_MUTEX(af9015_usb_mutex); > @@ -841,6 +844,9 @@ > goto error; > af9015_config.dual_mode = val; > deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode); > + /* disable dual mode by default because it is buggy */ > + if (!dvb_usb_af9015_dual_mode) > + af9015_config.dual_mode = 0; > > /* Set adapter0 buffer size according to USB port speed, adapter1 buffer > size can be static because it is enabled only USB2.0 */ > .. > > rgds, > poma > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Moikka Mauro et all, I will NACK this. Surely it is not proper solution. And after all, I haven't got any other reports there is such problem. AF9015 is probably most common DVB-T USB hardware today and if there is major problems I am the first person got reports. regards, Antti On 04/29/2011 03:03 PM, Mauro Carvalho Chehab wrote: > Hi Antti, > > I'm assuming that you're reviewing this patchset, so, I'll update patchwork status > accordingly. > > Mauro > > Em 17-02-2011 20:11, poma escreveu: >> poma wrote: >>> poma wrote: >>>> To num_adapters = 2, or num_adapters = 1: that is the question! >>> >>> In dual tuner mode, after a while device become unrensponsive, >>> eventually after S5 aka 'Soft Off' system doesn't even boot! >>> Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to RAM'. >>> Antti, please consider adding 'dual_mode' parameter back. >>> >>> "dvb_usb_af9015 dual_mode=0" >>> >>> Devices to consider: >>> >>> Not Only TV/LifeView DUAL DVB-T USB LV52T >>> (equivalent to TerraTec Cinergy T Stick Dual RC) >>> Afatech AF9013/AF9015& 2x MaxLinear MxL5007T >>> http://www.notonlytv.net/p_lv52t.html >>> >>> KWorld USB Dual DVB-T TV Stick (DVB-T 399U) >>> Afatech AF9013/AF9015& 2x MaxLinear MxL5003S >>> http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73 >>> >>> DigitalNow TinyTwin DVB-T Receiver >>> Afatech AF9013/AF9015& 2x MaxLinear MxL5005S >>> http://www.digitalnow.com.au/product_pages/TinyTwin.html >>> >>> http://www.spinics.net/lists/linux-dvb/msg31616.html >>> http://www.spinics.net/lists/linux-dvb/msg31621.html >> >> This patch restore dvb_usb_af9015 'dual mode' parameter - "disable dual mode by default because it is buggy". >> Enabled mode: >> options dvb_usb_af9015 dual_mode=1 >> in modprobe referent file. >> >> .. >> --- a/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-01-10 16:24:45.000000000 +0100 >> +++ b/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-02-17 21:58:42.099040739 +0100 >> @@ -40,6 +40,9 @@ >> static int dvb_usb_af9015_remote; >> module_param_named(remote, dvb_usb_af9015_remote, int, 0644); >> MODULE_PARM_DESC(remote, "select remote"); >> +static int dvb_usb_af9015_dual_mode; >> +module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644); >> +MODULE_PARM_DESC(dual_mode, "enable dual mode"); >> DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); >> >> static DEFINE_MUTEX(af9015_usb_mutex); >> @@ -841,6 +844,9 @@ >> goto error; >> af9015_config.dual_mode = val; >> deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode); >> + /* disable dual mode by default because it is buggy */ >> + if (!dvb_usb_af9015_dual_mode) >> + af9015_config.dual_mode = 0; >> >> /* Set adapter0 buffer size according to USB port speed, adapter1 buffer >> size can be static because it is enabled only USB2.0 */ >> .. >> >> rgds, >> poma >> >
Antti Palosaari wrote: > Moikka Mauro et all, > > I will NACK this. > > Surely it is not proper solution. And after all, I haven't got any other > reports there is such problem. AF9015 is probably most common DVB-T USB > hardware today and if there is major problems I am the first person got > reports. If you are interested, I'm willing to do more testing on this particular device, to clear up ;) rgds, poma -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-01-10 16:24:45.000000000 +0100 +++ b/linux/drivers/media/dvb/dvb-usb/af9015.c 2011-02-17 21:58:42.099040739 +0100 @@ -40,6 +40,9 @@ static int dvb_usb_af9015_remote; module_param_named(remote, dvb_usb_af9015_remote, int, 0644); MODULE_PARM_DESC(remote, "select remote"); +static int dvb_usb_af9015_dual_mode; +module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644); +MODULE_PARM_DESC(dual_mode, "enable dual mode"); DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); static DEFINE_MUTEX(af9015_usb_mutex); @@ -841,6 +844,9 @@ goto error; af9015_config.dual_mode = val; deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode); + /* disable dual mode by default because it is buggy */ + if (!dvb_usb_af9015_dual_mode) + af9015_config.dual_mode = 0; /* Set adapter0 buffer size according to USB port speed, adapter1 buffer size can be static because it is enabled only USB2.0 */