mbox

[GIT,PATCHES,FOR,2.6.40] gspca for_v2.6.40

Message ID 20110419202029.7c9dfd14@tele (mailing list archive)
State Superseded, archived
Headers

Pull-request

git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Message

Jean-Francois Moine April 19, 2011, 6:20 p.m. UTC
  The following changes since commit
d58307d6a1e2441ebaf2d924df4346309ff84c7d:

  [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Antonio Ospite (2):
      Add Y10B, a 10 bpp bit-packed greyscale format.
      gspca - kinect: New subdriver for Microsoft Kinect

Jean-François Moine (1):
      gspca - zc3xx: Adjust the mc501cb exchanges

Patrice Chotard (5):
      gspca - jeilinj: suppress workqueue
      gspca - jeilinj: use gspca_dev->usb_err to forward error to upper layer
      gspca - jeilinj: add 640*480 resolution support
      gspca - jeilinj: Add SPORTSCAM_DV15 camera support
      gspca - jeilinj: add SPORTSCAM specific controls

 Documentation/DocBook/media-entities.tmpl |    1 +
 Documentation/DocBook/v4l/pixfmt-y10b.xml |   43 +++
 Documentation/DocBook/v4l/pixfmt.xml      |    1 +
 Documentation/DocBook/v4l/videodev2.h.xml |    3 +
 Documentation/video4linux/gspca.txt       |    1 +
 drivers/media/video/gspca/Kconfig         |    9 +
 drivers/media/video/gspca/Makefile        |    2 +
 drivers/media/video/gspca/jeilinj.c       |  581 ++++++++++++++++++++---------
 drivers/media/video/gspca/kinect.c        |  427 +++++++++++++++++++++
 drivers/media/video/gspca/zc3xx.c         |   42 +--
 include/linux/videodev2.h                 |    3 +
 11 files changed, 905 insertions(+), 208 deletions(-)
 create mode 100644 Documentation/DocBook/v4l/pixfmt-y10b.xml
 create mode 100644 drivers/media/video/gspca/kinect.c
  

Comments

Antonio Ospite April 19, 2011, 7:54 p.m. UTC | #1
On Tue, 19 Apr 2011 20:20:29 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> The following changes since commit
> d58307d6a1e2441ebaf2d924df4346309ff84c7d:
> 
>   [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
> 
> Antonio Ospite (2):
>       Add Y10B, a 10 bpp bit-packed greyscale format.
>       gspca - kinect: New subdriver for Microsoft Kinect
> 

Ah glad to see that, so there was no major concern on the code, was
there?

Thanks Jean-Francois,
   Antonio
  
Mauro Carvalho Chehab April 19, 2011, 8:34 p.m. UTC | #2
Em 19-04-2011 16:54, Antonio Ospite escreveu:
> On Tue, 19 Apr 2011 20:20:29 +0200
> Jean-Francois Moine <moinejf@free.fr> wrote:
> 
>> The following changes since commit
>> d58307d6a1e2441ebaf2d924df4346309ff84c7d:
>>
>>   [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300)
>>
>> are available in the git repository at:
>>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
>>
>> Antonio Ospite (2):
>>       Add Y10B, a 10 bpp bit-packed greyscale format.
>>       gspca - kinect: New subdriver for Microsoft Kinect
>>
> 
> Ah glad to see that, so there was no major concern on the code, was
> there?

There's just a problem that I noticed:

drivers/media/video/gspca/kinect.c: In function ‘send_cmd.clone.0’:
drivers/media/video/gspca/kinect.c:202: warning: the frame size of 1548 bytes is larger than 1024 bytes

Please, don't do things like:

+ uint8_t obuf[0x400];
+ uint8_t ibuf[0x200];

at the stack. Instead, put it into a per-device struct.

Anyway, I've applied your patches here. Please send us a fix for it
as soon as possible.

Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Antonio Ospite April 21, 2011, 9:51 a.m. UTC | #3
Hi,

some incremental fixes for the gspca kinect driver, the first patch in 
the series by Drew Fisher addresses the issue Mauro was pointing out.

Thanks,
   Antonio

Antonio Ospite (1):
  gspca - kinect: fix comments referring to color camera

Drew Fisher (2):
  gspca - kinect: move communications buffers out of stack
  gspca - kinect: fix a typo s/steram/stream/

 drivers/media/video/gspca/kinect.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)