mbox series

[V3,0/1] Fix for VP9 DRC and Decoder STOP issue.

Message ID 20230316081509.12201-1-quic_vboma@quicinc.com (mailing list archive)
Headers
Series Fix for VP9 DRC and Decoder STOP issue. |

Message

Viswanath Boma March 16, 2023, 8:15 a.m. UTC 
  From: Viswanath Boma <quic_vboma@quicinc.com>

Fixed indent comments, ensured rebase and checkpatch with --strict.
Tested the changes on v5.15 and v5.4 kernels .
For testing Chrome Utilities were used .

Viswanath Boma (1):
  venus: Enable sufficient sequence change support for sc7180 and fix
    for Decoder STOP command issue.

 drivers/media/platform/qcom/venus/core.h       | 18 ++++++++++++++++++
 drivers/media/platform/qcom/venus/hfi_cmds.c   |  1 +
 drivers/media/platform/qcom/venus/hfi_helper.h |  2 ++
 drivers/media/platform/qcom/venus/hfi_msgs.c   | 11 +++++++++--
 drivers/media/platform/qcom/venus/vdec.c       | 12 +++++++++++-
 5 files changed, 41 insertions(+), 3 deletions(-)

Comments

Konrad Dybcio March 16, 2023, 8:41 a.m. UTC | #1 
On 16.03.2023 09:15, quic_vboma@quicinc.com wrote:
> From: Viswanath Boma <quic_vboma@quicinc.com>
Please fix your git send-email config to include your first and last
name in the emails you send.

Please send next versions as a standalone thread, not in reply to the
previous ones.

> 
> Fixed indent comments, ensured rebase and checkpatch with --strict.
> Tested the changes on v5.15 and v5.4 kernels .
You're submitting changes to the mainline kernel, not to v5.15 or v5.4.
Please validate it against linux-next/master.

Konrad
> For testing Chrome Utilities were used .
> 
> Viswanath Boma (1):
>   venus: Enable sufficient sequence change support for sc7180 and fix
>     for Decoder STOP command issue.
> 
>  drivers/media/platform/qcom/venus/core.h       | 18 ++++++++++++++++++
>  drivers/media/platform/qcom/venus/hfi_cmds.c   |  1 +
>  drivers/media/platform/qcom/venus/hfi_helper.h |  2 ++
>  drivers/media/platform/qcom/venus/hfi_msgs.c   | 11 +++++++++--
>  drivers/media/platform/qcom/venus/vdec.c       | 12 +++++++++++-
>  5 files changed, 41 insertions(+), 3 deletions(-)
>
Dmitry Baryshkov March 16, 2023, 12:37 p.m. UTC | #2 
On 16/03/2023 10:15, quic_vboma@quicinc.com wrote:
> From: Viswanath Boma <quic_vboma@quicinc.com>
> 
> Fixed indent comments, ensured rebase and checkpatch with --strict.
> Tested the changes on v5.15 and v5.4 kernels .

Was it tested on top of the recent kernels?

> For testing Chrome Utilities were used .
> 
> Viswanath Boma (1):
>    venus: Enable sufficient sequence change support for sc7180 and fix
>      for Decoder STOP command issue.
> 
>   drivers/media/platform/qcom/venus/core.h       | 18 ++++++++++++++++++
>   drivers/media/platform/qcom/venus/hfi_cmds.c   |  1 +
>   drivers/media/platform/qcom/venus/hfi_helper.h |  2 ++
>   drivers/media/platform/qcom/venus/hfi_msgs.c   | 11 +++++++++--
>   drivers/media/platform/qcom/venus/vdec.c       | 12 +++++++++++-
>   5 files changed, 41 insertions(+), 3 deletions(-)
>
Viswanath Boma (Temp) March 23, 2023, 9:22 a.m. UTC | #3 
HI Dmirty,

Thanks for Reviews .

> -----Original Message-----
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Sent: Thursday, March 16, 2023 6:08 PM
> To: Viswanath Boma (Temp) (QUIC) <quic_vboma@quicinc.com>;
> stanimir.varbanov@linaro.org; Vikash Garodia (QUIC)
> <quic_vgarodia@quicinc.com>; Andy Gross <agross@kernel.org>;
> bjorn.andersson@linaro.org; Konrad Dybcio <konrad.dybcio@linaro.org>;
> Mauro Carvalho Chehab <mchehab@kernel.org>; linux-
> media@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH V3 0/1] Fix for VP9 DRC and Decoder STOP issue.
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
> 
> On 16/03/2023 10:15, quic_vboma@quicinc.com wrote:
> > From: Viswanath Boma <quic_vboma@quicinc.com>
> >
> > Fixed indent comments, ensured rebase and checkpatch with --strict.
> > Tested the changes on v5.15 and v5.4 kernels .
> 
> Was it tested on top of the recent kernels?
> 
Yes, Ensured on the latest .

> > For testing Chrome Utilities were used .
> >
> > Viswanath Boma (1):
> >    venus: Enable sufficient sequence change support for sc7180 and fix
> >      for Decoder STOP command issue.
> >
> >   drivers/media/platform/qcom/venus/core.h       | 18 ++++++++++++++++++
> >   drivers/media/platform/qcom/venus/hfi_cmds.c   |  1 +
> >   drivers/media/platform/qcom/venus/hfi_helper.h |  2 ++
> >   drivers/media/platform/qcom/venus/hfi_msgs.c   | 11 +++++++++--
> >   drivers/media/platform/qcom/venus/vdec.c       | 12 +++++++++++-
> >   5 files changed, 41 insertions(+), 3 deletions(-)
> >
> 
> --
> With best wishes
> Dmitry
Dmitry Baryshkov March 23, 2023, 9:37 a.m. UTC | #4 
On Thu, 23 Mar 2023 at 11:22, Viswanath Boma (Temp)
<vboma@qti.qualcomm.com> wrote:
>
> HI Dmirty,
>
> Thanks for Reviews .
>
> > -----Original Message-----
> > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Sent: Thursday, March 16, 2023 6:08 PM
> > To: Viswanath Boma (Temp) (QUIC) <quic_vboma@quicinc.com>;
> > stanimir.varbanov@linaro.org; Vikash Garodia (QUIC)
> > <quic_vgarodia@quicinc.com>; Andy Gross <agross@kernel.org>;
> > bjorn.andersson@linaro.org; Konrad Dybcio <konrad.dybcio@linaro.org>;
> > Mauro Carvalho Chehab <mchehab@kernel.org>; linux-
> > media@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH V3 0/1] Fix for VP9 DRC and Decoder STOP issue.
> >
> > WARNING: This email originated from outside of Qualcomm. Please be wary of
> > any links or attachments, and do not enable macros.

Can we please get rid of this in the replies? There is no need to
duplicate headers.

> >
> > On 16/03/2023 10:15, quic_vboma@quicinc.com wrote:
> > > From: Viswanath Boma <quic_vboma@quicinc.com>
> > >
> > > Fixed indent comments, ensured rebase and checkpatch with --strict.
> > > Tested the changes on v5.15 and v5.4 kernels .
> >
> > Was it tested on top of the recent kernels?
> >
> Yes, Ensured on the latest .

Then why do you mention old kernels at all? Also the email addresses
you have used do not correspond to the latest kernels.

>
> > > For testing Chrome Utilities were used .
> > >
> > > Viswanath Boma (1):
> > >    venus: Enable sufficient sequence change support for sc7180 and fix
> > >      for Decoder STOP command issue.
> > >
> > >   drivers/media/platform/qcom/venus/core.h       | 18 ++++++++++++++++++
> > >   drivers/media/platform/qcom/venus/hfi_cmds.c   |  1 +
> > >   drivers/media/platform/qcom/venus/hfi_helper.h |  2 ++
> > >   drivers/media/platform/qcom/venus/hfi_msgs.c   | 11 +++++++++--
> > >   drivers/media/platform/qcom/venus/vdec.c       | 12 +++++++++++-
> > >   5 files changed, 41 insertions(+), 3 deletions(-)
> > >
> >
> > --
> > With best wishes
> > Dmitry
>