mbox series

[GIT,FIXES,FOR,v6.3] Venus fixes

Message ID 20230302060413.67239-1-stanimir.k.varbanov@gmail.com (mailing list archive)
State Accepted
Headers
Series [GIT,FIXES,FOR,v6.3] Venus fixes |

Pull-request

git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-fixes-for-v6.3

Message

Stanimir Varbanov March 2, 2023, 6:04 a.m. UTC 
Hi Mauro,

This pull request includes a fix for regression in venus hardware reset.
The reverted commit has been merged in v6.2. 

Please pull.

regards,
Stan

The following changes since commit 3e62aba8284de0994a669d07983299242e68fe72:

  media: imx-mipi-csis: Check csis_fmt validity before use (2023-02-26 11:21:33 +0100)

are available in the Git repository at:

  git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-fixes-for-v6.3

for you to fetch changes up to 1440cfcf24db8c50d929d3c35ab6f87f868fa628:

  Revert "venus: firmware: Correct non-pix start and end addresses" (2023-03-02 07:52:10 +0200)

----------------------------------------------------------------
Venus fixes for v6.3

----------------------------------------------------------------
Javier Martinez Canillas (1):
      Revert "venus: firmware: Correct non-pix start and end addresses"

 drivers/media/platform/qcom/venus/firmware.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Linux regression tracking (Thorsten Leemhuis) March 2, 2023, 8:27 a.m. UTC | #1 
On 02.03.23 07:04, Stanimir Varbanov wrote:
> 
> This pull request includes a fix for regression in venus hardware reset.
> The reverted commit has been merged in v6.2. 
> 
> Please pull.
> 
> regards,
> Stan
> 
> The following changes since commit 3e62aba8284de0994a669d07983299242e68fe72:
> 
>   media: imx-mipi-csis: Check csis_fmt validity before use (2023-02-26 11:21:33 +0100)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-fixes-for-v6.3
> 
> for you to fetch changes up to 1440cfcf24db8c50d929d3c35ab6f87f868fa628:
> 
>   Revert "venus: firmware: Correct non-pix start and end addresses" (2023-03-02 07:52:10 +0200)
> 
> ----------------------------------------------------------------
> Venus fixes for v6.3
> 
> ----------------------------------------------------------------
> Javier Martinez Canillas (1):
>       Revert "venus: firmware: Correct non-pix start and end addresses"

Good to see that this finally is heading towards mainline, thx.

What about the other venus regression[1] Javier provided this patch for:

https://patchwork.kernel.org/project/linux-media/patch/20230210081835.2054482-1-javierm@redhat.com/

[1] as pointed out earlier in
https://lore.kernel.org/all/87edq9hj4w.fsf@minerva.mail-host-address-is-not-set/

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot ^backmonitor:
https://lore.kernel.org/all/20230207102254.1446461-1-javierm@redhat.com/
Linux regression tracking (Thorsten Leemhuis) March 13, 2023, 2:28 p.m. UTC | #2 
On 02.03.23 09:27, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 02.03.23 07:04, Stanimir Varbanov wrote:
>>
>> This pull request includes a fix for regression in venus hardware reset.
>> The reverted commit has been merged in v6.2. 
>>
>> Please pull.

Mauro: any reason why this is still not pulled? It fixes a regression
that made it into 6.2 and the revert was now posted 34 days ago, hence
it would be good if this could finally go to Linus, so that it can be
backported to stable.

BTW, Stan: What...

>> The following changes since commit 3e62aba8284de0994a669d07983299242e68fe72:
>>
>>   media: imx-mipi-csis: Check csis_fmt validity before use (2023-02-26 11:21:33 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-fixes-for-v6.3
>>
>> for you to fetch changes up to 1440cfcf24db8c50d929d3c35ab6f87f868fa628:
>>
>>   Revert "venus: firmware: Correct non-pix start and end addresses" (2023-03-02 07:52:10 +0200)
>>
>> ----------------------------------------------------------------
>> Venus fixes for v6.3
>>
>> ----------------------------------------------------------------
>> Javier Martinez Canillas (1):
>>       Revert "venus: firmware: Correct non-pix start and end addresses"
> 
> Good to see that this finally is heading towards mainline, thx.
> 
> What about the other venus regression[1] Javier provided this patch for:
>
> https://patchwork.kernel.org/project/linux-media/patch/20230210081835.2054482-1-javierm@redhat.com/

...about this revert from Feb, 10th? There was some discussion recently,
but it would to get this finally resolved, too.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke
#regzbot ignore-activity
Stanimir Varbanov March 13, 2023, 5:48 p.m. UTC | #3 
Hi,

On 13.03.23 г. 16:28 ч., Thorsten Leemhuis wrote:
> On 02.03.23 09:27, Linux regression tracking (Thorsten Leemhuis) wrote:
>> On 02.03.23 07:04, Stanimir Varbanov wrote:
>>>
>>> This pull request includes a fix for regression in venus hardware reset.
>>> The reverted commit has been merged in v6.2.
>>>
>>> Please pull.
> 
> Mauro: any reason why this is still not pulled? It fixes a regression
> that made it into 6.2 and the revert was now posted 34 days ago, hence
> it would be good if this could finally go to Linus, so that it can be
> backported to stable.

I guess the best I can do is to include the revert in the next pull 
request for v6.4.

> 
> BTW, Stan: What...
> 
>>> The following changes since commit 3e62aba8284de0994a669d07983299242e68fe72:
>>>
>>>    media: imx-mipi-csis: Check csis_fmt validity before use (2023-02-26 11:21:33 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>    git://linuxtv.org/svarbanov/media_tree.git tags/tag-venus-fixes-for-v6.3
>>>
>>> for you to fetch changes up to 1440cfcf24db8c50d929d3c35ab6f87f868fa628:
>>>
>>>    Revert "venus: firmware: Correct non-pix start and end addresses" (2023-03-02 07:52:10 +0200)
>>>
>>> ----------------------------------------------------------------
>>> Venus fixes for v6.3
>>>
>>> ----------------------------------------------------------------
>>> Javier Martinez Canillas (1):
>>>        Revert "venus: firmware: Correct non-pix start and end addresses"
>>
>> Good to see that this finally is heading towards mainline, thx.
>>
>> What about the other venus regression[1] Javier provided this patch for:
>>
>> https://patchwork.kernel.org/project/linux-media/patch/20230210081835.2054482-1-javierm@redhat.com/
> 
> ...about this revert from Feb, 10th? There was some discussion recently,
> but it would to get this finally resolved, too.

I still have doubts about test coverage on db410c and RB3, because the 
firmware there behaves very differently and we can introduce another 
regression. If that happens we have to fix the fix in this patch. I'm 
working on the testing on those two devices.

> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 
> #regzbot poke
> #regzbot ignore-activity
Linux regression tracking (Thorsten Leemhuis) March 16, 2023, 9:52 a.m. UTC | #4 
On 13.03.23 18:48, Stanimir Varbanov wrote:
> On 13.03.23 г. 16:28 ч., Thorsten Leemhuis wrote:
>> On 02.03.23 09:27, Linux regression tracking (Thorsten Leemhuis) wrote:
>>> On 02.03.23 07:04, Stanimir Varbanov wrote:
>>>>
>>>> This pull request includes a fix for regression in venus hardware
>>>> reset.
>>>> The reverted commit has been merged in v6.2.
>>>> Please pull.
>> Mauro: any reason why this is still not pulled? It fixes a regression
>> that made it into 6.2 and the revert was now posted 34 days ago, hence
>> it would be good if this could finally go to Linus, so that it can be
>> backported to stable.
> 
> I guess the best I can do is to include the revert in the next pull
> request for v6.4.

Three more days went by without anything. Happen. I guess if Mauro
doesn't show up until Sunday I'll ask Linus to pull this directly (if he
actually does it is a different matter).

>> BTW, Stan: What...
>>
>>>> The following changes since commit
>>>> 3e62aba8284de0994a669d07983299242e68fe72:
>>>>
>>>>    media: imx-mipi-csis: Check csis_fmt validity before use
>>>> (2023-02-26 11:21:33 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>    git://linuxtv.org/svarbanov/media_tree.git
>>>> tags/tag-venus-fixes-for-v6.3
>>>>
>>>> for you to fetch changes up to
>>>> 1440cfcf24db8c50d929d3c35ab6f87f868fa628:
>>>>
>>>>    Revert "venus: firmware: Correct non-pix start and end addresses"
>>>> (2023-03-02 07:52:10 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Venus fixes for v6.3
>>>>
>>>> ----------------------------------------------------------------
>>>> Javier Martinez Canillas (1):
>>>>        Revert "venus: firmware: Correct non-pix start and end
>>>> addresses"
>>>
>>> Good to see that this finally is heading towards mainline, thx.
>>>
>>> What about the other venus regression[1] Javier provided this patch for:
>>>
>>> https://patchwork.kernel.org/project/linux-media/patch/20230210081835.2054482-1-javierm@redhat.com/
>>
>> ...about this revert from Feb, 10th? There was some discussion recently,
>> but it would to get this finally resolved, too.
> 
> I still have doubts about test coverage on db410c and RB3, because the
> firmware there behaves very differently and we can introduce another
> regression. If that happens we have to fix the fix in this patch.

BTW & FWIW, in these situations it sometimes is worth risking such an
outcome afaics. But whatever:

> I'm working on the testing on those two devices.

thx!

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.