Message ID | 20230104082212.3770415-1-arnd@kernel.org (mailing list archive) |
---|---|
State | Accepted |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1pCz2c-00B4Ty-5N; Wed, 04 Jan 2023 08:22:31 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbjADIW1 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 4 Jan 2023 03:22:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233897AbjADIWY (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 4 Jan 2023 03:22:24 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C072C186E9; Wed, 4 Jan 2023 00:22:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60545615C4; Wed, 4 Jan 2023 08:22:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89CFDC433D2; Wed, 4 Jan 2023 08:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672820542; bh=utRN27Crk/ZIcPnWApQgp9KevDbSfGZb7A9BBAaftmg=; h=From:To:Cc:Subject:Date:From; b=Q18SJ8QQ3upDQg3M1Zc9jZECSl7qUH/fuENzm2tdENAqqKC2ftIRGnEesl9TcV9iu wrT0NF9q9NIe5XxSeszHd/xklFaRAWdEBXbsPnV97BldertzSmaK94E0gcTU279rj7 iJsjGksw2qu0XW/p2OSCYe4hwzbkghHFmWpXEXmqUzoPYyLJ4dZ5zyNOcfqs9PuM7a ICBglqSBFW92pqFaQu/U9+SkvfF81k+Dy+Y3tTHTptwK09sW0h39sWhqc6S3fmOJSr r+PxdgQyMTMto9Vmi2358CAKCSgDE3oGzKsF2DgMov5xIpFFD1pKFBrgDfMWGywktT kpDjeIiOHs8Ww== From: Arnd Bergmann <arnd@kernel.org> To: Hans de Goede <hdegoede@redhat.com>, Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de>, Sakari Ailus <sakari.ailus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>, Andy Shevchenko <andy@kernel.org>, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency Date: Wed, 4 Jan 2023 09:21:36 +0100 Message-Id: <20230104082212.3770415-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -3.1 (---) X-LSpam-Report: No, score=-3.1 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
media: atomisp: fix videobuf2 Kconfig depenendency
|
|
Commit Message
Arnd Bergmann
Jan. 4, 2023, 8:21 a.m. UTC
From: Arnd Bergmann <arnd@arndb.de> The recent conversion missed the Kconfig bit, so it can now end up in a link error on randconfig builds: ld.lld: error: undefined symbol: vb2_vmalloc_memops >>> referenced by atomisp_fops.c >>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/media/atomisp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Jan 04, 2023 at 09:21:36AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The recent conversion missed the Kconfig bit, so it can now > end up in a link error on randconfig builds: > > ld.lld: error: undefined symbol: vb2_vmalloc_memops > >>> referenced by atomisp_fops.c > >>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a Tested-by: Andy Shevchenko <andy@kernel.org> > Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/staging/media/atomisp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig > index 2c8d7fdcc5f7..c9bff98e5309 100644 > --- a/drivers/staging/media/atomisp/Kconfig > +++ b/drivers/staging/media/atomisp/Kconfig > @@ -14,7 +14,7 @@ config VIDEO_ATOMISP > depends on VIDEO_DEV && INTEL_ATOMISP > depends on PMIC_OPREGION > select IOSF_MBI > - select VIDEOBUF_VMALLOC > + select VIDEOBUF2_VMALLOC > select VIDEO_V4L2_SUBDEV_API > help > Say Y here if your platform supports Intel Atom SoC > -- > 2.39.0 >
Hi, On 1/4/23 09:21, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The recent conversion missed the Kconfig bit, so it can now > end up in a link error on randconfig builds: > > ld.lld: error: undefined symbol: vb2_vmalloc_memops >>>> referenced by atomisp_fops.c >>>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a > > Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Mauro, can you pick this up and send it to Linus as a 6.1 fix? Regards, Hans > --- > drivers/staging/media/atomisp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig > index 2c8d7fdcc5f7..c9bff98e5309 100644 > --- a/drivers/staging/media/atomisp/Kconfig > +++ b/drivers/staging/media/atomisp/Kconfig > @@ -14,7 +14,7 @@ config VIDEO_ATOMISP > depends on VIDEO_DEV && INTEL_ATOMISP > depends on PMIC_OPREGION > select IOSF_MBI > - select VIDEOBUF_VMALLOC > + select VIDEOBUF2_VMALLOC > select VIDEO_V4L2_SUBDEV_API > help > Say Y here if your platform supports Intel Atom SoC
diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig index 2c8d7fdcc5f7..c9bff98e5309 100644 --- a/drivers/staging/media/atomisp/Kconfig +++ b/drivers/staging/media/atomisp/Kconfig @@ -14,7 +14,7 @@ config VIDEO_ATOMISP depends on VIDEO_DEV && INTEL_ATOMISP depends on PMIC_OPREGION select IOSF_MBI - select VIDEOBUF_VMALLOC + select VIDEOBUF2_VMALLOC select VIDEO_V4L2_SUBDEV_API help Say Y here if your platform supports Intel Atom SoC