diff mbox series

[V2] media: jpeg: Fix multi-hw judgement

Message ID 20221216035247.18816-1-irui.wang@mediatek.com (mailing list archive)
State Superseded
Delegated to: Hans Verkuil
Headers
Series [V2] media: jpeg: Fix multi-hw judgement |

Commit Message

Irui Wang Dec. 16, 2022, 3:52 a.m. UTC 
  From: kyrie wu <kyrie.wu@mediatek.com>

some chips have multi-hw, but others have only one,
modify the condition of multi-hw judgement

Fixs: 934e8bccac95 ("mtk-jpegenc: support jpegenc multi-hardware")

Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
Signed-off-by: irui wang <irui.wang@mediatek.com>
---
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c |  4 +++-
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h | 12 ++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

Comments

AngeloGioacchino Del Regno Dec. 20, 2022, 9:53 a.m. UTC | #1 
Il 16/12/22 04:52, Irui Wang ha scritto:
> From: kyrie wu <kyrie.wu@mediatek.com>
> 
> some chips have multi-hw, but others have only one,
> modify the condition of multi-hw judgement
> 
> Fixs: 934e8bccac95 ("mtk-jpegenc: support jpegenc multi-hardware")

Typo. s/Fixs/Fixes/g

Fix that, please.

Regards,
Angelo
Kyrie Wu (吴晗) Dec. 28, 2022, 7:29 a.m. UTC | #2 
On Tue, 2022-12-20 at 10:53 +0100, AngeloGioacchino Del Regno wrote:
> Il 16/12/22 04:52, Irui Wang ha scritto:
> > From: kyrie wu <kyrie.wu@mediatek.com>
> > 
> > some chips have multi-hw, but others have only one,
> > modify the condition of multi-hw judgement
> > 
> > Fixs: 934e8bccac95 ("mtk-jpegenc: support jpegenc multi-hardware")
> 
> Typo. s/Fixs/Fixes/g
> 
> Fix that, please.
> 
> Regards,
> Angelo
> 

Hi Angelo,

I will fix that issue in the next version.

Thanks.

Regards,
Kyrie.
Bagas Sanjaya Dec. 28, 2022, 12:29 p.m. UTC | #3 
On Fri, Dec 16, 2022 at 11:52:47AM +0800, Irui Wang wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
> 
> some chips have multi-hw, but others have only one,
> modify the condition of multi-hw judgement

nit: s/judgement/conditional block/ ...

> -	if (list_empty(&pdev->dev.devres_head)) {
> +	if (!jpeg->variant->hw_arch) {

... like here (if block).

Thanks.
Kyrie Wu (吴晗) Dec. 29, 2022, 8:19 a.m. UTC | #4 
On Wed, 2022-12-28 at 19:29 +0700, Bagas Sanjaya wrote:
> On Fri, Dec 16, 2022 at 11:52:47AM +0800, Irui Wang wrote:
> > From: kyrie wu <kyrie.wu@mediatek.com>
> > 
> > some chips have multi-hw, but others have only one,
> > modify the condition of multi-hw judgement
> 
> nit: s/judgement/conditional block/ ...
> 
> > -	if (list_empty(&pdev->dev.devres_head)) {
> > +	if (!jpeg->variant->hw_arch) {
> 
> ... like here (if block).
> 
> Thanks.

Hi Bagas,

I can't get your suggestion exactly.
Do you mean to change if (...) as follows:
if (jpeg->variant->hw_arch)
> 

Thanks.

Regards,
Kyrie.
Bagas Sanjaya Dec. 30, 2022, 9:06 a.m. UTC | #5 
On 12/29/22 15:19, Kyrie Wu (吴晗) wrote:
> On Wed, 2022-12-28 at 19:29 +0700, Bagas Sanjaya wrote:
>> On Fri, Dec 16, 2022 at 11:52:47AM +0800, Irui Wang wrote:
>> > From: kyrie wu <kyrie.wu@mediatek.com>
>> > 
>> > some chips have multi-hw, but others have only one,
>> > modify the condition of multi-hw judgement
>> 
>> nit: s/judgement/conditional block/ ...
>> 
>> > -if (list_empty(&pdev->dev.devres_head)) {
>> > +if (!jpeg->variant->hw_arch) {
>> 
>> ... like here (if block).
>> 
>> Thanks.
> 
> Hi Bagas,
> 
> I can't get your suggestion exactly.
> Do you mean to change if (...) as follows:
> if (jpeg->variant->hw_arch)

No, not what I mean. I pointed you at the correct terminology
with your code as example.

Thanks.
diff mbox series

Patch

diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index 18e867a79f12..7472c1ee23ab 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -1694,7 +1694,7 @@  static int mtk_jpeg_probe(struct platform_device *pdev)
 		return -EINVAL;
  	}
 
-	if (list_empty(&pdev->dev.devres_head)) {
+	if (!jpeg->variant->hw_arch) {
 		INIT_DELAYED_WORK(&jpeg->job_timeout_work,
 				  mtk_jpeg_job_timeout_work);
 
@@ -1889,6 +1889,7 @@  static struct mtk_jpeg_variant mtk8195_jpegenc_drvdata = {
 	.ioctl_ops = &mtk_jpeg_enc_ioctl_ops,
 	.out_q_default_fourcc = V4L2_PIX_FMT_YUYV,
 	.cap_q_default_fourcc = V4L2_PIX_FMT_JPEG,
+	.hw_arch = MTK_JPEG_HW_MULTI_CORE,
 };
 
 static const struct mtk_jpeg_variant mtk8195_jpegdec_drvdata = {
@@ -1900,6 +1901,7 @@  static const struct mtk_jpeg_variant mtk8195_jpegdec_drvdata = {
 	.ioctl_ops = &mtk_jpeg_dec_ioctl_ops,
 	.out_q_default_fourcc = V4L2_PIX_FMT_JPEG,
 	.cap_q_default_fourcc = V4L2_PIX_FMT_YUV420M,
+	.hw_arch = MTK_JPEG_HW_MULTI_CORE,
 };
 
 #if defined(CONFIG_OF)
diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h
index b9126476be8f..ec04a8ce73cf 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h
@@ -46,6 +46,16 @@  enum mtk_jpeg_ctx_state {
 	MTK_JPEG_SOURCE_CHANGE,
 };
 
+/**
+ * enum mtk_jpeg_hw_arch - arch of the jpeg hw
+ * @MTK_JPEG_HW_SINGLE_CORE:	jpeg hw is single core
+ * @MTK_JPEG_HW_MULTI_CORE:		jpeg hw is mluti-core
+ */
+enum mtk_jpeg_hw_arch {
+	MTK_JPEG_HW_SINGLE_CORE = 0,
+	MTK_JPEG_HW_MULTI_CORE = 1,
+};
+
 /**
  * struct mtk_jpeg_variant - mtk jpeg driver variant
  * @clks:			clock names
@@ -60,6 +70,7 @@  enum mtk_jpeg_ctx_state {
  * @ioctl_ops:			the callback of jpeg v4l2_ioctl_ops
  * @out_q_default_fourcc:	output queue default fourcc
  * @cap_q_default_fourcc:	capture queue default fourcc
+ * @hw_arch:            mark jpeg hw arch
  */
 struct mtk_jpeg_variant {
 	struct clk_bulk_data *clks;
@@ -74,6 +85,7 @@  struct mtk_jpeg_variant {
 	const struct v4l2_ioctl_ops *ioctl_ops;
 	u32 out_q_default_fourcc;
 	u32 cap_q_default_fourcc;
+	enum mtk_jpeg_hw_arch hw_arch;
 };
 
 struct mtk_jpeg_src_buf {