Message ID | 20221222191500.515795-2-umang.jain@ideasonboard.com (mailing list archive) |
---|---|
State | Superseded |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1p8R2N-0038pF-80; Thu, 22 Dec 2022 19:15:27 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235107AbiLVTPW (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 22 Dec 2022 14:15:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230206AbiLVTPV (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 22 Dec 2022 14:15:21 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 346FC27DE4; Thu, 22 Dec 2022 11:15:20 -0800 (PST) Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 42193890; Thu, 22 Dec 2022 20:15:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671736518; bh=6uYCqoGzATUwi33s8qwvH2BR201HZIZgkpsRD/uga5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ngtNY6j8Irf0q8DYlJnrYOOiK2jqTxM+kAzkuHj3rAgfw3ZJABT0ddX64ZpV3JJ1P NM9rWtLFodm8PIs2zQIisV8Iswy9mhy0JyIS0qXs3yVy1vdnZ5zXj2speGm+fyQJju VmkFWDDPv1gYfAVBZ0PMD60gGTEPetazrd/wcVY0= From: Umang Jain <umang.jain@ideasonboard.com> To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Adrien Thierry <athierry@redhat.com>, Stefan Wahren <stefan.wahren@i2se.com>, Florian Fainelli <f.fainelli@gmail.com>, Dan Carpenter <error27@gmail.com>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Phil Elwell <phil@raspberrypi.com>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Kieran Bingham <kieran.bingham@ideasonboard.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Umang Jain <umang.jain@ideasonboard.com> Subject: [PATCH v2 1/4] staging: vc04_services: Stop leaking platform device on error path Date: Fri, 23 Dec 2022 00:44:57 +0530 Message-Id: <20221222191500.515795-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221222191500.515795-1-umang.jain@ideasonboard.com> References: <20221222191500.515795-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
staging: vchiq: Rework child platform device (un)register
|
|
Commit Message
Umang Jain
Dec. 22, 2022, 7:14 p.m. UTC
vchiq driver registers the child platform devices in
vchiq_register_child(). However, in the registration error code path,
currently the driver is leaking platform devices by not destroying the
return platform device. Plug this leak using platform_device_put() as
mentioned in the documentation for platform_device_register().
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Umang, Am 22.12.22 um 20:14 schrieb Umang Jain: > vchiq driver registers the child platform devices in > vchiq_register_child(). However, in the registration error code path, > currently the driver is leaking platform devices by not destroying the > return platform device. Plug this leak using platform_device_put() as > mentioned in the documentation for platform_device_register(). > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index dc33490ba7fb..fc7ea7ba97b2 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -1779,6 +1779,7 @@ vchiq_register_child(struct platform_device *pdev, const char *name) > child = platform_device_register_full(&pdevinfo); > if (IS_ERR(child)) { > dev_warn(&pdev->dev, "%s not registered\n", name); > + platform_device_put(child); why should we free an error? > child = NULL; > } >
Hi Umang, Thank you for the patch. On Fri, Dec 23, 2022 at 12:44:57AM +0530, Umang Jain wrote: > vchiq driver registers the child platform devices in > vchiq_register_child(). However, in the registration error code path, > currently the driver is leaking platform devices by not destroying the > return platform device. Plug this leak using platform_device_put() as > mentioned in the documentation for platform_device_register(). > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index dc33490ba7fb..fc7ea7ba97b2 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -1779,6 +1779,7 @@ vchiq_register_child(struct platform_device *pdev, const char *name) > child = platform_device_register_full(&pdevinfo); > if (IS_ERR(child)) { > dev_warn(&pdev->dev, "%s not registered\n", name); > + platform_device_put(child); If IS_ERR(child), what do you expect platform_device_put(child) to do ? And have you read the implementation of platform_device_register_full() ? > child = NULL; > } >
Hi, On 12/23/22 2:00 AM, Laurent Pinchart wrote: > Hi Umang, > > Thank you for the patch. > > On Fri, Dec 23, 2022 at 12:44:57AM +0530, Umang Jain wrote: >> vchiq driver registers the child platform devices in >> vchiq_register_child(). However, in the registration error code path, >> currently the driver is leaking platform devices by not destroying the >> return platform device. Plug this leak using platform_device_put() as >> mentioned in the documentation for platform_device_register(). >> >> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> >> --- >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> index dc33490ba7fb..fc7ea7ba97b2 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> @@ -1779,6 +1779,7 @@ vchiq_register_child(struct platform_device *pdev, const char *name) >> child = platform_device_register_full(&pdevinfo); >> if (IS_ERR(child)) { >> dev_warn(&pdev->dev, "%s not registered\n", name); >> + platform_device_put(child); > If IS_ERR(child), what do you expect platform_device_put(child) to do ? > And have you read the implementation of platform_device_register_full() > ? Errr, yeah - it is handling the platform_device_put() as well. Stupid me! (dropping this patch for v3) > >> child = NULL; >> } >>
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index dc33490ba7fb..fc7ea7ba97b2 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1779,6 +1779,7 @@ vchiq_register_child(struct platform_device *pdev, const char *name) child = platform_device_register_full(&pdevinfo); if (IS_ERR(child)) { dev_warn(&pdev->dev, "%s not registered\n", name); + platform_device_put(child); child = NULL; }