[v5,0/2] ov9282: Add ov9281 support

  Hello all,

This is v5 of the ov9281 support series. Thanks for the feedback I received
over the time.

Changes in v5:
* Removed unrelated patches from the series
* Squashed previous patch 3 & 6 (now patch 2)
* Removed error handling for device_get_match_data() call
* Added Kieran's r-b to patch 2

Best regards,
Alexander

Alexander Stein (2):
  media: dt-bindings: media: Add compatible for ov9281
  media: i2c: ov9282: Add ov9281 compatible

 Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 5 ++++-
 drivers/media/i2c/ov9282.c                                   | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)
  

Hi Alexander,

On 11/24/22 11:29, Alexander Stein wrote:
> Hello all,
> 
> This is v5 of the ov9281 support series. Thanks for the feedback I received
> over the time.
> 
> Changes in v5:
> * Removed unrelated patches from the series
> * Squashed previous patch 3 & 6 (now patch 2)
> * Removed error handling for device_get_match_data() call
> * Added Kieran's r-b to patch 2
> 
> Best regards,
> Alexander
> 
> Alexander Stein (2):
>   media: dt-bindings: media: Add compatible for ov9281
>   media: i2c: ov9282: Add ov9281 compatible
> 
>  Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 5 ++++-
>  drivers/media/i2c/ov9282.c                                   | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 

With the latest staging tree I am now getting these smatch and sparse warnings:

sparse:

drivers/media/i2c/ov9282.c:267:24: warning: symbol 'common_regs_list' was not declared. Should it be static?
drivers/media/i2c/ov9282.c:145: warning: Function parameter or member 'crop' not described in 'ov9282_mode'
drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'supplies' not described in 'ov9282'
drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'pixel_rate' not described in 'ov9282'
drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'noncontinuous_clock' not described in 'ov9282'

smatch also has this:

drivers/media/i2c/ov9282.c:1262 ov9282_power_on() warn: 'ov9282->inclk' from clk_prepare_enable() not released on lines: 1252.

Can you take a look and post a patch on top fixing this?

Thanks!

	Hans
  

Hi Hans,

On Mon, Nov 28, 2022 at 02:52:28PM +0100, Hans Verkuil wrote:
> Hi Alexander,
> 
> On 11/24/22 11:29, Alexander Stein wrote:
> > Hello all,
> > 
> > This is v5 of the ov9281 support series. Thanks for the feedback I received
> > over the time.
> > 
> > Changes in v5:
> > * Removed unrelated patches from the series
> > * Squashed previous patch 3 & 6 (now patch 2)
> > * Removed error handling for device_get_match_data() call
> > * Added Kieran's r-b to patch 2
> > 
> > Best regards,
> > Alexander
> > 
> > Alexander Stein (2):
> >   media: dt-bindings: media: Add compatible for ov9281
> >   media: i2c: ov9282: Add ov9281 compatible
> > 
> >  Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 5 ++++-
> >  drivers/media/i2c/ov9282.c                                   | 5 ++++-
> >  2 files changed, 8 insertions(+), 2 deletions(-)
> > 
> 
> With the latest staging tree I am now getting these smatch and sparse warnings:
> 
> sparse:
> 
> drivers/media/i2c/ov9282.c:267:24: warning: symbol 'common_regs_list' was not declared. Should it be static?
> drivers/media/i2c/ov9282.c:145: warning: Function parameter or member 'crop' not described in 'ov9282_mode'
> drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'supplies' not described in 'ov9282'
> drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'pixel_rate' not described in 'ov9282'
> drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'noncontinuous_clock' not described in 'ov9282'
> 
> smatch also has this:
> 
> drivers/media/i2c/ov9282.c:1262 ov9282_power_on() warn: 'ov9282->inclk' from clk_prepare_enable() not released on lines: 1252.
> 
> Can you take a look and post a patch on top fixing this?

The two patches aren't the culprit. I've seen a report on this, too. Let's
continue on the other thread once found.
  

Hi Hans & Sakari

On Mon, 28 Nov 2022 at 13:58, Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
> Hi Hans,
>
> On Mon, Nov 28, 2022 at 02:52:28PM +0100, Hans Verkuil wrote:
> > Hi Alexander,
> >
> > On 11/24/22 11:29, Alexander Stein wrote:
> > > Hello all,
> > >
> > > This is v5 of the ov9281 support series. Thanks for the feedback I received
> > > over the time.
> > >
> > > Changes in v5:
> > > * Removed unrelated patches from the series
> > > * Squashed previous patch 3 & 6 (now patch 2)
> > > * Removed error handling for device_get_match_data() call
> > > * Added Kieran's r-b to patch 2
> > >
> > > Best regards,
> > > Alexander
> > >
> > > Alexander Stein (2):
> > >   media: dt-bindings: media: Add compatible for ov9281
> > >   media: i2c: ov9282: Add ov9281 compatible
> > >
> > >  Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 5 ++++-
> > >  drivers/media/i2c/ov9282.c                                   | 5 ++++-
> > >  2 files changed, 8 insertions(+), 2 deletions(-)
> > >
> >
> > With the latest staging tree I am now getting these smatch and sparse warnings:
> >
> > sparse:
> >
> > drivers/media/i2c/ov9282.c:267:24: warning: symbol 'common_regs_list' was not declared. Should it be static?
> > drivers/media/i2c/ov9282.c:145: warning: Function parameter or member 'crop' not described in 'ov9282_mode'
> > drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'supplies' not described in 'ov9282'
> > drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'pixel_rate' not described in 'ov9282'
> > drivers/media/i2c/ov9282.c:190: warning: Function parameter or member 'noncontinuous_clock' not described in 'ov9282'
> >
> > smatch also has this:
> >
> > drivers/media/i2c/ov9282.c:1262 ov9282_power_on() warn: 'ov9282->inclk' from clk_prepare_enable() not released on lines: 1252.
> >
> > Can you take a look and post a patch on top fixing this?
>
> The two patches aren't the culprit. I've seen a report on this, too. Let's
> continue on the other thread once found.

These look to come from my series [1]. I'll send patches in a moment.

  Dave

[1] https://patchwork.linuxtv.org/project/linux-media/patch/20221028160902.2696973-2-dave.stevenson@raspberrypi.com/

> --
> Kind regards,
>
> Sakari Ailus