[00/14] media: atomisp: More cleanups / code removal

  Hi Mauro,

Here is a second set of atomisp cleanups / code removal.
This applies on top of my previous v2 series from here:
https://lore.kernel.org/linux-media/20220822150610.45186-1-hdegoede@redhat.com/

I plan to do more atomisp work the coming few weeks. So I'm thinking
it might be better / easier for you if I just send you a pull-req based
on 6.0-rc1 with all atomisp patches bundled around rc5/rc6 time.

Would that work for you ?

I do plan to keep sending out (incremental) patch-sets with my work
(like this one) for review / comments.

Regards,

Hans


Dan Carpenter (1):
  media: atomisp: prevent integer overflow in sh_css_set_black_frame()

Hans de Goede (13):
  media: atomisp: Fix device_caps reporting of the registered video-devs
  media: atomisp: Remove file-injection support
  media: atomisp: Remove atomisp_file_fops and atomisp_file_ioctl_ops
  media: atomisp: Remove the outq videobuf queue
  media: atomisp: Remove never set file_input flag
  media: atomisp: Remove the ACC device node
  media: atomisp: Remove some further ATOMISP_ACC_* related dead code
  media: atomisp: Remove empty atomisp_css_set_cont_prev_start_time()
    function
  media: atomisp: Split subdev and video-node registration into 2 steps
  media: atomisp: Register /dev/* nodes at the end of
    atomisp_pci_probe()
  media: atomisp: Remove loading mutex
  media: atomisp: Fix v4l2_fh resource leak on open errors
  media: atomisp: Simplify v4l2_fh_open() error handling

 drivers/staging/media/atomisp/Makefile        |   1 -
 .../media/atomisp/include/linux/atomisp.h     |  14 --
 .../staging/media/atomisp/pci/atomisp_cmd.c   | 134 +---------
 .../staging/media/atomisp/pci/atomisp_cmd.h   |   2 -
 .../media/atomisp/pci/atomisp_compat.h        |   6 -
 .../media/atomisp/pci/atomisp_compat_css20.c  |  26 --
 .../staging/media/atomisp/pci/atomisp_file.c  | 229 ------------------
 .../staging/media/atomisp/pci/atomisp_file.h  |  44 ----
 .../staging/media/atomisp/pci/atomisp_fops.c  | 187 ++------------
 .../media/atomisp/pci/atomisp_internal.h      |  16 +-
 .../staging/media/atomisp/pci/atomisp_ioctl.c | 192 ++-------------
 .../staging/media/atomisp/pci/atomisp_ioctl.h |   4 -
 .../media/atomisp/pci/atomisp_subdev.c        |  95 ++------
 .../media/atomisp/pci/atomisp_subdev.h        |  47 +---
 .../staging/media/atomisp/pci/atomisp_v4l2.c  |  99 +++-----
 .../staging/media/atomisp/pci/atomisp_v4l2.h  |   3 -
 .../staging/media/atomisp/pci/sh_css_params.c |   4 +-
 17 files changed, 104 insertions(+), 999 deletions(-)
 delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_file.c
 delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_file.h
  

Em Thu,  1 Sep 2022 11:46:12 +0200
Hans de Goede <hdegoede@redhat.com> escreveu:

> Hi Mauro,
> 
> Here is a second set of atomisp cleanups / code removal.
> This applies on top of my previous v2 series from here:
> https://lore.kernel.org/linux-media/20220822150610.45186-1-hdegoede@redhat.com/
> 
> I plan to do more atomisp work the coming few weeks. So I'm thinking
> it might be better / easier for you if I just send you a pull-req based
> on 6.0-rc1 with all atomisp patches bundled around rc5/rc6 time.
> 
> Would that work for you ?

Yes, that works for me. I'm actually proritizing PRs over normal patches
from media maintainers. As you're doing most of work on it, I can
start picking PRs from you related to atomisp.

This will help to speedup merging atomisp patches, as I usually pick
PRs once per week.

> 
> I do plan to keep sending out (incremental) patch-sets with my work
> (like this one) for review / comments.

Perfect.
> 
> Regards,
> 
> Hans
> 
> 
> Dan Carpenter (1):
>   media: atomisp: prevent integer overflow in sh_css_set_black_frame()
> 
> Hans de Goede (13):
>   media: atomisp: Fix device_caps reporting of the registered video-devs
>   media: atomisp: Remove file-injection support
>   media: atomisp: Remove atomisp_file_fops and atomisp_file_ioctl_ops
>   media: atomisp: Remove the outq videobuf queue
>   media: atomisp: Remove never set file_input flag
>   media: atomisp: Remove the ACC device node
>   media: atomisp: Remove some further ATOMISP_ACC_* related dead code
>   media: atomisp: Remove empty atomisp_css_set_cont_prev_start_time()
>     function
>   media: atomisp: Split subdev and video-node registration into 2 steps
>   media: atomisp: Register /dev/* nodes at the end of
>     atomisp_pci_probe()
>   media: atomisp: Remove loading mutex
>   media: atomisp: Fix v4l2_fh resource leak on open errors
>   media: atomisp: Simplify v4l2_fh_open() error handling
> 
>  drivers/staging/media/atomisp/Makefile        |   1 -
>  .../media/atomisp/include/linux/atomisp.h     |  14 --
>  .../staging/media/atomisp/pci/atomisp_cmd.c   | 134 +---------
>  .../staging/media/atomisp/pci/atomisp_cmd.h   |   2 -
>  .../media/atomisp/pci/atomisp_compat.h        |   6 -
>  .../media/atomisp/pci/atomisp_compat_css20.c  |  26 --
>  .../staging/media/atomisp/pci/atomisp_file.c  | 229 ------------------
>  .../staging/media/atomisp/pci/atomisp_file.h  |  44 ----
>  .../staging/media/atomisp/pci/atomisp_fops.c  | 187 ++------------
>  .../media/atomisp/pci/atomisp_internal.h      |  16 +-
>  .../staging/media/atomisp/pci/atomisp_ioctl.c | 192 ++-------------
>  .../staging/media/atomisp/pci/atomisp_ioctl.h |   4 -
>  .../media/atomisp/pci/atomisp_subdev.c        |  95 ++------
>  .../media/atomisp/pci/atomisp_subdev.h        |  47 +---
>  .../staging/media/atomisp/pci/atomisp_v4l2.c  |  99 +++-----
>  .../staging/media/atomisp/pci/atomisp_v4l2.h  |   3 -
>  .../staging/media/atomisp/pci/sh_css_params.c |   4 +-
>  17 files changed, 104 insertions(+), 999 deletions(-)
>  delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_file.c
>  delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_file.h
> 



Thanks,
Mauro
  

Hi,

On 9/1/22 17:08, Mauro Carvalho Chehab wrote:
> Em Thu,  1 Sep 2022 11:46:12 +0200
> Hans de Goede <hdegoede@redhat.com> escreveu:
> 
>> Hi Mauro,
>>
>> Here is a second set of atomisp cleanups / code removal.
>> This applies on top of my previous v2 series from here:
>> https://lore.kernel.org/linux-media/20220822150610.45186-1-hdegoede@redhat.com/
>>
>> I plan to do more atomisp work the coming few weeks. So I'm thinking
>> it might be better / easier for you if I just send you a pull-req based
>> on 6.0-rc1 with all atomisp patches bundled around rc5/rc6 time.
>>
>> Would that work for you ?
> 
> Yes, that works for me. I'm actually proritizing PRs over normal patches
> from media maintainers. As you're doing most of work on it, I can
> start picking PRs from you related to atomisp.

Sounds good.

Note I have also been picking up various small fixes from others both
for testing and to make sure they don't get lost. So I plan to include
those into the pull-req around rc5/6 time too.

Regards,

Hans



>> Dan Carpenter (1):
>>   media: atomisp: prevent integer overflow in sh_css_set_black_frame()
>>
>> Hans de Goede (13):
>>   media: atomisp: Fix device_caps reporting of the registered video-devs
>>   media: atomisp: Remove file-injection support
>>   media: atomisp: Remove atomisp_file_fops and atomisp_file_ioctl_ops
>>   media: atomisp: Remove the outq videobuf queue
>>   media: atomisp: Remove never set file_input flag
>>   media: atomisp: Remove the ACC device node
>>   media: atomisp: Remove some further ATOMISP_ACC_* related dead code
>>   media: atomisp: Remove empty atomisp_css_set_cont_prev_start_time()
>>     function
>>   media: atomisp: Split subdev and video-node registration into 2 steps
>>   media: atomisp: Register /dev/* nodes at the end of
>>     atomisp_pci_probe()
>>   media: atomisp: Remove loading mutex
>>   media: atomisp: Fix v4l2_fh resource leak on open errors
>>   media: atomisp: Simplify v4l2_fh_open() error handling
>>
>>  drivers/staging/media/atomisp/Makefile        |   1 -
>>  .../media/atomisp/include/linux/atomisp.h     |  14 --
>>  .../staging/media/atomisp/pci/atomisp_cmd.c   | 134 +---------
>>  .../staging/media/atomisp/pci/atomisp_cmd.h   |   2 -
>>  .../media/atomisp/pci/atomisp_compat.h        |   6 -
>>  .../media/atomisp/pci/atomisp_compat_css20.c  |  26 --
>>  .../staging/media/atomisp/pci/atomisp_file.c  | 229 ------------------
>>  .../staging/media/atomisp/pci/atomisp_file.h  |  44 ----
>>  .../staging/media/atomisp/pci/atomisp_fops.c  | 187 ++------------
>>  .../media/atomisp/pci/atomisp_internal.h      |  16 +-
>>  .../staging/media/atomisp/pci/atomisp_ioctl.c | 192 ++-------------
>>  .../staging/media/atomisp/pci/atomisp_ioctl.h |   4 -
>>  .../media/atomisp/pci/atomisp_subdev.c        |  95 ++------
>>  .../media/atomisp/pci/atomisp_subdev.h        |  47 +---
>>  .../staging/media/atomisp/pci/atomisp_v4l2.c  |  99 +++-----
>>  .../staging/media/atomisp/pci/atomisp_v4l2.h  |   3 -
>>  .../staging/media/atomisp/pci/sh_css_params.c |   4 +-
>>  17 files changed, 104 insertions(+), 999 deletions(-)
>>  delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_file.c
>>  delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_file.h
>>
> 
> 
> 
> Thanks,
> Mauro
>
  

On Thu, Sep 01, 2022 at 11:46:12AM +0200, Hans de Goede wrote:
> Hi Mauro,
> 
> Here is a second set of atomisp cleanups / code removal.
> This applies on top of my previous v2 series from here:
> https://lore.kernel.org/linux-media/20220822150610.45186-1-hdegoede@redhat.com/

I looked into the code (mostly commit message and patches that not only delete
the stuff) and it LGTM, hence
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

> I plan to do more atomisp work the coming few weeks. So I'm thinking
> it might be better / easier for you if I just send you a pull-req based
> on 6.0-rc1 with all atomisp patches bundled around rc5/rc6 time.
> 
> Would that work for you ?
> 
> I do plan to keep sending out (incremental) patch-sets with my work
> (like this one) for review / comments.

Perhaps it's a time you add yourself as AtomISP2 (co-?)maintainer?