Message ID | 20220722082858.17880-1-yuji2.ishikawa@toshiba.co.jp (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1oEo7Y-003mOI-Ku; Fri, 22 Jul 2022 08:34:55 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235002AbiGVIeu (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 22 Jul 2022 04:34:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231807AbiGVIeu (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 22 Jul 2022 04:34:50 -0400 Received: from mo-csw.securemx.jp (mo-csw1514.securemx.jp [210.130.202.153]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3BE79EC42; Fri, 22 Jul 2022 01:34:48 -0700 (PDT) Received: by mo-csw.securemx.jp (mx-mo-csw1514) id 26M8YCXB031306; Fri, 22 Jul 2022 17:34:12 +0900 X-Iguazu-Qid: 34trpbd9I5QiEQLLEO X-Iguazu-QSIG: v=2; s=0; t=1658478851; q=34trpbd9I5QiEQLLEO; m=EUB3sIfsoyZ7QDFQ7pwFPBHYPpSEDZRaTCda0U/hj4g= Received: from imx12-a.toshiba.co.jp ([38.106.60.135]) by relay.securemx.jp (mx-mr1513) id 26M8YAPq008986 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 22 Jul 2022 17:34:10 +0900 X-SA-MID: 39258132 From: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> To: Rob Herring <robh+dt@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Jonathan Corbet <corbet@lwn.net>, Sumit Semwal <sumit.semwal@linaro.org>, =?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, yuji2.ishikawa@toshiba.co.jp Subject: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver Date: Fri, 22 Jul 2022 17:28:53 +0900 X-TSB-HOP2: ON Message-Id: <20220722082858.17880-1-yuji2.ishikawa@toshiba.co.jp> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
Add Toshiba Visconti DNN image processing accelerator driver
|
|
Message
Yuji Ishikawa
July 22, 2022, 8:28 a.m. UTC
This series is the DNN image processing accelerator driver for Toshiba's ARM SoC, Visconti[0]. This provides DT binding documentation, device driver, MAINTAINER files and documents. Best regards, Yuji [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings v1 -> v2: - No update soc: visconti: Add Toshiba Visconti image processing accelerator common source v1 -> v2: - checked with checkpatch.pl --strict soc: visconti: Add Toshiba Visconti DNN image processing accelerator v1 -> v2: - checked with checkpatch.pl --strict - removed unused code MAINTAINERS: Add entries for Toshiba Visconti DNN image processing v1 -> v2: - No update Documentation: driver-api: visconti: add a description of DNN driver. v1 -> v2: - newly added documents Yuji Ishikawa (5): dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings soc: visconti: Add Toshiba Visconti image processing accelerator common source soc: visconti: Add Toshiba Visconti DNN image processing accelerator MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator Documentation: driver-api: visconti: add a description of DNN driver. .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++ Documentation/driver-api/visconti/common.rst | 115 ++++ Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++ MAINTAINERS | 2 + drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/visconti/Kconfig | 7 + drivers/soc/visconti/Makefile | 8 + drivers/soc/visconti/dnn/Makefile | 6 + drivers/soc/visconti/dnn/dnn.c | 523 ++++++++++++++++++ drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++ drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++ drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++ drivers/soc/visconti/ipa_common.c | 55 ++ drivers/soc/visconti/ipa_common.h | 18 + drivers/soc/visconti/uapi/dnn.h | 77 +++ drivers/soc/visconti/uapi/ipa.h | 90 +++ 17 files changed, 1830 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/visconti/toshiba,visconti-dnn.yaml create mode 100644 Documentation/driver-api/visconti/common.rst create mode 100644 Documentation/driver-api/visconti/dnn.rst create mode 100644 drivers/soc/visconti/Kconfig create mode 100644 drivers/soc/visconti/Makefile create mode 100644 drivers/soc/visconti/dnn/Makefile create mode 100644 drivers/soc/visconti/dnn/dnn.c create mode 100644 drivers/soc/visconti/dnn/hwd_dnn.c create mode 100644 drivers/soc/visconti/dnn/hwd_dnn.h create mode 100644 drivers/soc/visconti/dnn/hwd_dnn_reg.h create mode 100644 drivers/soc/visconti/ipa_common.c create mode 100644 drivers/soc/visconti/ipa_common.h create mode 100644 drivers/soc/visconti/uapi/dnn.h create mode 100644 drivers/soc/visconti/uapi/ipa.h
Comments
On Fri, Jul 22, 2022 at 05:28:53PM +0900, Yuji Ishikawa wrote: > This series is the DNN image processing accelerator driver for Toshiba's ARM SoC, Visconti[0]. > This provides DT binding documentation, device driver, MAINTAINER files and documents. > > Best regards, > Yuji > > [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings > v1 -> v2: > - No update > > soc: visconti: Add Toshiba Visconti image processing accelerator common source > v1 -> v2: > - checked with checkpatch.pl --strict > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > v1 -> v2: > - checked with checkpatch.pl --strict > - removed unused code > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > v1 -> v2: > - No update > > Documentation: driver-api: visconti: add a description of DNN driver. > v1 -> v2: > - newly added documents > > Yuji Ishikawa (5): > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > accelerator bindings > soc: visconti: Add Toshiba Visconti image processing accelerator > common source > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > accelerator > Documentation: driver-api: visconti: add a description of DNN driver. > > .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++ > Documentation/driver-api/visconti/common.rst | 115 ++++ > Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++ > MAINTAINERS | 2 + > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/visconti/Kconfig | 7 + > drivers/soc/visconti/Makefile | 8 + > drivers/soc/visconti/dnn/Makefile | 6 + > drivers/soc/visconti/dnn/dnn.c | 523 ++++++++++++++++++ > drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++ > drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++ > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++ > drivers/soc/visconti/ipa_common.c | 55 ++ > drivers/soc/visconti/ipa_common.h | 18 + > drivers/soc/visconti/uapi/dnn.h | 77 +++ > drivers/soc/visconti/uapi/ipa.h | 90 +++ Why is this in drivers/soc/? And uapi files belong in the correct include path, not burried in a driver subdirectory where they will never be picked up correctly by the build system. How did you test these? thanks, greg k-h
Hi Greg Thank you for your comments. > -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Monday, July 25, 2022 9:47 PM > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > <yuji2.ishikawa@toshiba.co.jp> > Cc: Rob Herring <robh+dt@kernel.org>; Hans Verkuil <hverkuil@xs4all.nl>; > iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > <nobuhiro1.iwamatsu@toshiba.co.jp>; Jonathan Corbet <corbet@lwn.net>; > Sumit Semwal <sumit.semwal@linaro.org>; Christian König > <christian.koenig@amd.com>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > Subject: Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing > accelerator driver > > On Fri, Jul 22, 2022 at 05:28:53PM +0900, Yuji Ishikawa wrote: > > This series is the DNN image processing accelerator driver for Toshiba's ARM > SoC, Visconti[0]. > > This provides DT binding documentation, device driver, MAINTAINER files > and documents. > > > > Best regards, > > Yuji > > > > [0]: > > > https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image- > > recognition-processors-visconti.html > > > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > accelerator bindings > > v1 -> v2: > > - No update > > > > soc: visconti: Add Toshiba Visconti image processing accelerator common > source > > v1 -> v2: > > - checked with checkpatch.pl --strict > > > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > > v1 -> v2: > > - checked with checkpatch.pl --strict > > - removed unused code > > > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > > v1 -> v2: > > - No update > > > > Documentation: driver-api: visconti: add a description of DNN driver. > > v1 -> v2: > > - newly added documents > > > > Yuji Ishikawa (5): > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > > accelerator bindings > > soc: visconti: Add Toshiba Visconti image processing accelerator > > common source > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > > accelerator > > Documentation: driver-api: visconti: add a description of DNN driver. > > > > .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++ > > Documentation/driver-api/visconti/common.rst | 115 ++++ > > Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++ > > MAINTAINERS | 2 + > > drivers/soc/Kconfig | 1 + > > drivers/soc/Makefile | 1 + > > drivers/soc/visconti/Kconfig | 7 + > > drivers/soc/visconti/Makefile | 8 + > > drivers/soc/visconti/dnn/Makefile | 6 + > > drivers/soc/visconti/dnn/dnn.c | 523 > ++++++++++++++++++ > > drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++ > > drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++ > > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++ > > drivers/soc/visconti/ipa_common.c | 55 ++ > > drivers/soc/visconti/ipa_common.h | 18 + > > drivers/soc/visconti/uapi/dnn.h | 77 +++ > > drivers/soc/visconti/uapi/ipa.h | 90 +++ > > Why is this in drivers/soc/? Actually, I'm not sure where his module should live in. The directory drivers/soc were chosen just because the driver is specific to Visconti SoC. Is it better to move the driver to another directory such as drivers/misc ? > And uapi files belong in the correct include path, not burried in a driver > subdirectory where they will never be picked up correctly by the build system. > How did you test these? I understand it's not a good idea to place uapi files under driver subdirectory. A build command "make headers_install" did not pick out headers. I used additional shell script to install headers for Visconti. I'll move uapi headers to include/uapi/linux. > thanks, > > greg k-h Regards, Yuji
On Tue, Jul 26, 2022 at 06:09:50AM +0000, yuji2.ishikawa@toshiba.co.jp wrote: > Hi Greg > > Thank you for your comments. > > > -----Original Message----- > > From: Greg KH <gregkh@linuxfoundation.org> > > Sent: Monday, July 25, 2022 9:47 PM > > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > > <yuji2.ishikawa@toshiba.co.jp> > > Cc: Rob Herring <robh+dt@kernel.org>; Hans Verkuil <hverkuil@xs4all.nl>; > > iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Jonathan Corbet <corbet@lwn.net>; > > Sumit Semwal <sumit.semwal@linaro.org>; Christian König > > <christian.koenig@amd.com>; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > > Subject: Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing > > accelerator driver > > > > On Fri, Jul 22, 2022 at 05:28:53PM +0900, Yuji Ishikawa wrote: > > > This series is the DNN image processing accelerator driver for Toshiba's ARM > > SoC, Visconti[0]. > > > This provides DT binding documentation, device driver, MAINTAINER files > > and documents. > > > > > > Best regards, > > > Yuji > > > > > > [0]: > > > > > https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image- > > > recognition-processors-visconti.html > > > > > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > > accelerator bindings > > > v1 -> v2: > > > - No update > > > > > > soc: visconti: Add Toshiba Visconti image processing accelerator common > > source > > > v1 -> v2: > > > - checked with checkpatch.pl --strict > > > > > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > > > v1 -> v2: > > > - checked with checkpatch.pl --strict > > > - removed unused code > > > > > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > > > v1 -> v2: > > > - No update > > > > > > Documentation: driver-api: visconti: add a description of DNN driver. > > > v1 -> v2: > > > - newly added documents > > > > > > Yuji Ishikawa (5): > > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > > > accelerator bindings > > > soc: visconti: Add Toshiba Visconti image processing accelerator > > > common source > > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > > > accelerator > > > Documentation: driver-api: visconti: add a description of DNN driver. > > > > > > .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++ > > > Documentation/driver-api/visconti/common.rst | 115 ++++ > > > Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++ > > > MAINTAINERS | 2 + > > > drivers/soc/Kconfig | 1 + > > > drivers/soc/Makefile | 1 + > > > drivers/soc/visconti/Kconfig | 7 + > > > drivers/soc/visconti/Makefile | 8 + > > > drivers/soc/visconti/dnn/Makefile | 6 + > > > drivers/soc/visconti/dnn/dnn.c | 523 > > ++++++++++++++++++ > > > drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++ > > > drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++ > > > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++ > > > drivers/soc/visconti/ipa_common.c | 55 ++ > > > drivers/soc/visconti/ipa_common.h | 18 + > > > drivers/soc/visconti/uapi/dnn.h | 77 +++ > > > drivers/soc/visconti/uapi/ipa.h | 90 +++ > > > > Why is this in drivers/soc/? > > Actually, I'm not sure where his module should live in. > The directory drivers/soc were chosen just because the driver is specific to Visconti SoC. > Is it better to move the driver to another directory such as drivers/misc ? Yes please start out in drivers/misc/ unless we find a better place for it. thanks, greg k-h