usb: gadget: Fix unsigned comparison with less than zero
Commit Message
This was found by coccicheck:
./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0.
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/usb/gadget/udc/aspeed_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote:
> This was found by coccicheck:
>
> ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0.
What does this mean? Where is the error?
Please explain the reason for changes, not just the output of a random
tool that you ran on the code.
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
What commit does this fix?
thanks,
greg k-h
On Wed, Jun 29, 2022 at 01:51:01PM +0800, Jiapeng.Chong wrote:
> Sorry, we didn't see this patch.
> commit c09b1f372e746aeeb61ef8ffe0fea3970fd9273e
I am sorry, I do not understand what you mean here at all.
confused,
greg k-h
@@ -476,8 +476,8 @@ static int ast_dma_descriptor_setup(struct ast_udc_ep *ep, u32 dma_buf,
{
struct ast_udc_dev *udc = ep->udc;
struct device *dev = &udc->pdev->dev;
- u32 offset, chunk;
- int count, last;
+ u32 offset;
+ int count, last, chunk;
if (!ep->descs) {
dev_warn(dev, "%s: Empty DMA descs list failure\n",