[v1,2/2,RESEND] media: vimc: documentation for lens
Commit Message
Signed-off-by: Yunke Cao <yunkec@google.com>
---
Documentation/admin-guide/media/vimc.dot | 4 ++++
Documentation/admin-guide/media/vimc.rst | 3 +++
2 files changed, 7 insertions(+)
Comments
On 6/9/22 7:01 PM, Yunke Cao wrote:
> Signed-off-by: Yunke Cao <yunkec@google.com>
> ---
Please add commit log - describe what this feature adds in a couple
of sentences. It would be helpful to see how this can be invoked or
used.
> Documentation/admin-guide/media/vimc.dot | 4 ++++
> Documentation/admin-guide/media/vimc.rst | 3 +++
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/admin-guide/media/vimc.dot b/Documentation/admin-guide/media/vimc.dot
> index 8e829c164626..92a5bb631235 100644
> --- a/Documentation/admin-guide/media/vimc.dot
> +++ b/Documentation/admin-guide/media/vimc.dot
> @@ -5,9 +5,13 @@ digraph board {
> n00000001 [label="{{} | Sensor A\n/dev/v4l-subdev0 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green]
> n00000001:port0 -> n00000005:port0 [style=bold]
> n00000001:port0 -> n0000000b [style=bold]
> + n00000001 -> n00000002
> + n00000002 [label="{{} | Lens A\n/dev/v4l-subdev5 | {<port0>}}", shape=Mrecord, style=filled, fillcolor=green]
> n00000003 [label="{{} | Sensor B\n/dev/v4l-subdev1 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green]
> n00000003:port0 -> n00000008:port0 [style=bold]
> n00000003:port0 -> n0000000f [style=bold]
> + n00000003 -> n00000004
> + n00000004 [label="{{} | Lens B\n/dev/v4l-subdev6 | {<port0>}}", shape=Mrecord, style=filled, fillcolor=green]
> n00000005 [label="{{<port0> 0} | Debayer A\n/dev/v4l-subdev2 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
> n00000005:port1 -> n00000015:port0
> n00000008 [label="{{<port0> 0} | Debayer B\n/dev/v4l-subdev3 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
> diff --git a/Documentation/admin-guide/media/vimc.rst b/Documentation/admin-guide/media/vimc.rst
> index 0b07f05dde25..1723eb5ec56a 100644
> --- a/Documentation/admin-guide/media/vimc.rst
> +++ b/Documentation/admin-guide/media/vimc.rst
> @@ -53,6 +53,9 @@ vimc-sensor:
>
> * 1 Pad source
>
> +vimc-lens:
> + Ancillary lens for a sensor.
> +
Please add some description on what this does.
> vimc-debayer:
> Transforms images in bayer format into a non-bayer format.
> Exposes:
>
With these fixed
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
@@ -5,9 +5,13 @@ digraph board {
n00000001 [label="{{} | Sensor A\n/dev/v4l-subdev0 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green]
n00000001:port0 -> n00000005:port0 [style=bold]
n00000001:port0 -> n0000000b [style=bold]
+ n00000001 -> n00000002
+ n00000002 [label="{{} | Lens A\n/dev/v4l-subdev5 | {<port0>}}", shape=Mrecord, style=filled, fillcolor=green]
n00000003 [label="{{} | Sensor B\n/dev/v4l-subdev1 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green]
n00000003:port0 -> n00000008:port0 [style=bold]
n00000003:port0 -> n0000000f [style=bold]
+ n00000003 -> n00000004
+ n00000004 [label="{{} | Lens B\n/dev/v4l-subdev6 | {<port0>}}", shape=Mrecord, style=filled, fillcolor=green]
n00000005 [label="{{<port0> 0} | Debayer A\n/dev/v4l-subdev2 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
n00000005:port1 -> n00000015:port0
n00000008 [label="{{<port0> 0} | Debayer B\n/dev/v4l-subdev3 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
@@ -53,6 +53,9 @@ vimc-sensor:
* 1 Pad source
+vimc-lens:
+ Ancillary lens for a sensor.
+
vimc-debayer:
Transforms images in bayer format into a non-bayer format.
Exposes: