Message ID | 20220517082558.3534161-3-neal_liu@aspeedtech.com (mailing list archive) |
---|---|
State | Not Applicable |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1nqsYr-00FNYV-EO; Tue, 17 May 2022 08:28:13 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243255AbiEQI2G (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 17 May 2022 04:28:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243223AbiEQI1r (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 17 May 2022 04:27:47 -0400 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2CD445535; Tue, 17 May 2022 01:27:24 -0700 (PDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 24H8CR7V039693; Tue, 17 May 2022 16:12:27 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 May 2022 16:26:04 +0800 From: Neal Liu <neal_liu@aspeedtech.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Joel Stanley <joel@jms.id.au>, "Andrew Jeffery" <andrew@aj.id.au>, Felipe Balbi <balbi@kernel.org>, Sumit Semwal <sumit.semwal@linaro.org>, =?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, Geert Uytterhoeven <geert@linux-m68k.org>, "Li Yang" <leoyang.li@nxp.com> CC: Neal Liu <neal_liu@aspeedtech.com>, <linux-aspeed@lists.ozlabs.org>, <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, <linaro-mm-sig@lists.linaro.org> Subject: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node Date: Tue, 17 May 2022 16:25:57 +0800 Message-ID: <20220517082558.3534161-3-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517082558.3534161-1-neal_liu@aspeedtech.com> References: <20220517082558.3534161-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 24H8CR7V039693 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
add Aspeed udc driver for ast2600
|
|
Commit Message
Neal Liu
May 17, 2022, 8:25 a.m. UTC
Add USB2.0 device controller(udc) node to device tree
for AST2600.
Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
---
arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
Comments
On 17/05/2022 10:25, Neal Liu wrote: > Add USB2.0 device controller(udc) node to device tree > for AST2600. > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index 3d5ce9da42c3..5517313eb2b5 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -298,6 +298,16 @@ vhub: usb-vhub@1e6a0000 { > status = "disabled"; > }; > > + udc: udc@1e6a2000 { The same as DTS in bindings - generic node name, please. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, May 17, 2022 8:00 PM > To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi <balbi@kernel.org>; Sumit > Semwal <sumit.semwal@linaro.org>; Christian König > <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux-m68k.org>; > Li Yang <leoyang.li@nxp.com> > Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller > node > > On 17/05/2022 10:25, Neal Liu wrote: > > Add USB2.0 device controller(udc) node to device tree for AST2600. > > > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > > --- > > arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi > > b/arch/arm/boot/dts/aspeed-g6.dtsi > > index 3d5ce9da42c3..5517313eb2b5 100644 > > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > > @@ -298,6 +298,16 @@ vhub: usb-vhub@1e6a0000 { > > status = "disabled"; > > }; > > > > + udc: udc@1e6a2000 { > > The same as DTS in bindings - generic node name, please. > Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: usb-vhub@1e6a0000"? > > Best regards, > Krzysztof
On 17/05/2022 16:50, Neal Liu wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Tuesday, May 17, 2022 8:00 PM >> To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman >> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof >> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; >> Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi <balbi@kernel.org>; Sumit >> Semwal <sumit.semwal@linaro.org>; Christian König >> <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux-m68k.org>; >> Li Yang <leoyang.li@nxp.com> >> Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; >> dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org >> Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller >> node >> >> On 17/05/2022 10:25, Neal Liu wrote: >>> Add USB2.0 device controller(udc) node to device tree for AST2600. >>> >>> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> >>> --- >>> arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi >>> b/arch/arm/boot/dts/aspeed-g6.dtsi >>> index 3d5ce9da42c3..5517313eb2b5 100644 >>> --- a/arch/arm/boot/dts/aspeed-g6.dtsi >>> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi >>> @@ -298,6 +298,16 @@ vhub: usb-vhub@1e6a0000 { >>> status = "disabled"; >>> }; >>> >>> + udc: udc@1e6a2000 { >> >> The same as DTS in bindings - generic node name, please. >> > > Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: usb-vhub@1e6a0000"? Possible yes :), but not recommended and not wanted. Nodes should be generic and prefixes are added only if there is no unit address. You can though use some more descriptive label. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, May 17, 2022 10:54 PM > To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi <balbi@kernel.org>; Sumit > Semwal <sumit.semwal@linaro.org>; Christian König > <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux-m68k.org>; > Li Yang <leoyang.li@nxp.com> > Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller > node > > On 17/05/2022 16:50, Neal Liu wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Tuesday, May 17, 2022 8:00 PM > >> To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > >> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; > >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley > >> <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi > >> <balbi@kernel.org>; Sumit Semwal <sumit.semwal@linaro.org>; Christian > >> König <christian.koenig@amd.com>; Geert Uytterhoeven > >> <geert@linux-m68k.org>; Li Yang <leoyang.li@nxp.com> > >> Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > >> dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > >> Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device > >> controller node > >> > >> On 17/05/2022 10:25, Neal Liu wrote: > >>> Add USB2.0 device controller(udc) node to device tree for AST2600. > >>> > >>> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > >>> --- > >>> arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ > >>> 1 file changed, 10 insertions(+) > >>> > >>> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi > >>> b/arch/arm/boot/dts/aspeed-g6.dtsi > >>> index 3d5ce9da42c3..5517313eb2b5 100644 > >>> --- a/arch/arm/boot/dts/aspeed-g6.dtsi > >>> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > >>> @@ -298,6 +298,16 @@ vhub: usb-vhub@1e6a0000 { > >>> status = "disabled"; > >>> }; > >>> > >>> + udc: udc@1e6a2000 { > >> > >> The same as DTS in bindings - generic node name, please. > >> > > > > Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: > usb-vhub@1e6a0000"? > > Possible yes :), but not recommended and not wanted. Nodes should be generic > and prefixes are added only if there is no unit address. You can though use > some more descriptive label. > "udc: usb@1e6a2000" is okay for you? > > Best regards, > Krzysztof
On 17/05/2022 17:21, Neal Liu wrote: >>>>> >>>>> + udc: udc@1e6a2000 { >>>> >>>> The same as DTS in bindings - generic node name, please. >>>> >>> >>> Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: >> usb-vhub@1e6a0000"? >> >> Possible yes :), but not recommended and not wanted. Nodes should be generic >> and prefixes are added only if there is no unit address. You can though use >> some more descriptive label. >> > "udc: usb@1e6a2000" is okay for you? Yes, it's perfect. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, May 17, 2022 11:26 PM > To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi <balbi@kernel.org>; Sumit > Semwal <sumit.semwal@linaro.org>; Christian König > <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux-m68k.org>; > Li Yang <leoyang.li@nxp.com> > Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller > node > > On 17/05/2022 17:21, Neal Liu wrote: > >>>>> > >>>>> + udc: udc@1e6a2000 { > >>>> > >>>> The same as DTS in bindings - generic node name, please. > >>>> > >>> > >>> Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between > "vhub: > >> usb-vhub@1e6a0000"? > >> > >> Possible yes :), but not recommended and not wanted. Nodes should be > >> generic and prefixes are added only if there is no unit address. You > >> can though use some more descriptive label. > >> > > "udc: usb@1e6a2000" is okay for you? > > Yes, it's perfect. Great ! I'll update it for next patch. Thanks for your suggestion. > > > Best regards, > Krzysztof
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi index 3d5ce9da42c3..5517313eb2b5 100644 --- a/arch/arm/boot/dts/aspeed-g6.dtsi +++ b/arch/arm/boot/dts/aspeed-g6.dtsi @@ -298,6 +298,16 @@ vhub: usb-vhub@1e6a0000 { status = "disabled"; }; + udc: udc@1e6a2000 { + compatible = "aspeed,ast2600-udc"; + reg = <0x1e6a2000 0x300>; + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb2bd_default>; + status = "disabled"; + }; + apb { compatible = "simple-bus"; #address-cells = <1>;