Message ID | 20220513065728.857722-4-neal_liu@aspeedtech.com (mailing list archive) |
---|---|
State | Not Applicable |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1npPGL-009SIP-BL; Fri, 13 May 2022 06:59:02 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377601AbiEMG6v (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 13 May 2022 02:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377607AbiEMG6n (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 13 May 2022 02:58:43 -0400 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF494606CC; Thu, 12 May 2022 23:58:40 -0700 (PDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 24D6iAZK026760; Fri, 13 May 2022 14:44:12 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 13 May 2022 14:57:33 +0800 From: Neal Liu <neal_liu@aspeedtech.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Joel Stanley <joel@jms.id.au>, "Andrew Jeffery" <andrew@aj.id.au>, Felipe Balbi <balbi@kernel.org>, Sumit Semwal <sumit.semwal@linaro.org>, =?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, Geert Uytterhoeven <geert@linux-m68k.org>, "Li Yang" <leoyang.li@nxp.com> CC: Neal Liu <neal_liu@aspeedtech.com>, <linux-aspeed@lists.ozlabs.org>, <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, <linaro-mm-sig@lists.linaro.org>, <BMC-SW@aspeedtech.com> Subject: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc Date: Fri, 13 May 2022 14:57:28 +0800 Message-ID: <20220513065728.857722-4-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220513065728.857722-1-neal_liu@aspeedtech.com> References: <20220513065728.857722-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 24D6iAZK026760 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
add Aspeed udc driver for ast2600
|
|
Commit Message
Neal Liu
May 13, 2022, 6:57 a.m. UTC
Add device tree binding documentation for the Aspeed USB2.0 Device
Controller.
Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
---
.../devicetree/bindings/usb/aspeed,udc.yaml | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/aspeed,udc.yaml
Comments
On 13/05/2022 08:57, Neal Liu wrote: > Add device tree binding documentation for the Aspeed USB2.0 Device > Controller. > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > --- > .../devicetree/bindings/usb/aspeed,udc.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/aspeed,udc.yaml Please name the file as first compatible, so "aspeed,ast2600-udc.yaml" > > diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > new file mode 100644 > index 000000000000..d1d2f77d1c54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 Facebook Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED USB 2.0 Device Controller > + > +maintainers: > + - Neal Liu <neal_liu@aspeedtech.com> > + > +description: |+ > + The ASPEED USB 2.0 Device Controller implements 1 control endpoint and > + 4 generic endpoints for AST260x. > + > + Supports independent DMA channel for each generic endpoint. > + Supports 32/256 stages descriptor mode for all generic endpoints. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-udc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 No child properties? No ports or any other devices? No usb-hcd.yaml? > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/aspeed-clock.h> > + udc: udc@1e6a2000 { Node name: usb > + compatible = "aspeed,ast2600-udc"; > + reg = <0x1e6a2000 0x300>; > + interrupts = <9>; > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb2bd_default>; > + }; Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Friday, May 13, 2022 5:07 PM > To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley > <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi > <balbi@kernel.org>; Sumit Semwal <sumit.semwal@linaro.org>; Christian > König <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux- > m68k.org>; Li Yang <leoyang.li@nxp.com> > Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-media@vger.kernel.org; dri- > devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org; BMC-SW <BMC- > SW@aspeedtech.com> > Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed > udc > > On 13/05/2022 08:57, Neal Liu wrote: > > Add device tree binding documentation for the Aspeed USB2.0 Device > > Controller. > > > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > > --- > > .../devicetree/bindings/usb/aspeed,udc.yaml | 52 > +++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/usb/aspeed,udc.yaml > > Please name the file as first compatible, so "aspeed,ast2600-udc.yaml" Okay, I could rename it for next patch if you preferred. But there are lots of yaml files which are not named as first compatible. > > > > > diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > > b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > > new file mode 100644 > > index 000000000000..d1d2f77d1c54 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright > > +(c) 2020 Facebook Inc. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED USB 2.0 Device Controller > > + > > +maintainers: > > + - Neal Liu <neal_liu@aspeedtech.com> > > + > > +description: |+ > > + The ASPEED USB 2.0 Device Controller implements 1 control endpoint > > +and > > + 4 generic endpoints for AST260x. > > + > > + Supports independent DMA channel for each generic endpoint. > > + Supports 32/256 stages descriptor mode for all generic endpoints. > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2600-udc > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > No child properties? No ports or any other devices? No usb-hcd.yaml? Aspeed udc only has 1 port, no need extra properties for now. > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/aspeed-clock.h> > > + udc: udc@1e6a2000 { > > Node name: usb "udc" is more recognizable than "usb" I think. "usb" is too general, can be various like host or device. > > > + compatible = "aspeed,ast2600-udc"; > > + reg = <0x1e6a2000 0x300>; > > + interrupts = <9>; > > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usb2bd_default>; > > + }; > > > Best regards, > Krzysztof
On 13/05/2022 17:39, Neal Liu wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Friday, May 13, 2022 5:07 PM >> To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman >> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley >> <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi >> <balbi@kernel.org>; Sumit Semwal <sumit.semwal@linaro.org>; Christian >> König <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux- >> m68k.org>; Li Yang <leoyang.li@nxp.com> >> Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >> kernel@vger.kernel.org; linux-media@vger.kernel.org; dri- >> devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org; BMC-SW <BMC- >> SW@aspeedtech.com> >> Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed >> udc >> >> On 13/05/2022 08:57, Neal Liu wrote: >>> Add device tree binding documentation for the Aspeed USB2.0 Device >>> Controller. >>> >>> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> >>> --- >>> .../devicetree/bindings/usb/aspeed,udc.yaml | 52 >> +++++++++++++++++++ >>> 1 file changed, 52 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/usb/aspeed,udc.yaml >> >> Please name the file as first compatible, so "aspeed,ast2600-udc.yaml" > > Okay, I could rename it for next patch if you preferred. > But there are lots of yaml files which are not named as first compatible. Yes, I know, I quite likely I also produced such bindings, but a specific name is rather preferred. Otherwise you will have a difficult naming choice when your next Aspeed UDC requires new bindings file because of some differences (not yet known now). > >> >>> >>> diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml >>> b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml >>> new file mode 100644 >>> index 000000000000..d1d2f77d1c54 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml >>> @@ -0,0 +1,52 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright >>> +(c) 2020 Facebook Inc. >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: ASPEED USB 2.0 Device Controller >>> + >>> +maintainers: >>> + - Neal Liu <neal_liu@aspeedtech.com> >>> + >>> +description: |+ >>> + The ASPEED USB 2.0 Device Controller implements 1 control endpoint >>> +and >>> + 4 generic endpoints for AST260x. >>> + >>> + Supports independent DMA channel for each generic endpoint. >>> + Supports 32/256 stages descriptor mode for all generic endpoints. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - aspeed,ast2600-udc >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >> >> No child properties? No ports or any other devices? No usb-hcd.yaml? > > Aspeed udc only has 1 port, no need extra properties for now. OK > >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - clocks >>> + - interrupts >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/clock/aspeed-clock.h> >>> + udc: udc@1e6a2000 { >> >> Node name: usb > > "udc" is more recognizable than "usb" I think. "usb" is too general, can be various like host or device. It's still required by schema for most of USB host controllers. Existing USB device controllers use usb as well (except Atmel mentioning gadget) Generic name is also expected by Devicetree spec and "udc" is not on a list of examples of generic names (usb is). Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Sunday, May 15, 2022 4:22 AM > To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi <balbi@kernel.org>; Sumit > Semwal <sumit.semwal@linaro.org>; Christian König > <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux-m68k.org>; > Li Yang <leoyang.li@nxp.com> > Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org; BMC-SW > <BMC-SW@aspeedtech.com> > Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc > > On 13/05/2022 17:39, Neal Liu wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Friday, May 13, 2022 5:07 PM > >> To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > >> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; > >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley > >> <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi > >> <balbi@kernel.org>; Sumit Semwal <sumit.semwal@linaro.org>; Christian > >> König <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux- > >> m68k.org>; Li Yang <leoyang.li@nxp.com> > >> Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux- kernel@vger.kernel.org; linux-media@vger.kernel.org; dri- > >> devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org; BMC-SW > >> <BMC- SW@aspeedtech.com> > >> Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for > >> aspeed udc > >> > >> On 13/05/2022 08:57, Neal Liu wrote: > >>> Add device tree binding documentation for the Aspeed USB2.0 Device > >>> Controller. > >>> > >>> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > >>> --- > >>> .../devicetree/bindings/usb/aspeed,udc.yaml | 52 > >> +++++++++++++++++++ > >>> 1 file changed, 52 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/usb/aspeed,udc.yaml > >> > >> Please name the file as first compatible, so "aspeed,ast2600-udc.yaml" > > > > Okay, I could rename it for next patch if you preferred. > > But there are lots of yaml files which are not named as first compatible. > > Yes, I know, I quite likely I also produced such bindings, but a specific name is > rather preferred. Otherwise you will have a difficult naming choice when your > next Aspeed UDC requires new bindings file because of some differences (not > yet known now). > We can rename the bindings if next Aspeed UDC needs, don't you think? Currently, Aspeed has no requirement. > > > >> > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > >>> b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > >>> new file mode 100644 > >>> index 000000000000..d1d2f77d1c54 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > >>> @@ -0,0 +1,52 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # > >>> +Copyright > >>> +(c) 2020 Facebook Inc. > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: ASPEED USB 2.0 Device Controller > >>> + > >>> +maintainers: > >>> + - Neal Liu <neal_liu@aspeedtech.com> > >>> + > >>> +description: |+ > >>> + The ASPEED USB 2.0 Device Controller implements 1 control > >>> +endpoint and > >>> + 4 generic endpoints for AST260x. > >>> + > >>> + Supports independent DMA channel for each generic endpoint. > >>> + Supports 32/256 stages descriptor mode for all generic endpoints. > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - aspeed,ast2600-udc > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + clocks: > >>> + maxItems: 1 > >>> + > >>> + interrupts: > >>> + maxItems: 1 > >> > >> No child properties? No ports or any other devices? No usb-hcd.yaml? > > > > Aspeed udc only has 1 port, no need extra properties for now. > > OK > > > > >>> + > >>> +required: > >>> + - compatible > >>> + - reg > >>> + - clocks > >>> + - interrupts > >>> + > >>> +additionalProperties: false > >>> + > >>> +examples: > >>> + - | > >>> + #include <dt-bindings/clock/aspeed-clock.h> > >>> + udc: udc@1e6a2000 { > >> > >> Node name: usb > > > > "udc" is more recognizable than "usb" I think. "usb" is too general, can be > various like host or device. > > It's still required by schema for most of USB host controllers. Existing USB > device controllers use usb as well (except Atmel mentioning gadget) Generic > name is also expected by Devicetree spec and "udc" is not on a list of > examples of generic names (usb is). Okay, I'll revise it for next patch. Thanks > > > Best regards, > Krzysztof
On 16/05/2022 03:59, Neal Liu wrote: >>> Okay, I could rename it for next patch if you preferred. >>> But there are lots of yaml files which are not named as first compatible. >> >> Yes, I know, I quite likely I also produced such bindings, but a specific name is >> rather preferred. Otherwise you will have a difficult naming choice when your >> next Aspeed UDC requires new bindings file because of some differences (not >> yet known now). >> > We can rename the bindings if next Aspeed UDC needs, don't you think? > Currently, Aspeed has no requirement. So just use proper name from the beginning.... Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Monday, May 16, 2022 1:54 PM > To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi <balbi@kernel.org>; Sumit > Semwal <sumit.semwal@linaro.org>; Christian König > <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux-m68k.org>; > Li Yang <leoyang.li@nxp.com> > Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc > > On 16/05/2022 03:59, Neal Liu wrote: > >>> Okay, I could rename it for next patch if you preferred. > >>> But there are lots of yaml files which are not named as first compatible. > >> > >> Yes, I know, I quite likely I also produced such bindings, but a > >> specific name is rather preferred. Otherwise you will have a > >> difficult naming choice when your next Aspeed UDC requires new > >> bindings file because of some differences (not yet known now). > >> > > We can rename the bindings if next Aspeed UDC needs, don't you think? > > Currently, Aspeed has no requirement. > > So just use proper name from the beginning.... > Okay, I'll rename it for next patch. Thanks for the review. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml new file mode 100644 index 000000000000..d1d2f77d1c54 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2020 Facebook Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ASPEED USB 2.0 Device Controller + +maintainers: + - Neal Liu <neal_liu@aspeedtech.com> + +description: |+ + The ASPEED USB 2.0 Device Controller implements 1 control endpoint and + 4 generic endpoints for AST260x. + + Supports independent DMA channel for each generic endpoint. + Supports 32/256 stages descriptor mode for all generic endpoints. + +properties: + compatible: + enum: + - aspeed,ast2600-udc + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/aspeed-clock.h> + udc: udc@1e6a2000 { + compatible = "aspeed,ast2600-udc"; + reg = <0x1e6a2000 0x300>; + interrupts = <9>; + clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb2bd_default>; + };