| Message ID | 1293750484-1161-2-git-send-email-justinmattock@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <mchehab@gaivota> Envelope-to: mchehab@gaivota Delivery-date: Thu, 30 Dec 2010 22:11:32 -0200 Received: from mchehab by gaivota with local (Exim 4.72) (envelope-from <mchehab@gaivota>) id 1PYSai-0000S4-CX for mchehab@gaivota; Thu, 30 Dec 2010 22:11:32 -0200 Received: from casper.infradead.org [85.118.1.10] by gaivota with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Thu, 30 Dec 2010 22:11:32 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PYRgg-00044N-Qv; Thu, 30 Dec 2010 23:13:39 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397Ab0L3XIN (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Thu, 30 Dec 2010 18:08:13 -0500 Received: from mail-gx0-f174.google.com ([209.85.161.174]:59254 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967Ab0L3XIJ (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 30 Dec 2010 18:08:09 -0500 Received: by gxk9 with SMTP id 9so1899519gxk.19 for <multiple recipients>; Thu, 30 Dec 2010 15:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=YJVB93dRFNWU3AyZz4jzqIh7ldhpXjMcGZc4tJbaTsM=; b=gimdBxP1EfwQm6A7RKgKjrn697KR4rBbp1l43CU3DHmipfMRYFI6jDZ3jdo/T+lRk7 Nk+HCgZt9LQ6NSLnBQnKgTrLr1vTkt16Txug5kAwXrKHLgrad6UY0YJaqP8KDg9lmpNZ Z0O7+QcSYMFE/2BqZY8XyR10N285TpS1+mU5Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=ZfLKtM2+CiteZK4V1gQ4WesVsSCveFKR9VoB5fsYU3rYn/gu4QVlGshwUUD97zz3mX xRp+WJSyMVX6rFYwsDlo9jEQpGC16X3q0U+qw8v77edat1Ejl1WeOg71BS8UTiJQmAuv Cm+yUqiygnEdp2nAj2WSRRgyPSeti0ip8R6PQ= Received: by 10.90.87.17 with SMTP id k17mr3887537agb.80.1293750488141; Thu, 30 Dec 2010 15:08:08 -0800 (PST) Received: from localhost.localdomain ([76.91.45.220]) by mx.google.com with ESMTPS id z23sm5611318yhc.24.2010.12.30.15.08.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 30 Dec 2010 15:08:06 -0800 (PST) From: "Justin P. Mattock" <justinmattock@gmail.com> To: trivial@kernel.org Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, spi-devel-general@lists.sourceforge.net, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, "Justin P. Mattock" <justinmattock@gmail.com> Subject: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Date: Thu, 30 Dec 2010 15:07:51 -0800 Message-Id: <1293750484-1161-2-git-send-email-justinmattock@gmail.com> X-Mailer: git-send-email 1.6.5.2.180.gc5b3e In-Reply-To: <1293750484-1161-1-git-send-email-justinmattock@gmail.com> References: <1293750484-1161-1-git-send-email-justinmattock@gmail.com> Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab <mchehab@gaivota> |
Commit Message
Justin P. Mattock
Dec. 30, 2010, 11:07 p.m. UTC
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/spi/dw_spi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if this > is correct or not. > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> applied, thanks. g. > > --- > drivers/spi/dw_spi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c > index 0838c79..7c3cf21 100644 > --- a/drivers/spi/dw_spi.c > +++ b/drivers/spi/dw_spi.c > @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data) > spi_set_clk(dws, clk_div ? clk_div : chip->clk_div); > spi_chip_sel(dws, spi->chip_select); > > - /* Set the interrupt mask, for poll mode just diable all int */ > + /* Set the interrupt mask, for poll mode just disable all int */ > spi_mask_intr(dws, 0xff); > if (imask) > spi_umask_intr(dws, imask); > -- > 1.6.5.2.180.gc5b3e > > > ------------------------------------------------------------------------------ > Learn how Oracle Real Application Clusters (RAC) One Node allows customers > to consolidate database storage, standardize their database environment, and, > should the need arise, upgrade to a full multi-node Oracle RAC database > without downtime or disruption > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > spi-devel-general mailing list > spi-devel-general@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/spi-devel-general -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/30/2010 10:45 PM, Grant Likely wrote: > On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: >> The below patch fixes a typo "diable" to "disable". Please let me know if this >> is correct or not. >> >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> > > applied, thanks. > > g. ahh.. thanks.. just cleared up the left out diabled that I had thought I forgotten(ended up separating comments and code and forgot) > >> >> --- >> drivers/spi/dw_spi.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c >> index 0838c79..7c3cf21 100644 >> --- a/drivers/spi/dw_spi.c >> +++ b/drivers/spi/dw_spi.c >> @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data) >> spi_set_clk(dws, clk_div ? clk_div : chip->clk_div); >> spi_chip_sel(dws, spi->chip_select); >> >> - /* Set the interrupt mask, for poll mode just diable all int */ >> + /* Set the interrupt mask, for poll mode just disable all int */ >> spi_mask_intr(dws, 0xff); >> if (imask) >> spi_umask_intr(dws, imask); >> -- >> 1.6.5.2.180.gc5b3e >> >> >> ------------------------------------------------------------------------------ >> Learn how Oracle Real Application Clusters (RAC) One Node allows customers >> to consolidate database storage, standardize their database environment, and, >> should the need arise, upgrade to a full multi-node Oracle RAC database >> without downtime or disruption >> http://p.sf.net/sfu/oracle-sfdevnl >> _______________________________________________ >> spi-devel-general mailing list >> spi-devel-general@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/spi-devel-general > Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: > On 12/30/2010 10:45 PM, Grant Likely wrote: > >On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: > >>The below patch fixes a typo "diable" to "disable". Please let me know if this > >>is correct or not. > >> > >>Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> > > > >applied, thanks. > > > >g. > > ahh.. thanks.. just cleared up the left out diabled that I had > thought I forgotten(ended up separating comments and code and > forgot) This is really just defensiveness and random grumbling and grumpiness on my part, but one reason I may have missed the first patch is because your subject lines are crap. Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/31/2010 01:11 AM, Dan Carpenter wrote: > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: >> On 12/30/2010 10:45 PM, Grant Likely wrote: >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: >>>> The below patch fixes a typo "diable" to "disable". Please let me know if this >>>> is correct or not. >>>> >>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> >>> >>> applied, thanks. >>> >>> g. >> >> ahh.. thanks.. just cleared up the left out diabled that I had >> thought I forgotten(ended up separating comments and code and >> forgot) > > This is really just defensiveness and random grumbling and grumpiness on > my part, but one reason I may have missed the first patch is because > your subject lines are crap. > > Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. > > Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable > > regards, > dan carpenter > alright.. so having the backlash is alright for the subject Thanks for the pointer on this.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote: > On 12/31/2010 01:11 AM, Dan Carpenter wrote: > > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote: > >> On 12/30/2010 10:45 PM, Grant Likely wrote: > >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: > >>>> The below patch fixes a typo "diable" to "disable". Please let me know if this > >>>> is correct or not. > >>>> > >>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> > >>> > >>> applied, thanks. > >>> > >>> g. > >> > >> ahh.. thanks.. just cleared up the left out diabled that I had > >> thought I forgotten(ended up separating comments and code and > >> forgot) > > > > This is really just defensiveness and random grumbling and grumpiness on > > my part, but one reason I may have missed the first patch is because > > your subject lines are crap. > > > > Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. > > > > Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable > > > > regards, > > dan carpenter > > > > alright.. so having the backlash is alright for the subject > > Thanks for the pointer on this.. There is actually no specific form. Most of us edit this part of the subject line anyway to conform to whatever (nonuniform) conventions we use. I just use <component>: with no scsi or drivers prefix because the git tree is tagged [SCSI]; others are different. James -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote: > >Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. > > > >Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable > > > >regards, > >dan carpenter > > > > alright.. so having the backlash is alright for the subject Well really my point is not so much about backslashes vs colons, it's about getting the *one* correct prefix. This stuff is probably scriptable most of the time, but you may still be required to think a little on the corner cases. Here is a script to get you started. git log --format="%s" drivers/spi/dw_spi.c | \ head -n 20 | \ perl -ne 's/(.*):.*/$1/; print' | \ sort | uniq -c | sort -rn | \ perl -ne 's/^\W+\d+ //; print' | \ head -n 1 regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/31/2010 09:41 AM, Dan Carpenter wrote: > On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote: >>> Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable. >>> >>> Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable >>> >>> regards, >>> dan carpenter >>> >> >> alright.. so having the backlash is alright for the subject > > Well really my point is not so much about backslashes vs colons, it's > about getting the *one* correct prefix. This stuff is probably > scriptable most of the time, but you may still be required to think a > little on the corner cases. > > Here is a script to get you started. > > git log --format="%s" drivers/spi/dw_spi.c | \ > head -n 20 | \ > perl -ne 's/(.*):.*/$1/; print' | \ > sort | uniq -c | sort -rn | \ > perl -ne 's/^\W+\d+ //; print' | \ > head -n 1 > > regards, > dan carpenter > thats a nice little script there(just ran it) any way you want to add this into to getmaintainers.pl or something? (this way people get the maintainers address plus a subject line in the mix) Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c index 0838c79..7c3cf21 100644 --- a/drivers/spi/dw_spi.c +++ b/drivers/spi/dw_spi.c @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data) spi_set_clk(dws, clk_div ? clk_div : chip->clk_div); spi_chip_sel(dws, spi->chip_select); - /* Set the interrupt mask, for poll mode just diable all int */ + /* Set the interrupt mask, for poll mode just disable all int */ spi_mask_intr(dws, 0xff); if (imask) spi_umask_intr(dws, imask);