Message ID | 1647252574-30451-1-git-send-email-quic_dikshita@quicinc.com (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1nTheQ-007WaM-Dx; Mon, 14 Mar 2022 10:10:06 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238351AbiCNKLM (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 14 Mar 2022 06:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238345AbiCNKLK (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 14 Mar 2022 06:11:10 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8805A3BF9E; Mon, 14 Mar 2022 03:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1647252600; x=1678788600; h=from:to:cc:subject:date:message-id; bh=mZnqPU/2PQEr2zXqIDKl/5wq9nV1dt36kzj3okbgQ9w=; b=nyR/Ihj6lPhVvPIKwug5MVAeI0f7EUCpgre9Kz/X+C7QRXwp1UyaRJ8Y XOowHAQOWBaO+a3k3eIJAbQZ+JNlhb8Y8QEjmPwTeZ5kdmlCq6GBu1S3j VI74gEFGRbUulgDj2KVQB4ik+/jIx1qNPsbeqN53iNPuqJ0yWN5NRcbX7 c=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 14 Mar 2022 03:10:00 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 14 Mar 2022 03:09:59 -0700 X-QCInternal: smtphost Received: from hu-dikshita-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.110.13]) by ironmsg02-blr.qualcomm.com with ESMTP; 14 Mar 2022 15:39:42 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 347544) id 339314676; Mon, 14 Mar 2022 15:39:42 +0530 (+0530) From: quic_dikshita@quicinc.com To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hverkuil-cisco@xs4all.nl Cc: linux-arm-msm@vger.kernel.org, ezequiel@collabora.com, stanimir.varbanov@linaro.org, quic_vgarodia@quicinc.com, quic_majja@quicinc.com, quic_jdas@quicinc.com, Dikshita Agarwal <quic_dikshita@quicinc.com> Subject: [PATCH v4 0/2] Introduce Intra-refresh type control Date: Mon, 14 Mar 2022 15:39:32 +0530 Message-Id: <1647252574-30451-1-git-send-email-quic_dikshita@quicinc.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
Introduce Intra-refresh type control
|
|
Message
Dikshita Agarwal
March 14, 2022, 10:09 a.m. UTC
From: Dikshita Agarwal <quic_dikshita@quicinc.com>
Hi,
This series add a new intra-refresh type control for encoders.
this can be used to specify which intra refresh to be enabled, random, cyclic or none.
Change since v0:
Dropped INTRA_REFRESH_TYPE_NONE as it was not needed.
Intra refresh period value as zero will disable the intra refresh.
Change since v1:
Updated the control name for better undestanding.
Also updated the documentation accordingly.
Change since v2:
Updated the venus driver implementation as well to use the correct control name. Missed in v2.
Change since v3:
Addressed comments from Hans in v4l2 patch.
Enabled the support for cyclic intra refresh in venus driver.
Thanks,
Dikshita
Dikshita Agarwal (2):
media: v4l2-ctrls: Add intra-refresh type control
venus: venc: Add support for intra-refresh mode
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 22 ++++++++++++++++++++++
drivers/media/platform/qcom/venus/core.h | 1 +
drivers/media/platform/qcom/venus/venc.c | 6 +++++-
drivers/media/platform/qcom/venus/venc_ctrls.c | 10 ++++++++++
drivers/media/v4l2-core/v4l2-ctrls-defs.c | 9 +++++++++
include/uapi/linux/v4l2-controls.h | 5 +++++
6 files changed, 52 insertions(+), 1 deletion(-)
Comments
Dikshita, I cannot find new version of this patchset with Han's comments addressed? On 3/14/22 12:09, quic_dikshita@quicinc.com wrote: > From: Dikshita Agarwal <quic_dikshita@quicinc.com> > > Hi, > > This series add a new intra-refresh type control for encoders. > this can be used to specify which intra refresh to be enabled, random, cyclic or none. > > Change since v0: > Dropped INTRA_REFRESH_TYPE_NONE as it was not needed. > Intra refresh period value as zero will disable the intra refresh. > > Change since v1: > Updated the control name for better undestanding. > Also updated the documentation accordingly. > > Change since v2: > Updated the venus driver implementation as well to use the correct control name. Missed in v2. > > Change since v3: > Addressed comments from Hans in v4l2 patch. > Enabled the support for cyclic intra refresh in venus driver. > > Thanks, > Dikshita > > Dikshita Agarwal (2): > media: v4l2-ctrls: Add intra-refresh type control > venus: venc: Add support for intra-refresh mode > > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 22 ++++++++++++++++++++++ > drivers/media/platform/qcom/venus/core.h | 1 + > drivers/media/platform/qcom/venus/venc.c | 6 +++++- > drivers/media/platform/qcom/venus/venc_ctrls.c | 10 ++++++++++ > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 9 +++++++++ > include/uapi/linux/v4l2-controls.h | 5 +++++ > 6 files changed, 52 insertions(+), 1 deletion(-) >
Hi Stan, I was waiting for your comments on Venus changes if any, so that I can address all comments together in next patch. Posted a new patchset v5 now, pls review. Thanks, Dikshita Agarwal -----Original Message----- From: Stanimir Varbanov <stanimir.varbanov@linaro.org> Sent: Thursday, April 07, 2022 1:53 AM To: Dikshita Agarwal (QUIC) <quic_dikshita@quicinc.com>; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; hverkuil-cisco@xs4all.nl Cc: linux-arm-msm@vger.kernel.org; ezequiel@collabora.com; stanimir.varbanov@linaro.org; quic_vgarodia@quicinc.com; Maheshwar Ajja (QUIC) <quic_majja@quicinc.com>; quic_jdas <quic_jdas@quicinc.com> Subject: Re: [PATCH v4 0/2] Introduce Intra-refresh type control Dikshita, I cannot find new version of this patchset with Han's comments addressed? On 3/14/22 12:09, quic_dikshita@quicinc.com wrote: > From: Dikshita Agarwal <quic_dikshita@quicinc.com> > > Hi, > > This series add a new intra-refresh type control for encoders. > this can be used to specify which intra refresh to be enabled, random, cyclic or none. > > Change since v0: > Dropped INTRA_REFRESH_TYPE_NONE as it was not needed. > Intra refresh period value as zero will disable the intra refresh. > > Change since v1: > Updated the control name for better undestanding. > Also updated the documentation accordingly. > > Change since v2: > Updated the venus driver implementation as well to use the correct control name. Missed in v2. > > Change since v3: > Addressed comments from Hans in v4l2 patch. > Enabled the support for cyclic intra refresh in venus driver. > > Thanks, > Dikshita > > Dikshita Agarwal (2): > media: v4l2-ctrls: Add intra-refresh type control > venus: venc: Add support for intra-refresh mode > > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 22 ++++++++++++++++++++++ > drivers/media/platform/qcom/venus/core.h | 1 + > drivers/media/platform/qcom/venus/venc.c | 6 +++++- > drivers/media/platform/qcom/venus/venc_ctrls.c | 10 ++++++++++ > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 9 +++++++++ > include/uapi/linux/v4l2-controls.h | 5 +++++ > 6 files changed, 52 insertions(+), 1 deletion(-) >