Message ID | 20220118100729.7651-1-jammy_huang@aspeedtech.com (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1n9lPU-00Ec5s-FC; Tue, 18 Jan 2022 10:08:16 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236833AbiARKIF (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 18 Jan 2022 05:08:05 -0500 Received: from twspam01.aspeedtech.com ([211.20.114.71]:10665 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236740AbiARKID (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 18 Jan 2022 05:08:03 -0500 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 20IA0RJ0021056; Tue, 18 Jan 2022 18:00:27 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from JammyHuang-PC.aspeed.com (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 Jan 2022 18:07:24 +0800 From: Jammy Huang <jammy_huang@aspeedtech.com> To: <eajames@linux.ibm.com>, <mchehab@kernel.org>, <joel@jms.id.au>, <andrew@aj.id.au>, <linux-media@vger.kernel.org>, <openbmc@lists.ozlabs.org>, <linux-arm-kernel@lists.infradead.org>, <linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v4 0/2] Fix incorrect resolution detected Date: Tue, 18 Jan 2022 18:07:27 +0800 Message-ID: <20220118100729.7651-1-jammy_huang@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 20IA0RJ0021056 Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -7.4 (-------) X-LSpam-Report: No, score=-7.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_HI=-5 autolearn=ham autolearn_force=no |
Series |
Fix incorrect resolution detected
|
|
Message
Jammy Huang
Jan. 18, 2022, 10:07 a.m. UTC
This series fixes incorrect resolution detected. We found this problem happened occasionally in the switch between bios and bootloader. Changes in v4: - Correct the subject of patch Changes in v3: - In v2, we tried to increase the min-required-count of stable signal to avoid incorrect transient state in timing detection. But it is not working for all conditions. Thus, we go another way in v3. Use regs, which can represent the signal status, to decide if we needs to do detection again. Changes in v2: - Separate the patch into two patches Jammy Huang (2): media: aspeed: Add macro for the fields of the mode-detect registers media: aspeed: Fix unstable timing detection drivers/media/platform/aspeed-video.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-)
Comments
Hi Jammy, On 18/01/2022 11:07, Jammy Huang wrote: > This series fixes incorrect resolution detected. > We found this problem happened occasionally in the switch between bios > and bootloader. Can you rebase this on top of: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v5.18f This series doesn't apply cleanly. Regards, Hans > > Changes in v4: > - Correct the subject of patch > > Changes in v3: > - In v2, we tried to increase the min-required-count of stable signal > to avoid incorrect transient state in timing detection. But it is > not working for all conditions. > Thus, we go another way in v3. Use regs, which can represent the > signal status, to decide if we needs to do detection again. > > Changes in v2: > - Separate the patch into two patches > > Jammy Huang (2): > media: aspeed: Add macro for the fields of the mode-detect registers > media: aspeed: Fix unstable timing detection > > drivers/media/platform/aspeed-video.c | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) >
On 2022/1/25 下午 06:43, Hans Verkuil wrote: > Hi Jammy, > > On 18/01/2022 11:07, Jammy Huang wrote: >> This series fixes incorrect resolution detected. >> We found this problem happened occasionally in the switch between bios >> and bootloader. > Can you rebase this on top of: > > https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v5.18f > > This series doesn't apply cleanly. OK, I will update patch based on this code base. Regards, Jammy > > Regards, > > Hans > >> Changes in v4: >> - Correct the subject of patch >> >> Changes in v3: >> - In v2, we tried to increase the min-required-count of stable signal >> to avoid incorrect transient state in timing detection. But it is >> not working for all conditions. >> Thus, we go another way in v3. Use regs, which can represent the >> signal status, to decide if we needs to do detection again. >> >> Changes in v2: >> - Separate the patch into two patches >> >> Jammy Huang (2): >> media: aspeed: Add macro for the fields of the mode-detect registers >> media: aspeed: Fix unstable timing detection >> >> drivers/media/platform/aspeed-video.c | 25 ++++++++++++++++++++++++- >> 1 file changed, 24 insertions(+), 1 deletion(-) >>