[RFC,19/28] media: dt-bindings: media: renesas,vsp1: Document RZ/{G2L,V2L} VSPD bindings
| Message ID | 20220112174612.10773-20-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1n7hic-006h2n-4t; Wed, 12 Jan 2022 17:47:30 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1355958AbiALRrZ (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Wed, 12 Jan 2022 12:47:25 -0500
Received: from relmlor1.renesas.com ([210.160.252.171]:33462 "EHLO
relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL)
by vger.kernel.org with ESMTP id S240668AbiALRrM (ORCPT
<rfc822;linux-media@vger.kernel.org>);
Wed, 12 Jan 2022 12:47:12 -0500
X-IronPort-AV: E=Sophos;i="5.88,282,1635174000";
d="scan'208";a="106270405"
Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151])
by relmlie5.idc.renesas.com with ESMTP; 13 Jan 2022 02:47:09 +0900
Received: from localhost.localdomain (unknown [10.226.92.38])
by relmlir5.idc.renesas.com (Postfix) with ESMTP id DC24B4005E1F;
Thu, 13 Jan 2022 02:47:06 +0900 (JST)
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: Document
RZ/{G2L,V2L} VSPD bindings
Date: Wed, 12 Jan 2022 17:46:03 +0000
Message-Id: <20220112174612.10773-20-biju.das.jz@bp.renesas.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220112174612.10773-1-biju.das.jz@bp.renesas.com>
References: <20220112174612.10773-1-biju.das.jz@bp.renesas.com>
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -7.4 (-------)
X-LSpam-Report: No,
score=-7.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_HI=-5
autolearn=ham autolearn_force=no
|
| Series |
Add RZ/G2L Display support
|
|
Commit Message
Biju Das
Jan. 12, 2022, 5:46 p.m. UTC
Document VSPD found in RZ/G2L and RZ/V2L family SoC's.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > index 990e9c1dbc43..b27ee23d2b29 100644 > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > @@ -19,6 +19,7 @@ properties: > enum: > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L > > reg: > maxItems: 1 > @@ -27,7 +28,8 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 You have to define what each one is once you have more than 1. > > power-domains: > maxItems: 1 > -- > 2.17.1 > >
Hi Rob, Thanks for the review. > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: Document > RZ/{G2L,V2L} VSPD bindings > > On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > index 990e9c1dbc43..b27ee23d2b29 100644 > > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > @@ -19,6 +19,7 @@ properties: > > enum: > > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L > > > > reg: > > maxItems: 1 > > @@ -27,7 +28,8 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 3 > > You have to define what each one is once you have more than 1. Agreed, Will define each clocks. Regards, Biju > > > > > power-domains: > > maxItems: 1 > > -- > > 2.17.1 > > > >
Hi Biju, On Sat, Jan 22, 2022 at 11:23:32AM +0000, Biju Das wrote: > > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: Document > > RZ/{G2L,V2L} VSPD bindings > > > > On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > > > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > index 990e9c1dbc43..b27ee23d2b29 100644 > > > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > @@ -19,6 +19,7 @@ properties: > > > enum: > > > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > > > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > > > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L The commit message should explain why a new device-specific compatible value is needed. > > > > > > reg: > > > maxItems: 1 > > > @@ -27,7 +28,8 @@ properties: > > > maxItems: 1 > > > > > > clocks: > > > - maxItems: 1 > > > + minItems: 1 > > > + maxItems: 3 > > > > You have to define what each one is once you have more than 1. > > Agreed, Will define each clocks. This should also be conditioned by the compatible string, to have maxItems set to 1 for renesas,vsp1 and renesas,vsp2, and 3 for renesas,vsp2-r9a07g044. > > > power-domains: > > > maxItems: 1
Hi Laurent, Thanks for the feedback. > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: Document > RZ/{G2L,V2L} VSPD bindings > > Hi Biju, > > On Sat, Jan 22, 2022 at 11:23:32AM +0000, Biju Das wrote: > > > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: > > > Document RZ/{G2L,V2L} VSPD bindings > > > > > > On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > > > > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > --- > > > > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 > > > > +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > index 990e9c1dbc43..b27ee23d2b29 100644 > > > > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > @@ -19,6 +19,7 @@ properties: > > > > enum: > > > > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > > > > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > > > > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L > > The commit message should explain why a new device-specific compatible > value is needed. OK. Will add this in next version. Basically It does not have version register compared to other SoC's supported by this driver. > > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -27,7 +28,8 @@ properties: > > > > maxItems: 1 > > > > > > > > clocks: > > > > - maxItems: 1 > > > > + minItems: 1 > > > > + maxItems: 3 > > > > > > You have to define what each one is once you have more than 1. > > > > Agreed, Will define each clocks. > > This should also be conditioned by the compatible string, to have maxItems > set to 1 for renesas,vsp1 and renesas,vsp2, and 3 for renesas,vsp2- > r9a07g044. Agreed. Regards, Biju > > > > > power-domains: > > > > maxItems: 1 > > -- > Regards, > > Laurent Pinchart
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml index 990e9c1dbc43..b27ee23d2b29 100644 --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml @@ -19,6 +19,7 @@ properties: enum: - renesas,vsp1 # R-Car Gen2 and RZ/G1 - renesas,vsp2 # R-Car Gen3 and RZ/G2 + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L reg: maxItems: 1 @@ -27,7 +28,8 @@ properties: maxItems: 1 clocks: - maxItems: 1 + minItems: 1 + maxItems: 3 power-domains: maxItems: 1