mbox series

[0/3] Add 12bit and 14bit luma-only formats

Message ID 20220112161014.972076-1-jeanmichel.hautbois@ideasonboard.com (mailing list archive)
Headers
Series Add 12bit and 14bit luma-only formats |

Message

Jean-Michel Hautbois Jan. 12, 2022, 4:10 p.m. UTC 
  Hello,

While working on adding the V4L2-PIX-FMT-Y12P and V4L2-PIX-FMT-Y14P
formats, I noticed an issue in the way V4L2-PIX-FMT-Y10P is described.
This series aims to solve it before adding Y12P and Y14P.

Those two formats are needed for the next-to-come bcm2835 unicam driver.

Jean-Michel Hautbois (3):
  media: doc: pixfmt-yuv: Fix V4L2-PIX-FMT-Y10P format
  media: v4l: Add V4L2-PIX-FMT-Y12P format
  media: v4l: Add V4L2-PIX-FMT-Y14P format

 .../media/v4l/pixfmt-yuv-luma.rst             | 48 ++++++++++++++++++-
 drivers/media/v4l2-core/v4l2-ioctl.c          |  2 +
 include/uapi/linux/videodev2.h                |  2 +
 3 files changed, 50 insertions(+), 2 deletions(-)

Comments

Hans Verkuil Jan. 13, 2022, 9:15 a.m. UTC | #1 
Hi Jean-Michel,

On 12/01/2022 17:10, Jean-Michel Hautbois wrote:
> Hello,
> 
> While working on adding the V4L2-PIX-FMT-Y12P and V4L2-PIX-FMT-Y14P
> formats, I noticed an issue in the way V4L2-PIX-FMT-Y10P is described.
> This series aims to solve it before adding Y12P and Y14P.
> 
> Those two formats are needed for the next-to-come bcm2835 unicam driver.
> 
> Jean-Michel Hautbois (3):
>   media: doc: pixfmt-yuv: Fix V4L2-PIX-FMT-Y10P format
>   media: v4l: Add V4L2-PIX-FMT-Y12P format
>   media: v4l: Add V4L2-PIX-FMT-Y14P format
> 
>  .../media/v4l/pixfmt-yuv-luma.rst             | 48 ++++++++++++++++++-
>  drivers/media/v4l2-core/v4l2-ioctl.c          |  2 +
>  include/uapi/linux/videodev2.h                |  2 +
>  3 files changed, 50 insertions(+), 2 deletions(-)
> 

I'll take the first patch, but it is better to add patches 2 and 3 to the unicam RFC
series. Adding pixelformats that are not used by any existing driver isn't a good idea
and I'd like to avoid that.

Regards,

	Hans
Jean-Michel Hautbois Jan. 13, 2022, 9:27 a.m. UTC | #2 
Hi Hans !

On 13/01/2022 10:15, Hans Verkuil wrote:
> Hi Jean-Michel,
> 
> On 12/01/2022 17:10, Jean-Michel Hautbois wrote:
>> Hello,
>>
>> While working on adding the V4L2-PIX-FMT-Y12P and V4L2-PIX-FMT-Y14P
>> formats, I noticed an issue in the way V4L2-PIX-FMT-Y10P is described.
>> This series aims to solve it before adding Y12P and Y14P.
>>
>> Those two formats are needed for the next-to-come bcm2835 unicam driver.
>>
>> Jean-Michel Hautbois (3):
>>    media: doc: pixfmt-yuv: Fix V4L2-PIX-FMT-Y10P format
>>    media: v4l: Add V4L2-PIX-FMT-Y12P format
>>    media: v4l: Add V4L2-PIX-FMT-Y14P format
>>
>>   .../media/v4l/pixfmt-yuv-luma.rst             | 48 ++++++++++++++++++-
>>   drivers/media/v4l2-core/v4l2-ioctl.c          |  2 +
>>   include/uapi/linux/videodev2.h                |  2 +
>>   3 files changed, 50 insertions(+), 2 deletions(-)
>>
> 
> I'll take the first patch, but it is better to add patches 2 and 3 to the unicam RFC
> series. Adding pixelformats that are not used by any existing driver isn't a good idea
> and I'd like to avoid that.

Thanks, I will take those two patches back in the unicam RFC v2 series then.

> 
> Regards,
> 
> 	Hans
>