diff mbox series

[4/4] media: davinci: vpif: drop probe printk

Message ID 20211222142025.30364-5-johan@kernel.org (mailing list archive)
State Accepted, archived
Delegated to: Hans Verkuil
Headers
Series media: davinci: vpif: fix use-after-free on driver unbind |

Commit Message

Johan Hovold Dec. 22, 2021, 2:20 p.m. UTC 
  Drivers should generally not print anything for a successful probe, and
printing "success" before probe is done makes no sense.

Drop the unnecessary and misleading dev_info() call from probe.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/media/platform/davinci/vpif.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Prabhakar Jan. 4, 2022, 6:31 p.m. UTC | #1 
Hi Johan,

Thank you for the patch.

On Wed, Dec 22, 2021 at 2:20 PM Johan Hovold <johan@kernel.org> wrote:
>
> Drivers should generally not print anything for a successful probe, and
> printing "success" before probe is done makes no sense.
>
> Drop the unnecessary and misleading dev_info() call from probe.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/media/platform/davinci/vpif.c | 2 --
>  1 file changed, 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> index 4a260f4ed236..03b4e51bb13a 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -456,8 +456,6 @@ static int vpif_probe(struct platform_device *pdev)
>         pm_runtime_enable(&pdev->dev);
>         pm_runtime_get(&pdev->dev);
>
> -       dev_info(&pdev->dev, "vpif probe success\n");
> -
>         /*
>          * If VPIF Node has endpoints, assume "new" DT support,
>          * where capture and display drivers don't have DT nodes
> --
> 2.32.0
>
diff mbox series

Patch

diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
index 4a260f4ed236..03b4e51bb13a 100644
--- a/drivers/media/platform/davinci/vpif.c
+++ b/drivers/media/platform/davinci/vpif.c
@@ -456,8 +456,6 @@  static int vpif_probe(struct platform_device *pdev)
 	pm_runtime_enable(&pdev->dev);
 	pm_runtime_get(&pdev->dev);
 
-	dev_info(&pdev->dev, "vpif probe success\n");
-
 	/*
 	 * If VPIF Node has endpoints, assume "new" DT support,
 	 * where capture and display drivers don't have DT nodes