Message ID | 20220103110922.715065-1-petko.manolov@konsulko.com (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1n4LDk-00BrEf-AJ; Mon, 03 Jan 2022 11:09:44 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232831AbiACLJm (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 3 Jan 2022 06:09:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbiACLJl (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 3 Jan 2022 06:09:41 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33418C061761 for <linux-media@vger.kernel.org>; Mon, 3 Jan 2022 03:09:41 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id bm14so134530026edb.5 for <linux-media@vger.kernel.org>; Mon, 03 Jan 2022 03:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gjHFmqKKy0pvx7C1xJpG5YoxXkIX6ICHWLbHG010pUE=; b=WHb4Q//CZyIHB75AN8epaDq5FKSsTwLkk0pq8K6sekgcyAZO38PlUOh0HV2DpeSba6 tcJzB5oQBzkPiwMimifu6FtB3wUwPi+LxZsu5EjUEyci8V4140Fv3V7M7kSJIN6Flq8V 6RjLda+m/ZF9IvoeYKTST5pOhpTqYk9zCNUQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gjHFmqKKy0pvx7C1xJpG5YoxXkIX6ICHWLbHG010pUE=; b=hSB930MSXFnQzlKWiN5lDRpnGCgVZQBq60rP6aHw/kgKT/aBIDXOu1z0LfZYsQf1Kj /o3nxTfKBwQUH2xakrAz7bM//VFMLb/ndpvt3jF8QWamttVbt8T8nKFCRuLwENLIUTU6 AQn8JcNxsJzEIxQ0324nRji3ND5ilgeCHmYeBn8QV/35zYHIPB/6Jc5cGMRy3BpT0ov+ CkF2xSl5joxyGwYtq3L2aFMmqMLmOPvHRVxvf1l/evjO6F9km2JTghtCw9ytuWp7YTfh UdvA1/5eU0Svzjp6k5FxY1zsoAWcTsgodZ6XuPhSUHFU8QMzukh9j7+4h95nt1jePYtF tiFg== X-Gm-Message-State: AOAM531vkM7GlgNnRVQryDSLzxt/XYXsqFpIwa7eCxAzptWzNw2immay HVoONnvm6EByyu6RF1UGV41NppWZtbLGiQ== X-Google-Smtp-Source: ABdhPJxuepiG4jT8X9U/D/daZRrx+tlmyF1oHt+qLOeP8WfbE9S98gYtRTJgWmFRVelbBzisC1EFAA== X-Received: by 2002:a17:906:dc95:: with SMTP id cs21mr37345327ejc.532.1641208179556; Mon, 03 Jan 2022 03:09:39 -0800 (PST) Received: from taos.k.g (lan.nucleusys.com. [92.247.61.126]) by smtp.gmail.com with ESMTPSA id d17sm10536476ejd.217.2022.01.03.03.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jan 2022 03:09:39 -0800 (PST) From: Petko Manolov <petko.manolov@konsulko.com> To: linux-media@vger.kernel.org Cc: Petko Manolov <petko.manolov@konsulko.com> Subject: [PATCH v2 0/5] adds ovm6211 driver to staging Date: Mon, 3 Jan 2022 13:09:17 +0200 Message-Id: <20220103110922.715065-1-petko.manolov@konsulko.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series | adds ovm6211 driver to staging | |
Message
Petko Manolov
Jan. 3, 2022, 11:09 a.m. UTC
v2: Removes an unused function (ovm6211_set_pix_clk) and this patch series is now based on media/master; Didn't receive any comments about the RFC version, thus i assume everything is perfect... :P This patch adds ovm6211 driver into the staging directory. It also creates media/i2c entry, where ovm6211.c lives for now, to mimic the generic media source tree. Petko Manolov (5): adds ovm6211 driver to staging adds ovm6211 entry to Kconfig adds ovm6211 entry to Makefile adds drivers/staging/media/i2c/Kconfig entry adds i2c/ explicitly to Makefile drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile | 1 + drivers/staging/media/i2c/Kconfig | 9 + drivers/staging/media/i2c/Makefile | 1 + drivers/staging/media/i2c/ovm6211.c | 1143 +++++++++++++++++++++++++++ 5 files changed, 1156 insertions(+) create mode 100644 drivers/staging/media/i2c/Kconfig create mode 100644 drivers/staging/media/i2c/Makefile create mode 100644 drivers/staging/media/i2c/ovm6211.c base-commit: 68b9bcc8a534cd11fe55f8bc82f948aae7d81b3c
Comments
Hi Petko, Quoting Petko Manolov (2022-01-03 11:09:17) > v2: Removes an unused function (ovm6211_set_pix_clk) and this patch series is > now based on media/master; Didn't receive any comments about the RFC version, > thus i assume everything is perfect... :P Did you see https://lore.kernel.org/linux-media/Ya9XHiz%2FPm4CjQ13@valkosipuli.retiisi.eu/? Sakari provided quite a few review comments to consider. I don't think we need to add new sensor drivers to the staging directory which would simplify your series quite a bit, and Sakari also stated the ovm6211 KConfig and Makefile entry should be in the patch along with the new driver code (not in staging). So you would need to refactor this series to a single patch adding the driver do drivers/media/i2c/, and a second patch which adds the DT-bindings accordingly. -- Kieran > > This patch adds ovm6211 driver into the staging directory. It also creates > media/i2c entry, where ovm6211.c lives for now, to mimic the generic media > source tree. > > Petko Manolov (5): > adds ovm6211 driver to staging > adds ovm6211 entry to Kconfig > adds ovm6211 entry to Makefile > adds drivers/staging/media/i2c/Kconfig entry > adds i2c/ explicitly to Makefile > > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > drivers/staging/media/i2c/Kconfig | 9 + > drivers/staging/media/i2c/Makefile | 1 + > drivers/staging/media/i2c/ovm6211.c | 1143 +++++++++++++++++++++++++++ > 5 files changed, 1156 insertions(+) > create mode 100644 drivers/staging/media/i2c/Kconfig > create mode 100644 drivers/staging/media/i2c/Makefile > create mode 100644 drivers/staging/media/i2c/ovm6211.c > > > base-commit: 68b9bcc8a534cd11fe55f8bc82f948aae7d81b3c > -- > 2.30.2 >
On 22-01-03 13:19:22, Kieran Bingham wrote: > Hi Petko, > > Quoting Petko Manolov (2022-01-03 11:09:17) > > v2: Removes an unused function (ovm6211_set_pix_clk) and this patch series is > > now based on media/master; Didn't receive any comments about the RFC version, > > thus i assume everything is perfect... :P > > Did you see > https://lore.kernel.org/linux-media/Ya9XHiz%2FPm4CjQ13@valkosipuli.retiisi.eu/? > > Sakari provided quite a few review comments to consider. Nope, somehow his message has slipped from my attention. I'd like to thank Sakari for the thorough review. This is my first v4l2 driver and i have most likely made a lot of mistakes. I'll address all his comments in v3 of the series along with some elaboration on my part. > I don't think we need to add new sensor drivers to the staging directory which > would simplify your series quite a bit, and Sakari also stated the ovm6211 > KConfig and Makefile entry should be in the patch along with the new driver > code (not in staging). This is the exact opposite to what i've done for the netdev tree, where each change should be in a separate patch. Anyway, i'll follow the media tree rules. > So you would need to refactor this series to a single patch adding the driver > do drivers/media/i2c/, and a second patch which adds the DT-bindings > accordingly. I am not sure about how practical the DT will be in this case. The sensor was used on a custom board and a rather specific reset pin wiring. I've tried to remove this logic from the driver, but it is still reflected in the DT that we've been using so far. I've got to think about this one some more... cheers, Petko
Quoting Petko Manolov (2022-01-03 21:19:21) > On 22-01-03 13:19:22, Kieran Bingham wrote: > > Hi Petko, > > > > Quoting Petko Manolov (2022-01-03 11:09:17) > > > v2: Removes an unused function (ovm6211_set_pix_clk) and this patch series is > > > now based on media/master; Didn't receive any comments about the RFC version, > > > thus i assume everything is perfect... :P > > > > Did you see > > https://lore.kernel.org/linux-media/Ya9XHiz%2FPm4CjQ13@valkosipuli.retiisi.eu/? > > > > Sakari provided quite a few review comments to consider. > > Nope, somehow his message has slipped from my attention. I'd like to thank > Sakari for the thorough review. This is my first v4l2 driver and i have most > likely made a lot of mistakes. I'll address all his comments in v3 of the > series along with some elaboration on my part. > > > I don't think we need to add new sensor drivers to the staging directory which > > would simplify your series quite a bit, and Sakari also stated the ovm6211 > > KConfig and Makefile entry should be in the patch along with the new driver > > code (not in staging). > > This is the exact opposite to what i've done for the netdev tree, where each > change should be in a separate patch. Anyway, i'll follow the media tree rules. > > > So you would need to refactor this series to a single patch adding the driver > > do drivers/media/i2c/, and a second patch which adds the DT-bindings > > accordingly. > > I am not sure about how practical the DT will be in this case. The sensor was > used on a custom board and a rather specific reset pin wiring. I've tried to > remove this logic from the driver, but it is still reflected in the DT that > we've been using so far. I've got to think about this one some more... That's why the bindings are different from the DT itself. The specifics of how you connect it up belong to your device tree, but the bindings are there to state how you describe the hardware. Think of the bindings as the documentation part for how someone would write the device-tree nodes for your sensor driver to use it on their custom platform. It should be something like: Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml for example. As I understand it, any driver which adds a .compatible string must provide bindings. -- Kieran