| Message ID | 20211103011357.22067-1-jammy_huang@aspeedtech.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Hans Verkuil |
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1mi4rK-00DKCi-IQ; Wed, 03 Nov 2021 01:14:39 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230389AbhKCBRH (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Tue, 2 Nov 2021 21:17:07 -0400
Received: from twspam01.aspeedtech.com ([211.20.114.71]:16078 "EHLO
twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229844AbhKCBRH (ORCPT
<rfc822;linux-media@vger.kernel.org>); Tue, 2 Nov 2021 21:17:07 -0400
Received: from mail.aspeedtech.com ([192.168.0.24])
by twspam01.aspeedtech.com with ESMTP id 1A30oVLk051715;
Wed, 3 Nov 2021 08:50:31 +0800 (GMT-8)
(envelope-from jammy_huang@aspeedtech.com)
Received: from JammyHuang-PC.aspeed.com (192.168.2.115) by TWMBX02.aspeed.com
(192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Nov
2021 09:13:21 +0800
From: Jammy Huang <jammy_huang@aspeedtech.com>
To: <eajames@linux.ibm.com>, <mchehab@kernel.org>, <joel@jms.id.au>,
<andrew@aj.id.au>, <linux-media@vger.kernel.org>,
<openbmc@lists.ozlabs.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
CC: Paul Menzel <pmenzel@molgen.mpg.de>
Subject: [PATCH v2] media: aspeed: fix mode-detect always time out at 2nd run
Date: Wed, 3 Nov 2021 09:13:57 +0800
Message-ID: <20211103011357.22067-1-jammy_huang@aspeedtech.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII
X-Originating-IP: [192.168.2.115]
X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com
(192.168.0.24)
X-DNSRBL:
X-MAIL: twspam01.aspeedtech.com 1A30oVLk051715
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -2.4 (--)
X-LSpam-Report: No,
score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_NONE=-0.0001
autolearn=ham autolearn_force=no
|
| Series |
[v2] media: aspeed: fix mode-detect always time out at 2nd run
|
|
Commit Message
Jammy Huang
Nov. 3, 2021, 1:13 a.m. UTC
aspeed_video_get_resolution() will try to do res-detect again if the timing got in last try is invalid. But it will always time out because VE_SEQ_CTRL_TRIG_MODE_DET is only cleared after 1st mode-detect. To fix the problem, just clear VE_SEQ_CTRL_TRIG_MODE_DET before setting it in aspeed_video_enable_mode_detect(). Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> Acked-by: Paul Menzel <pmenzel@molgen.mpg.de> --- v2: - update commit message --- drivers/media/platform/aspeed-video.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Comments
On Wed, 3 Nov 2021 at 01:13, Jammy Huang <jammy_huang@aspeedtech.com> wrote: > > aspeed_video_get_resolution() will try to do res-detect again if the > timing got in last try is invalid. But it will always time out because > VE_SEQ_CTRL_TRIG_MODE_DET is only cleared after 1st mode-detect. > > To fix the problem, just clear VE_SEQ_CTRL_TRIG_MODE_DET before setting > it in aspeed_video_enable_mode_detect(). > > Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> > Acked-by: Paul Menzel <pmenzel@molgen.mpg.de> Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > v2: > - update commit message > --- > drivers/media/platform/aspeed-video.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index 5ffbabf884eb..fea5e4d0927e 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -518,6 +518,10 @@ static void aspeed_video_enable_mode_detect(struct aspeed_video *video) > aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, > VE_INTERRUPT_MODE_DETECT); > > + /* Disable mode detect in order to re-trigger */ > + aspeed_video_update(video, VE_SEQ_CTRL, > + VE_SEQ_CTRL_TRIG_MODE_DET, 0); > + > /* Trigger mode detect */ > aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_MODE_DET); > } > @@ -809,10 +813,6 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) > return; > } > > - /* Disable mode detect in order to re-trigger */ > - aspeed_video_update(video, VE_SEQ_CTRL, > - VE_SEQ_CTRL_TRIG_MODE_DET, 0); > - > aspeed_video_check_and_set_polarity(video); > > aspeed_video_enable_mode_detect(video); > -- > 2.25.1 >
On Wed, 3 Nov 2021 at 01:47, Joel Stanley <joel@jms.id.au> wrote: > > On Wed, 3 Nov 2021 at 01:13, Jammy Huang <jammy_huang@aspeedtech.com> wrote: > > > > aspeed_video_get_resolution() will try to do res-detect again if the > > timing got in last try is invalid. But it will always time out because > > VE_SEQ_CTRL_TRIG_MODE_DET is only cleared after 1st mode-detect. > > > > To fix the problem, just clear VE_SEQ_CTRL_TRIG_MODE_DET before setting > > it in aspeed_video_enable_mode_detect(). > > > > Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> > > Acked-by: Paul Menzel <pmenzel@molgen.mpg.de> > > Reviewed-by: Joel Stanley <joel@jms.id.au> When applying, can we please have this tag added: Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") Cheers, Joel > > > --- > > v2: > > - update commit message > > --- > > drivers/media/platform/aspeed-video.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > > index 5ffbabf884eb..fea5e4d0927e 100644 > > --- a/drivers/media/platform/aspeed-video.c > > +++ b/drivers/media/platform/aspeed-video.c > > @@ -518,6 +518,10 @@ static void aspeed_video_enable_mode_detect(struct aspeed_video *video) > > aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, > > VE_INTERRUPT_MODE_DETECT); > > > > + /* Disable mode detect in order to re-trigger */ > > + aspeed_video_update(video, VE_SEQ_CTRL, > > + VE_SEQ_CTRL_TRIG_MODE_DET, 0); > > + > > /* Trigger mode detect */ > > aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_MODE_DET); > > } > > @@ -809,10 +813,6 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) > > return; > > } > > > > - /* Disable mode detect in order to re-trigger */ > > - aspeed_video_update(video, VE_SEQ_CTRL, > > - VE_SEQ_CTRL_TRIG_MODE_DET, 0); > > - > > aspeed_video_check_and_set_polarity(video); > > > > aspeed_video_enable_mode_detect(video); > > -- > > 2.25.1 > >
Dear Joel, Sure. Thanks for your reminder. On 2021/11/3 上午 09:53, Joel Stanley wrote: > On Wed, 3 Nov 2021 at 01:47, Joel Stanley <joel@jms.id.au> wrote: >> On Wed, 3 Nov 2021 at 01:13, Jammy Huang <jammy_huang@aspeedtech.com> wrote: >>> aspeed_video_get_resolution() will try to do res-detect again if the >>> timing got in last try is invalid. But it will always time out because >>> VE_SEQ_CTRL_TRIG_MODE_DET is only cleared after 1st mode-detect. >>> >>> To fix the problem, just clear VE_SEQ_CTRL_TRIG_MODE_DET before setting >>> it in aspeed_video_enable_mode_detect(). >>> >>> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> >>> Acked-by: Paul Menzel <pmenzel@molgen.mpg.de> >> Reviewed-by: Joel Stanley <joel@jms.id.au> > When applying, can we please have this tag added: > > Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") > > Cheers, > > Joel > > >>> --- >>> v2: >>> - update commit message >>> --- >>> drivers/media/platform/aspeed-video.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >>> index 5ffbabf884eb..fea5e4d0927e 100644 >>> --- a/drivers/media/platform/aspeed-video.c >>> +++ b/drivers/media/platform/aspeed-video.c >>> @@ -518,6 +518,10 @@ static void aspeed_video_enable_mode_detect(struct aspeed_video *video) >>> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >>> VE_INTERRUPT_MODE_DETECT); >>> >>> + /* Disable mode detect in order to re-trigger */ >>> + aspeed_video_update(video, VE_SEQ_CTRL, >>> + VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> + >>> /* Trigger mode detect */ >>> aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_MODE_DET); >>> } >>> @@ -809,10 +813,6 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >>> return; >>> } >>> >>> - /* Disable mode detect in order to re-trigger */ >>> - aspeed_video_update(video, VE_SEQ_CTRL, >>> - VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> - >>> aspeed_video_check_and_set_polarity(video); >>> >>> aspeed_video_enable_mode_detect(video); >>> -- >>> 2.25.1 >>>
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c index 5ffbabf884eb..fea5e4d0927e 100644 --- a/drivers/media/platform/aspeed-video.c +++ b/drivers/media/platform/aspeed-video.c @@ -518,6 +518,10 @@ static void aspeed_video_enable_mode_detect(struct aspeed_video *video) aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, VE_INTERRUPT_MODE_DETECT); + /* Disable mode detect in order to re-trigger */ + aspeed_video_update(video, VE_SEQ_CTRL, + VE_SEQ_CTRL_TRIG_MODE_DET, 0); + /* Trigger mode detect */ aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_MODE_DET); } @@ -809,10 +813,6 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) return; } - /* Disable mode detect in order to re-trigger */ - aspeed_video_update(video, VE_SEQ_CTRL, - VE_SEQ_CTRL_TRIG_MODE_DET, 0); - aspeed_video_check_and_set_polarity(video); aspeed_video_enable_mode_detect(video);