Message ID | 097d8602906e9db279728330c6cf2837be184704.1635338663.git.geert+renesas@glider.be (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1mfiJG-002Jrj-8l; Wed, 27 Oct 2021 12:45:38 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240158AbhJ0MsB (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 27 Oct 2021 08:48:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230487AbhJ0MsA (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 27 Oct 2021 08:48:00 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2547C061767 for <linux-media@vger.kernel.org>; Wed, 27 Oct 2021 05:45:34 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:441:6c1a:bc30:46e]) by andre.telenet-ops.be with bizsmtp id B0lY2600C2hfXWm010lYZU; Wed, 27 Oct 2021 14:45:33 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1mfiJ9-008U4Y-VJ; Wed, 27 Oct 2021 14:45:31 +0200 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1mfiJ9-00DuIR-Ed; Wed, 27 Oct 2021 14:45:31 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Dikshita Agarwal <dikshita@codeaurora.org>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names Date: Wed, 27 Oct 2021 14:45:30 +0200 Message-Id: <097d8602906e9db279728330c6cf2837be184704.1635338663.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_NONE=-0.0001 autolearn=ham autolearn_force=no |
Series |
bindings: media: venus: Drop bogus maxItems for power-domain-names
|
|
Commit Message
Geert Uytterhoeven
Oct. 27, 2021, 12:45 p.m. UTC
make dt_binding_check:
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names
warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 -
1 file changed, 1 deletion(-)
Comments
On Wed, Oct 27, 2021 at 02:45:30PM +0200, Geert Uytterhoeven wrote: > make dt_binding_check: I'd say it's redundant rather than bogus. > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names > warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 - > 1 file changed, 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org>
Hi Rob, On Mon, Nov 1, 2021 at 10:36 PM Rob Herring <robh@kernel.org> wrote: > On Wed, Oct 27, 2021 at 02:45:30PM +0200, Geert Uytterhoeven wrote: > > make dt_binding_check: > > I'd say it's redundant rather than bogus. I wrote "bogus", as the "redundant" ones typically give: hint: "maxItems" is not needed with an "items" list And I didn't get that here? > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names > > warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > > > Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 - > > 1 file changed, 1 deletion(-) > > Acked-by: Rob Herring <robh@kernel.org> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Nov 2, 2021 at 3:42 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Rob, > > On Mon, Nov 1, 2021 at 10:36 PM Rob Herring <robh@kernel.org> wrote: > > On Wed, Oct 27, 2021 at 02:45:30PM +0200, Geert Uytterhoeven wrote: > > > make dt_binding_check: > > > > I'd say it's redundant rather than bogus. > > I wrote "bogus", as the "redundant" ones typically give: > > hint: "maxItems" is not needed with an "items" list > > And I didn't get that here? Any schema file with an error shows up twice. First there's all the specific errors with details. Then there's what you reference which is all the schemas that we're skipping. If you set DT_SCHEMA_FILES now, you should only see the second case for other schema files. So it's probably better to reference the actual error: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: properties:power-domain-names: {'minItems': 2, 'maxItems': 3, 'items': [{'const': 'venus'}, {'const': 'vcodec0'}, {'const': 'cx'}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names > > > warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > > > > > Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema") > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 - > > > 1 file changed, 1 deletion(-) > > > > Acked-by: Rob Herring <robh@kernel.org> > > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml index fa54c560e0bde3cb..e2874683b4d5faf3 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml @@ -30,7 +30,6 @@ properties: power-domain-names: minItems: 2 - maxItems: 3 items: - const: venus - const: vcodec0