| Message ID | 20211007154407.29746-7-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1mYVZE-009Lwn-Gu; Thu, 07 Oct 2021 15:44:20 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S242493AbhJGPqM (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Thu, 7 Oct 2021 11:46:12 -0400
Received: from mga06.intel.com ([134.134.136.31]:45046 "EHLO mga06.intel.com"
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
id S242407AbhJGPqL (ORCPT <rfc822;linux-media@vger.kernel.org>);
Thu, 7 Oct 2021 11:46:11 -0400
X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="287168772"
X-IronPort-AV: E=Sophos;i="5.85,355,1624345200";
d="scan'208";a="287168772"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
07 Oct 2021 08:44:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,355,1624345200";
d="scan'208";a="568676724"
Received: from black.fi.intel.com ([10.237.72.28])
by fmsmga002.fm.intel.com with ESMTP; 07 Oct 2021 08:44:08 -0700
Received: by black.fi.intel.com (Postfix, from userid 1003)
id 7595A554; Thu, 7 Oct 2021 18:44:10 +0300 (EEST)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Brendan Higgins <brendanhiggins@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-media@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
jic23@kernel.org, linux@rasmusvillemoes.dk,
Thorsten Leemhuis <regressions@leemhuis.info>
Subject: [PATCH v4 6/7] plist: Replace kernel.h with the necessary inclusions
Date: Thu, 7 Oct 2021 18:44:06 +0300
Message-Id: <20211007154407.29746-7-andriy.shevchenko@linux.intel.com>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20211007154407.29746-1-andriy.shevchenko@linux.intel.com>
References: <20211007154407.29746-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -4.7 (----)
X-LSpam-Report: No,
score=-4.7 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3
autolearn=ham autolearn_force=no
|
| Series |
kernel.h further split
|
|
Commit Message
Andy Shevchenko
Oct. 7, 2021, 3:44 p.m. UTC
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/plist.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Comments
On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > When kernel.h is used in the headers it adds a lot into dependency hell, > especially when there are circular dependencies are involved. > > Replace kernel.h inclusion with the list of what is really being used. [] > diff --git a/include/linux/plist.h b/include/linux/plist.h [] > @@ -73,8 +73,11 @@ [] > +#include <asm/bug.h> why asm/bug.h and not linux/bug.h ?
On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote: > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > > > Replace kernel.h inclusion with the list of what is really being used. > [] > > diff --git a/include/linux/plist.h b/include/linux/plist.h > [] > > @@ -73,8 +73,11 @@ > [] > > +#include <asm/bug.h> > > why asm/bug.h and not linux/bug.h ? The direct inclusion is from that one. Why linux/bug? What are we going to use from it?
On Thu, 2021-10-07 at 20:19 +0300, Andy Shevchenko wrote: > On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote: > > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > especially when there are circular dependencies are involved. > > > > > > Replace kernel.h inclusion with the list of what is really being used. > > [] > > > diff --git a/include/linux/plist.h b/include/linux/plist.h > > [] > > > @@ -73,8 +73,11 @@ > > [] > > > +#include <asm/bug.h> > > > > why asm/bug.h and not linux/bug.h ? > > The direct inclusion is from that one. Why linux/bug? A general guideline is to avoid asm includes.
On Thu, Oct 07, 2021 at 10:26:05AM -0700, Joe Perches wrote: > On Thu, 2021-10-07 at 20:19 +0300, Andy Shevchenko wrote: > > On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote: > > > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > > especially when there are circular dependencies are involved. > > > > > > > > Replace kernel.h inclusion with the list of what is really being used. > > > [] > > > > diff --git a/include/linux/plist.h b/include/linux/plist.h > > > [] > > > > @@ -73,8 +73,11 @@ > > > [] > > > > +#include <asm/bug.h> > > > > > > why asm/bug.h and not linux/bug.h ? > > > > The direct inclusion is from that one. Why linux/bug? > > A general guideline is to avoid asm includes. It's fine when it has any useful background. Doing cargo cult is not always a good idea. I plead for common sense.
On Thu, 2021-10-07 at 20:32 +0300, Andy Shevchenko wrote: > On Thu, Oct 07, 2021 at 10:26:05AM -0700, Joe Perches wrote: > > On Thu, 2021-10-07 at 20:19 +0300, Andy Shevchenko wrote: > > > On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote: > > > > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > > > especially when there are circular dependencies are involved. > > > > > > > > > > Replace kernel.h inclusion with the list of what is really being used. > > > > [] > > > > > diff --git a/include/linux/plist.h b/include/linux/plist.h > > > > [] > > > > > @@ -73,8 +73,11 @@ > > > > [] > > > > > +#include <asm/bug.h> > > > > > > > > why asm/bug.h and not linux/bug.h ? > > > > > > The direct inclusion is from that one. Why linux/bug? > > > > A general guideline is to avoid asm includes. > > It's fine when it has any useful background. Doing cargo cult is not always > a good idea. I plead for common sense. Common sense isn't particularly common. Someone is going to run checkpatch on it and submit a patch one day. Maybe add a comment for the less common. cheers, Joe
diff --git a/include/linux/plist.h b/include/linux/plist.h index 66bab1bca35c..0f352c1d3c80 100644 --- a/include/linux/plist.h +++ b/include/linux/plist.h @@ -73,8 +73,11 @@ #ifndef _LINUX_PLIST_H_ #define _LINUX_PLIST_H_ -#include <linux/kernel.h> +#include <linux/container_of.h> #include <linux/list.h> +#include <linux/types.h> + +#include <asm/bug.h> struct plist_head { struct list_head node_list;