Message ID | 20210726082117.2423597-1-martin.kepplinger@puri.sm (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1m7vsF-005nst-97; Mon, 26 Jul 2021 08:22:07 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233354AbhGZHlg (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 26 Jul 2021 03:41:36 -0400 Received: from comms.puri.sm ([159.203.221.185]:36200 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232454AbhGZHlg (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 26 Jul 2021 03:41:36 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 3E325DF782; Mon, 26 Jul 2021 01:21:35 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X7OlS0NrIxet; Mon, 26 Jul 2021 01:21:34 -0700 (PDT) From: Martin Kepplinger <martin.kepplinger@puri.sm> To: laurent.pinchart@ideasonboard.com, shawnguo@kernel.org Cc: devicetree@vger.kernel.org, festevam@gmail.com, kernel@pengutronix.de, kernel@puri.sm, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, m.felsch@pengutronix.de, mchehab@kernel.org, phone-devel@vger.kernel.org, robh@kernel.org, slongerbeam@gmail.com, Martin Kepplinger <martin.kepplinger@puri.sm> Subject: [PATCH v9 0/3] media: imx: add support for imx8mq MIPI RX Date: Mon, 26 Jul 2021 10:21:14 +0200 Message-Id: <20210726082117.2423597-1-martin.kepplinger@puri.sm> Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_NONE=-0.0001 autolearn=ham autolearn_force=no |
Series | media: imx: add support for imx8mq MIPI RX | |
Message
Martin Kepplinger
July 26, 2021, 8:21 a.m. UTC
hi, This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller. It includes the driver, the dt-bindings and the DT addition to the SoC dtsi. I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for any feedback, martin revision history ---------------- v9: (thank you Laurent) * improve getting the esc clock rate for hs_settle v8: (thank you Laurent) * calculate hs_settle for any clk rate and mode * add reviewed-by tag https://lore.kernel.org/linux-media/20210723101217.1954805-1-martin.kepplinger@puri.sm/T/ v7: (thank you Laurent and Rob) * fix the binding example (include the reset driver) * use pm_runtime_resume_and_get() * fix some logic in init_cfg() * add some useful code comments and fix minor bits found by Laurent in v6 https://lore.kernel.org/linux-media/20210716102244.581182-1-martin.kepplinger@puri.sm/T/#t v6: (thank you Laurent and Rob) * add reviewed-by tag to binding * statically allocate clk_bulk_data * fix how the hs_settle value is applied * remove s_power calls * remove the link_setup() callback implementation and make the link immutable * more cleanups according to Laurents' review from v5 https://lore.kernel.org/linux-media/20210714111931.324485-1-martin.kepplinger@puri.sm/ v5: (thank you Laurent) * fix reset usage by using the already supported reset controller driver * remove clko2 (totally unrelated clock / had been included by accident) * rename pxl clock to ui https://lore.kernel.org/linux-media/20210618095753.114557-1-martin.kepplinger@puri.sm/ v4: (thank you Rob and Marco) * create fsl,mipi-phy-gpr custom dt property instead of confusing "phy" * add imx8mq-specific compatibile to imx8mq.dtsi for future use https://lore.kernel.org/linux-media/20210614121522.2944593-1-martin.kepplinger@puri.sm/ v3: (thank you, Rob and Laurent) among minor other things according to v2 review, changes include: * better describe the clocks * rename DT property "phy-reset" to "reset" and "phy-gpr" to "phy" https://lore.kernel.org/linux-media/20210608104128.1616028-1-martin.kepplinger@puri.sm/T/#t v2: (thank you, Dan and Guido) among fixes according to v1 reviews, changes include: * remove status property from dt-bindings example * define a few bits in order to have less magic values * use "imx8mq_mipi_csi_" as local function prefix * read DT properties only during probe() * remove dead code (log_status) * add imx8mq_mipi_csi_release_icc() * fix imx8mq_mipi_csi_init_icc() https://lore.kernel.org/linux-media/20210531112326.90094-1-martin.kepplinger@puri.sm/ v1: https://lore.kernel.org/linux-media/20210527075407.3180744-1-martin.kepplinger@puri.sm/T/#t Martin Kepplinger (3): dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 174 ++++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 104 ++ drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx8mq-mipi-csi2.c | 976 ++++++++++++++++++ 4 files changed, 1255 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml create mode 100644 drivers/staging/media/imx/imx8mq-mipi-csi2.c
Comments
Hi Martin, On Mon, Jul 26, 2021 at 10:21:14AM +0200, Martin Kepplinger wrote: > hi, > > This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller. > > It includes the driver, the dt-bindings and the DT addition to the SoC dtsi. > I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for > any feedback, No more feedback from me :-) I'll take patches 1/3 and 2/3 in my tree and send a pull request. Shawn, could you please review 3/3 ? > revision history > ---------------- > v9: (thank you Laurent) > * improve getting the esc clock rate for hs_settle > > v8: (thank you Laurent) > * calculate hs_settle for any clk rate and mode > * add reviewed-by tag > https://lore.kernel.org/linux-media/20210723101217.1954805-1-martin.kepplinger@puri.sm/T/ > > v7: (thank you Laurent and Rob) > * fix the binding example (include the reset driver) > * use pm_runtime_resume_and_get() > * fix some logic in init_cfg() > * add some useful code comments and fix minor bits found by Laurent in v6 > https://lore.kernel.org/linux-media/20210716102244.581182-1-martin.kepplinger@puri.sm/T/#t > > v6: (thank you Laurent and Rob) > * add reviewed-by tag to binding > * statically allocate clk_bulk_data > * fix how the hs_settle value is applied > * remove s_power calls > * remove the link_setup() callback implementation and make the link immutable > * more cleanups according to Laurents' review from v5 > https://lore.kernel.org/linux-media/20210714111931.324485-1-martin.kepplinger@puri.sm/ > > v5: (thank you Laurent) > * fix reset usage by using the already supported reset controller driver > * remove clko2 (totally unrelated clock / had been included by accident) > * rename pxl clock to ui > https://lore.kernel.org/linux-media/20210618095753.114557-1-martin.kepplinger@puri.sm/ > > v4: (thank you Rob and Marco) > * create fsl,mipi-phy-gpr custom dt property instead of confusing "phy" > * add imx8mq-specific compatibile to imx8mq.dtsi for future use > https://lore.kernel.org/linux-media/20210614121522.2944593-1-martin.kepplinger@puri.sm/ > > v3: (thank you, Rob and Laurent) > among minor other things according to v2 review, changes include: > * better describe the clocks > * rename DT property "phy-reset" to "reset" and "phy-gpr" to "phy" > https://lore.kernel.org/linux-media/20210608104128.1616028-1-martin.kepplinger@puri.sm/T/#t > > v2: (thank you, Dan and Guido) > among fixes according to v1 reviews, changes include: > * remove status property from dt-bindings example > * define a few bits in order to have less magic values > * use "imx8mq_mipi_csi_" as local function prefix > * read DT properties only during probe() > * remove dead code (log_status) > * add imx8mq_mipi_csi_release_icc() > * fix imx8mq_mipi_csi_init_icc() > https://lore.kernel.org/linux-media/20210531112326.90094-1-martin.kepplinger@puri.sm/ > > v1: > https://lore.kernel.org/linux-media/20210527075407.3180744-1-martin.kepplinger@puri.sm/T/#t > > > Martin Kepplinger (3): > dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and > controller > media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller > arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions > > .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 174 ++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 104 ++ > drivers/staging/media/imx/Makefile | 1 + > drivers/staging/media/imx/imx8mq-mipi-csi2.c | 976 ++++++++++++++++++ > 4 files changed, 1255 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > create mode 100644 drivers/staging/media/imx/imx8mq-mipi-csi2.c
On Tue, Jul 27, 2021 at 04:00:42AM +0300, Laurent Pinchart wrote: > Hi Martin, > > On Mon, Jul 26, 2021 at 10:21:14AM +0200, Martin Kepplinger wrote: > > hi, > > > > This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller. > > > > It includes the driver, the dt-bindings and the DT addition to the SoC dtsi. > > I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for > > any feedback, > > No more feedback from me :-) I'll take patches 1/3 and 2/3 in my tree > and send a pull request. > > Shawn, could you please review 3/3 ? Yeah, it looks good, and I just picked it up. Shawn