Message ID | 20210628101054.828579-6-martin.kepplinger@puri.sm (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Sakari Ailus |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1lxoFM-002NBw-S7; Mon, 28 Jun 2021 10:12:09 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232855AbhF1KOc (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 28 Jun 2021 06:14:32 -0400 Received: from comms.puri.sm ([159.203.221.185]:37598 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232740AbhF1KO2 (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 28 Jun 2021 06:14:28 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id CFD84E016C; Mon, 28 Jun 2021 03:11:32 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t3cMoY75fokm; Mon, 28 Jun 2021 03:11:31 -0700 (PDT) From: Martin Kepplinger <martin.kepplinger@puri.sm> To: martin.kepplinger@puri.sm, krzysztof.kozlowski@canonical.com, laurent.pinchart@ideasonboard.com Cc: devicetree@vger.kernel.org, kernel@puri.sm, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, paul.kocialkowski@bootlin.com, pavel@ucw.cz, phone-devel@vger.kernel.org, robh@kernel.org, shawnx.tu@intel.com Subject: [PATCH v6 5/5] arm64: defconfig: enable VIDEO_HI846 Date: Mon, 28 Jun 2021 12:10:54 +0200 Message-Id: <20210628101054.828579-6-martin.kepplinger@puri.sm> In-Reply-To: <20210628101054.828579-1-martin.kepplinger@puri.sm> References: <20210628101054.828579-1-martin.kepplinger@puri.sm> Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_NONE=-0.0001 autolearn=ham autolearn_force=no |
Series |
Add support for the Hynix Hi-846 camera
|
|
Commit Message
Martin Kepplinger
June 28, 2021, 10:10 a.m. UTC
Build the driver for the Hi-846 camera by default on arm64 where it's
going to be used on at least the imx8mq-librem5 board.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Martin, On Mon, Jun 28, 2021 at 12:10:54PM +0200, Martin Kepplinger wrote: > Build the driver for the Hi-846 camera by default on arm64 where it's > going to be used on at least the imx8mq-librem5 board. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index f423d08b9a71..bf27d9cfbdd5 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m > CONFIG_VIDEO_QCOM_VENUS=m > CONFIG_SDR_PLATFORM_DRIVERS=y > CONFIG_VIDEO_RCAR_DRIF=m > +CONFIG_VIDEO_HI846=m > CONFIG_VIDEO_IMX219=m > CONFIG_VIDEO_OV5645=m > CONFIG_VIDEO_QCOM_CAMSS=m The same sensor may be or may not used on a given board (and certainly it's not specific to arm64). Is it desirable all arm64 systems compile this in by default? There appear to be a other sensor drivers though. Is there a defconfig for the librem5 board? I wonder what others think.
Hi, On Thu, Jul 08, 2021 at 04:00:04PM +0300, Sakari Ailus wrote: > Hi Martin, > > On Mon, Jun 28, 2021 at 12:10:54PM +0200, Martin Kepplinger wrote: > > Build the driver for the Hi-846 camera by default on arm64 where it's > > going to be used on at least the imx8mq-librem5 board. > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index f423d08b9a71..bf27d9cfbdd5 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m > > CONFIG_VIDEO_QCOM_VENUS=m > > CONFIG_SDR_PLATFORM_DRIVERS=y > > CONFIG_VIDEO_RCAR_DRIF=m > > +CONFIG_VIDEO_HI846=m > > CONFIG_VIDEO_IMX219=m > > CONFIG_VIDEO_OV5645=m > > CONFIG_VIDEO_QCOM_CAMSS=m > > The same sensor may be or may not used on a given board (and certainly it's > not specific to arm64). Is it desirable all arm64 systems compile this in > by default? > > There appear to be a other sensor drivers though. > > Is there a defconfig for the librem5 board? arm64 has a single defconfig, there are no board specific ones (and afaik they're not wanted either) so I think enabling it as a module is the only way. Cheers, -- Guido > > I wonder what others think. > > -- > Kind regards, > > Sakari Ailus
Hi Guido, On Thu, Jul 08, 2021 at 05:13:13PM +0200, Guido Günther wrote: > On Thu, Jul 08, 2021 at 04:00:04PM +0300, Sakari Ailus wrote: > > On Mon, Jun 28, 2021 at 12:10:54PM +0200, Martin Kepplinger wrote: > > > Build the driver for the Hi-846 camera by default on arm64 where it's > > > going to be used on at least the imx8mq-librem5 board. > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > > --- > > > arch/arm64/configs/defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index f423d08b9a71..bf27d9cfbdd5 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m > > > CONFIG_VIDEO_QCOM_VENUS=m > > > CONFIG_SDR_PLATFORM_DRIVERS=y > > > CONFIG_VIDEO_RCAR_DRIF=m > > > +CONFIG_VIDEO_HI846=m > > > CONFIG_VIDEO_IMX219=m > > > CONFIG_VIDEO_OV5645=m > > > CONFIG_VIDEO_QCOM_CAMSS=m > > > > The same sensor may be or may not used on a given board (and certainly it's > > not specific to arm64). Is it desirable all arm64 systems compile this in > > by default? > > > > There appear to be a other sensor drivers though. > > > > Is there a defconfig for the librem5 board? > > arm64 has a single defconfig, there are no board specific ones (and > afaik they're not wanted either) so I think enabling it as a module is > the only way. Do sensor drivers qualify for defconfig support though ? If they do, they should all be enabled. > > I wonder what others think.
Hi Laurent, On Thu, Jul 08, 2021 at 06:34:32PM +0300, Laurent Pinchart wrote: > Hi Guido, > > On Thu, Jul 08, 2021 at 05:13:13PM +0200, Guido Günther wrote: > > On Thu, Jul 08, 2021 at 04:00:04PM +0300, Sakari Ailus wrote: > > > On Mon, Jun 28, 2021 at 12:10:54PM +0200, Martin Kepplinger wrote: > > > > Build the driver for the Hi-846 camera by default on arm64 where it's > > > > going to be used on at least the imx8mq-librem5 board. > > > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > > > --- > > > > arch/arm64/configs/defconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > > index f423d08b9a71..bf27d9cfbdd5 100644 > > > > --- a/arch/arm64/configs/defconfig > > > > +++ b/arch/arm64/configs/defconfig > > > > @@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m > > > > CONFIG_VIDEO_QCOM_VENUS=m > > > > CONFIG_SDR_PLATFORM_DRIVERS=y > > > > CONFIG_VIDEO_RCAR_DRIF=m > > > > +CONFIG_VIDEO_HI846=m > > > > CONFIG_VIDEO_IMX219=m > > > > CONFIG_VIDEO_OV5645=m > > > > CONFIG_VIDEO_QCOM_CAMSS=m > > > > > > The same sensor may be or may not used on a given board (and certainly it's > > > not specific to arm64). Is it desirable all arm64 systems compile this in > > > by default? > > > > > > There appear to be a other sensor drivers though. > > > > > > Is there a defconfig for the librem5 board? > > > > arm64 has a single defconfig, there are no board specific ones (and > > afaik they're not wanted either) so I think enabling it as a module is > > the only way. > > Do sensor drivers qualify for defconfig support though ? If they do, > they should all be enabled. I don't know. The Librem 5 / Librem 5 Devkit bits went in via Shawn's tree where the "here's a imx based board that uses this driver" was sufficient to get it enabled (preferably as module) so it can work out of the box. Cheers, -- Guido > > > > I wonder what others think. > > -- > Regards, > > Laurent Pinchart
Hi! > > > Build the driver for the Hi-846 camera by default on arm64 where it's > > > going to be used on at least the imx8mq-librem5 board. > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> .. > > There appear to be a other sensor drivers though. > > > > Is there a defconfig for the librem5 board? > > arm64 has a single defconfig, there are no board specific ones (and > afaik they're not wanted either) so I think enabling it as a module is > the only way. Given that other arm64 machines are basically devboards, and librem5 is a phone... where you expect tighter sw/hw configuration, maybe it should have a separate defconfig. Best regards, Pavel
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f423d08b9a71..bf27d9cfbdd5 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m CONFIG_VIDEO_QCOM_VENUS=m CONFIG_SDR_PLATFORM_DRIVERS=y CONFIG_VIDEO_RCAR_DRIF=m +CONFIG_VIDEO_HI846=m CONFIG_VIDEO_IMX219=m CONFIG_VIDEO_OV5645=m CONFIG_VIDEO_QCOM_CAMSS=m