| Message ID | 20210624182612.177969-11-ezequiel@collabora.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Hans Verkuil |
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1lwU4S-00EidB-MQ; Thu, 24 Jun 2021 18:27:24 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232596AbhFXS3m (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Thu, 24 Jun 2021 14:29:42 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:43938 "EHLO
bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229464AbhFXS3m (ORCPT
<rfc822;linux-media@vger.kernel.org>);
Thu, 24 Jun 2021 14:29:42 -0400
Received: from [127.0.0.1] (localhost [127.0.0.1])
(Authenticated sender: ezequiel)
with ESMTPSA id BF8D31F44219
From: Ezequiel Garcia <ezequiel@collabora.com>
To: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Philipp Zabel <p.zabel@pengutronix.de>,
Heiko Stuebner <heiko@sntech.de>,
Alex Bee <knaerzche@gmail.com>, maccraft123mc@gmail.com,
Chris Healy <cphealy@gmail.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
David Airlie <airlied@linux.ie>, kernel@collabora.com,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH 10/12] dt-bindings: media: rockchip-vpu: Add PX30 compatible
Date: Thu, 24 Jun 2021 15:26:10 -0300
Message-Id: <20210624182612.177969-11-ezequiel@collabora.com>
X-Mailer: git-send-email 2.30.0
In-Reply-To: <20210624182612.177969-1-ezequiel@collabora.com>
References: <20210624182612.177969-1-ezequiel@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -3.1 (---)
X-LSpam-Report: No,
score=-3.1 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_LOW=-0.7,UNPARSEABLE_RELAY=0.001
autolearn=ham autolearn_force=no
|
| Series |
hantro: Enable H.264 VDPU2 (Odroid Advance Go)
|
|
Commit Message
Ezequiel Garcia
June 24, 2021, 6:26 p.m. UTC
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) and an encoder (VEPU2). Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ 1 file changed, 3 insertions(+)
Comments
Hi, On 24.06.21 21:26, Ezequiel Garcia wrote: > From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) > and an encoder (VEPU2). > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > --- > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index b88172a59de7..3b9c5aa91fcc 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -28,6 +28,9 @@ properties: > - items: > - const: rockchip,rk3228-vpu > - const: rockchip,rk3399-vpu > + - items: > + - const: rockchip,px30-vpu > + - const: rockchip,rk3399-vpu This rk3399 compatible is already mentioned in the last 'items' list, should we add it again? Thanks, Dafna > > reg: > maxItems: 1 >
Hey Dafna, Thanks a lot for reviewing this. On Fri, 2021-06-25 at 12:21 +0300, Dafna Hirschfeld wrote: > Hi, > > On 24.06.21 21:26, Ezequiel Garcia wrote: > > From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > > > The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) > > and an encoder (VEPU2). > > > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > > --- > > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > > index b88172a59de7..3b9c5aa91fcc 100644 > > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > > @@ -28,6 +28,9 @@ properties: > > - items: > > - const: rockchip,rk3228-vpu > > - const: rockchip,rk3399-vpu > > + - items: > > + - const: rockchip,px30-vpu > > + - const: rockchip,rk3399-vpu > > This rk3399 compatible is already mentioned in the last 'items' list, should we add it again? > What we are mandating here is that "rockchip,px30-vpu" can only be used with "rockchip,rk3399-vpu". I.e.: compatible = "rockchip,px30-vpu", "rockchip,rk3399-vpu";
Hi Ezequiel, Am 26.06.21 um 02:47 schrieb Ezequiel Garcia: > Hey Dafna, > > Thanks a lot for reviewing this. > > On Fri, 2021-06-25 at 12:21 +0300, Dafna Hirschfeld wrote: >> Hi, >> >> On 24.06.21 21:26, Ezequiel Garcia wrote: >>> From: Paul Kocialkowski<paul.kocialkowski@bootlin.com> >>> >>> The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) >>> and an encoder (VEPU2). >>> >>> Signed-off-by: Paul Kocialkowski<paul.kocialkowski@bootlin.com> >>> Signed-off-by: Ezequiel Garcia<ezequiel@collabora.com> >>> --- >>> Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml >>> index b88172a59de7..3b9c5aa91fcc 100644 >>> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml >>> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml >>> @@ -28,6 +28,9 @@ properties: >>> - items: >>> - const: rockchip,rk3228-vpu >>> - const: rockchip,rk3399-vpu >>> + - items: >>> + - const: rockchip,px30-vpu >>> + - const: rockchip,rk3399-vpu >> This rk3399 compatible is already mentioned in the last 'items' list, should we add it again? >> > What we are mandating here is that "rockchip,px30-vpu" can only be used > with "rockchip,rk3399-vpu". > > I.e.: > > compatible = "rockchip,px30-vpu", "rockchip,rk3399-vpu"; > So why not making the already existing to: - items: - enum: - rockchip,px30-vpu - rockchip,rk3228-vpu - const: rockchip,rk3399-vpu Alex
diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml index b88172a59de7..3b9c5aa91fcc 100644 --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml @@ -28,6 +28,9 @@ properties: - items: - const: rockchip,rk3228-vpu - const: rockchip,rk3399-vpu + - items: + - const: rockchip,px30-vpu + - const: rockchip,rk3399-vpu reg: maxItems: 1