[1/2] dt-bindings: adv7180: Introduce adv,adv7182-force-bt656-4
Commit Message
Captured NTSC video would be out of sync when using the adv7280 with
the BT.656-4 protocol. Certain registers (0x04, 0x31, 0xE6) need to
be configured properly to ensure BT.656-4 compatibility.
Introduce the 'adv,adv7182-force-bt656-4' property to allow the ADV7280
behavior to be consistent with the ADV7180, where BT.656-4 timing
is used.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Thu, May 27, 2021 at 02:32:08PM -0300, Fabio Estevam wrote:
> Captured NTSC video would be out of sync when using the adv7280 with
> the BT.656-4 protocol. Certain registers (0x04, 0x31, 0xE6) need to
> be configured properly to ensure BT.656-4 compatibility.
>
> Introduce the 'adv,adv7182-force-bt656-4' property to allow the ADV7280
> behavior to be consistent with the ADV7180, where BT.656-4 timing
> is used.
I'm confused by the part numbers. 7182 or 7280? In any case, I'd just
drop the part number from the property name.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
> index bcfd93739b4f..83e47b0c9fa2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
> @@ -35,6 +35,11 @@ properties:
> powerdown-gpios:
> maxItems: 1
>
> + adv,adv7182-force-bt656-4:
> + description:
> + Indicates that ADV7182 should output a BT.656-4 compatible stream.
> + type: boolean
> +
> port:
> $ref: /schemas/graph.yaml#/properties/port
>
> --
> 2.25.1
Hi Rob,
On Fri, Jun 4, 2021 at 5:54 PM Rob Herring <robh@kernel.org> wrote:
> I'm confused by the part numbers. 7182 or 7280? In any case, I'd just
> drop the part number from the property name.
Yes, dropping the part number from the property name is less confusing.
Will do as suggested in v2.
Thanks
@@ -35,6 +35,11 @@ properties:
powerdown-gpios:
maxItems: 1
+ adv,adv7182-force-bt656-4:
+ description:
+ Indicates that ADV7182 should output a BT.656-4 compatible stream.
+ type: boolean
+
port:
$ref: /schemas/graph.yaml#/properties/port