[v1,2/4] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor
Commit Message
Document the bindings used for the SK Hynix Hi-846 CMOS camera driver.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
.../bindings/media/i2c/hynix,hi846.yaml | 99 +++++++++++++++++++
1 file changed, 99 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
Comments
On Thu, 27 May 2021 11:12:19 +0200, Martin Kepplinger wrote:
> Document the bindings used for the SK Hynix Hi-846 CMOS camera driver.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> .../bindings/media/i2c/hynix,hi846.yaml | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml:51:15: [warning] wrong indentation: expected 16 but found 14 (indentation)
./Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml:52:17: [warning] wrong indentation: expected 18 but found 16 (indentation)
./Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml:57:17: [warning] wrong indentation: expected 18 but found 16 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml: properties:port:properties:endpoint:properties:data-lanes: [{'oneOf': [{'items': [{'const': 1}, {'const': 2}, {'const': 3}, {'const': 4}]}, {'items': [{'const': 1}, {'const': 2}]}]}] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml: ignoring, error in schema: properties: port: properties: endpoint: properties: data-lanes
warning: no schema found in file: ./Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:0:0: /example-0/i2c/camera@20: failed to match any schema with compatible: ['hynix,hi846']
See https://patchwork.ozlabs.org/patch/1484524
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
new file mode 100644
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/hynix,hi846.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SK Hynix Hi-846 1/4" 8M Pixel MIPI CSI-2 sensor
+
+maintainers:
+ - Martin Kepplinger <martin.kepplinger@puri.sm>
+
+description: |-
+ The Hi-846 is a raw image sensor with an MIPI CSI-2 image data
+ interface and CCI (I2C compatible) control bus. The output format
+ is 10bit Bayer.
+
+properties:
+ compatible:
+ const: hynix,hi846
+
+ reg:
+ description: I2C device address.
+ maxItems: 1
+
+ clocks:
+ description: Reference to the mclk clock.
+ maxItems: 1
+
+ clock-names:
+ const: mclk
+
+ rst-gpios:
+ description: Reference to the GPIO connected to the reset pin. Active low.
+ maxItems: 1
+
+ vdd-supply:
+ description: Definition of the regulator used as 1.8V digital power supply.
+
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+ additionalProperties: false
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ - oneOf:
+ - items:
+ - const: 1
+ - const: 2
+ - const: 3
+ - const: 4
+ - items:
+ - const: 1
+ - const: 2
+
+ required:
+ - data-lanes
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - rst-gpios
+ - vdd-supply
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hi846: camera@20 {
+ compatible = "hynix,hi846";
+ reg = <0x20>;
+ clocks = <&clk>;
+ clock-names = "mclk";
+ vdd-supply = <®_camera_pwr_en>; /* 1.8v */
+ rst-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+
+ port {
+ camera_out: endpoint {
+ remote-endpoint = <&csi1_ep1>;
+ data-lanes = <1 2>;
+ };
+ };
+ };
+ };
+
+...