[media-ctl,2/3] Just include kernel headers

  We shouldn't require full kernel source for this.

Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
---
 Makefile |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
  

Hi Sergio,

On Wednesday 14 July 2010 18:17:25 Sergio Aguirre wrote:
> We shouldn't require full kernel source for this.

That's right in theory, but I then get

$ make KDIR=/home/laurent/src/arm/kernel/
arm-none-linux-gnueabi-gcc -O2 -Wall -fpic -I. -I/home/laurent/src/arm/kernel//include    -c -o media.o media.c
In file included from /opt/cs/arm-2009q1/bin/../arm-none-linux-gnueabi/libc/usr/include/asm/types.h:4,
                 from /home/laurent/src/arm/kernel//include/linux/types.h:4,
                 from /home/laurent/src/arm/kernel//include/linux/videodev2.h:66,
                 from media.c:31:
/home/laurent/src/arm/kernel//include/asm-generic/int-ll64.h:11:29: error: asm/bitsperlong.h: No such file or directory
make: *** [media.o] Error 1

when building against a kernel tree.

> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> ---
>  Makefile |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index bf4cf55..300ed7e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,11 +1,9 @@
> -SRCARCH ?= arm
>  CROSS_COMPILE ?= arm-none-linux-gnueabi-
> -KDIR ?= /usr/src/linux
> +HDIR ?= /usr/include
> 
> -KINC := -I$(KDIR)/include -I$(KDIR)/arch/$(SRCARCH)/include
>  CC   := $(CROSS_COMPILE)gcc
> 
> -CFLAGS = -O2 -Wall -fpic -I. $(KINC)
> +CFLAGS = -O2 -Wall -fpic -I$(HDIR)
>  OBJS = media.o main.o options.o subdev.o
> 
>  all: media-ctl
  

Hi Laurent,

> -----Original Message-----
> From: Laurent Pinchart [mailto:laurent.pinchart@ideasonboard.com]
> Sent: Friday, July 30, 2010 8:45 AM
> To: Aguirre, Sergio
> Cc: linux-media@vger.kernel.org
> Subject: Re: [media-ctl PATCH 2/3] Just include kernel headers
> 
> Hi Sergio,
> 
> On Wednesday 14 July 2010 18:17:25 Sergio Aguirre wrote:
> > We shouldn't require full kernel source for this.
> 
> That's right in theory, but I then get
> 
> $ make KDIR=/home/laurent/src/arm/kernel/
> arm-none-linux-gnueabi-gcc -O2 -Wall -fpic -I. -
> I/home/laurent/src/arm/kernel//include    -c -o media.o media.c
> In file included from /opt/cs/arm-2009q1/bin/../arm-none-linux-
> gnueabi/libc/usr/include/asm/types.h:4,
>                  from
> /home/laurent/src/arm/kernel//include/linux/types.h:4,
>                  from
> /home/laurent/src/arm/kernel//include/linux/videodev2.h:66,
>                  from media.c:31:
> /home/laurent/src/arm/kernel//include/asm-generic/int-ll64.h:11:29: error:
> asm/bitsperlong.h: No such file or directory
> make: *** [media.o] Error 1
> 
> when building against a kernel tree.

KDIR doesn't exist anymore.

By the result of your log, I don't see how that value got passed into the makefile... Are you sure you applied the patch correctly?

Regards,
Sergio

> 
> > Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> > ---
> >  Makefile |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index bf4cf55..300ed7e 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1,11 +1,9 @@
> > -SRCARCH ?= arm
> >  CROSS_COMPILE ?= arm-none-linux-gnueabi-
> > -KDIR ?= /usr/src/linux
> > +HDIR ?= /usr/include
> >
> > -KINC := -I$(KDIR)/include -I$(KDIR)/arch/$(SRCARCH)/include
> >  CC   := $(CROSS_COMPILE)gcc
> >
> > -CFLAGS = -O2 -Wall -fpic -I. $(KINC)
> > +CFLAGS = -O2 -Wall -fpic -I$(HDIR)
> >  OBJS = media.o main.o options.o subdev.o
> >
> >  all: media-ctl
> 
> --
> Regards,
> 
> Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Hi Sergio,

On Friday 30 July 2010 16:10:08 Aguirre, Sergio wrote:
> On Friday 30 July 2010 8:45 AM Laurent Pinchart wrote:
> > On Wednesday 14 July 2010 18:17:25 Sergio Aguirre wrote:
> > > We shouldn't require full kernel source for this.
> > 
> > That's right in theory, but I then get
> > 
> > $ make KDIR=/home/laurent/src/arm/kernel/
> > arm-none-linux-gnueabi-gcc -O2 -Wall -fpic -I. -
> > I/home/laurent/src/arm/kernel//include    -c -o media.o media.c
> > In file included from /opt/cs/arm-2009q1/bin/../arm-none-linux-
> > gnueabi/libc/usr/include/asm/types.h:4,
> >                  from
> > /home/laurent/src/arm/kernel//include/linux/types.h:4,
> >                  from
> > /home/laurent/src/arm/kernel//include/linux/videodev2.h:66,
> >                  from media.c:31:
> > /home/laurent/src/arm/kernel//include/asm-generic/int-ll64.h:11:29:
> > error: asm/bitsperlong.h: No such file or directory
> > make: *** [media.o] Error 1
> > 
> > when building against a kernel tree.
> 
> KDIR doesn't exist anymore.
> 
> By the result of your log, I don't see how that value got passed into the
> makefile... Are you sure you applied the patch correctly?

I haven't, I've just removed the arch include dir from KDIR in the Makefile. 
The end result is the same.
  

Hi Laurent,

> -----Original Message-----
> From: Laurent Pinchart [mailto:laurent.pinchart@ideasonboard.com]
> Sent: Friday, July 30, 2010 9:24 AM
> To: Aguirre, Sergio
> Cc: linux-media@vger.kernel.org
> Subject: Re: [media-ctl PATCH 2/3] Just include kernel headers
> 
> Hi Sergio,
> 
> On Friday 30 July 2010 16:10:08 Aguirre, Sergio wrote:
> > On Friday 30 July 2010 8:45 AM Laurent Pinchart wrote:
> > > On Wednesday 14 July 2010 18:17:25 Sergio Aguirre wrote:
> > > > We shouldn't require full kernel source for this.
> > >
> > > That's right in theory, but I then get
> > >
> > > $ make KDIR=/home/laurent/src/arm/kernel/
> > > arm-none-linux-gnueabi-gcc -O2 -Wall -fpic -I. -
> > > I/home/laurent/src/arm/kernel//include    -c -o media.o media.c
> > > In file included from /opt/cs/arm-2009q1/bin/../arm-none-linux-
> > > gnueabi/libc/usr/include/asm/types.h:4,
> > >                  from
> > > /home/laurent/src/arm/kernel//include/linux/types.h:4,
> > >                  from
> > > /home/laurent/src/arm/kernel//include/linux/videodev2.h:66,
> > >                  from media.c:31:
> > > /home/laurent/src/arm/kernel//include/asm-generic/int-ll64.h:11:29:
> > > error: asm/bitsperlong.h: No such file or directory
> > > make: *** [media.o] Error 1
> > >
> > > when building against a kernel tree.
> >
> > KDIR doesn't exist anymore.
> >
> > By the result of your log, I don't see how that value got passed into
> the
> > makefile... Are you sure you applied the patch correctly?
> 
> I haven't, I've just removed the arch include dir from KDIR in the
> Makefile.
> The end result is the same.

Hmm..

I think this is expected, since the kernel headers folder generated with

make ARCH=arm INSTALL_HDR_PATH=<your-fs-root> headers_install

Is not the same as just reading the kernel source include folder.

Some #ifdef get resolved depending on the arch, and the headers are
"rebuilt". See : Documentation/make/headers_install.txt

So, I guess it's not as simple as just removing the arch include folder.

Regards,
Sergio

> 
> --
> Regards,
> 
> Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Hi Sergio,

On Friday 30 July 2010 16:47:22 Aguirre, Sergio wrote:
> > > On Friday 30 July 2010 9:24 AM Laurent Pinchart wrote:
> > On Friday 30 July 2010 16:10:08 Aguirre, Sergio wrote:
> > > On Friday 30 July 2010 8:45 AM Laurent Pinchart wrote:
> > > > On Wednesday 14 July 2010 18:17:25 Sergio Aguirre wrote:
> > > > > We shouldn't require full kernel source for this.
> > > > 
> > > > That's right in theory, but I then get
> > > > 
> > > > $ make KDIR=/home/laurent/src/arm/kernel/
> > > > arm-none-linux-gnueabi-gcc -O2 -Wall -fpic -I. -
> > > > I/home/laurent/src/arm/kernel//include    -c -o media.o media.c
> > > > In file included from /opt/cs/arm-2009q1/bin/../arm-none-linux-
> > > > gnueabi/libc/usr/include/asm/types.h:4,
> > > >                  from
> > > > /home/laurent/src/arm/kernel//include/linux/types.h:4,
> > > >                  from
> > > > /home/laurent/src/arm/kernel//include/linux/videodev2.h:66,
> > > >                  from media.c:31:
> > > > /home/laurent/src/arm/kernel//include/asm-generic/int-ll64.h:11:29:
> > > > error: asm/bitsperlong.h: No such file or directory
> > > > make: *** [media.o] Error 1
> > > > 
> > > > when building against a kernel tree.
> > > 
> > > KDIR doesn't exist anymore.
> > > 
> > > By the result of your log, I don't see how that value got passed into
> > > the makefile... Are you sure you applied the patch correctly?
> > 
> > I haven't, I've just removed the arch include dir from KDIR in the
> > Makefile. The end result is the same.
> 
> Hmm..
> 
> I think this is expected, since the kernel headers folder generated with
> 
> make ARCH=arm INSTALL_HDR_PATH=<your-fs-root> headers_install
> 
> Is not the same as just reading the kernel source include folder.
> 
> Some #ifdef get resolved depending on the arch, and the headers are
> "rebuilt". See : Documentation/make/headers_install.txt
> 
> So, I guess it's not as simple as just removing the arch include folder.

Ideally the application should be built against installed kernel headers, bug 
given the early stage of development of the media controller, I expect most 
people to build it against a kernel tree. I would like to keep the Makefile 
as-is for now, and change it when the media controller patches will reach the 
mainline kernel.
  

Hi Laurent,

> -----Original Message-----
> From: Laurent Pinchart [mailto:laurent.pinchart@ideasonboard.com]
> Sent: Friday, July 30, 2010 10:40 AM
> To: Aguirre, Sergio
> Cc: linux-media@vger.kernel.org
> Subject: Re: [media-ctl PATCH 2/3] Just include kernel headers
> 
> Hi Sergio,

<snip>

> 
> Ideally the application should be built against installed kernel headers,
> bug
> given the early stage of development of the media controller, I expect
> most
> people to build it against a kernel tree. I would like to keep the
> Makefile
> as-is for now, and change it when the media controller patches will reach
> the
> mainline kernel.

Ok, understood. Not a problem.

Regards,
Sergio

> 
> --
> Regards,
> 
> Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html