media: dt-bindings: media: renesas,drif: Fix fck definition

Message ID 20210408202436.3706-1-fabrizio.castro.jz@renesas.com (mailing list archive)
State Superseded, archived
Delegated to: Laurent Pinchart
Headers
Series media: dt-bindings: media: renesas,drif: Fix fck definition |

Commit Message

Fabrizio Castro April 8, 2021, 8:24 p.m. UTC
  dt_binding_check reports the below error with the latest schema:

Documentation/devicetree/bindings/media/renesas,drif.yaml:
  properties:clock-names:maxItems: False schema does not allow 1
Documentation/devicetree/bindings/media/renesas,drif.yaml:
  ignoring, error in schema: properties: clock-names: maxItems

This patch fixes the problem.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
 Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
  

Comments

Rob Herring (Arm) April 9, 2021, 6:54 p.m. UTC | #1
On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> dt_binding_check reports the below error with the latest schema:
> 
> Documentation/devicetree/bindings/media/renesas,drif.yaml:
>   properties:clock-names:maxItems: False schema does not allow 1
> Documentation/devicetree/bindings/media/renesas,drif.yaml:
>   ignoring, error in schema: properties: clock-names: maxItems
> 
> This patch fixes the problem.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>  Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
  
Rob Herring April 27, 2021, 6:02 p.m. UTC | #2
On Fri, Apr 9, 2021 at 1:54 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > dt_binding_check reports the below error with the latest schema:
> >
> > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> >   properties:clock-names:maxItems: False schema does not allow 1
> > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> >   ignoring, error in schema: properties: clock-names: maxItems
> >
> > This patch fixes the problem.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > ---
> >  Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Still failing in linux-next...

Rob
  
Laurent Pinchart April 27, 2021, 8:08 p.m. UTC | #3
Hi Rob,

On Tue, Apr 27, 2021 at 01:02:57PM -0500, Rob Herring wrote:
> On Fri, Apr 9, 2021 at 1:54 PM Rob Herring wrote:
> > On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > > dt_binding_check reports the below error with the latest schema:
> > >
> > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > >   properties:clock-names:maxItems: False schema does not allow 1
> > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > >   ignoring, error in schema: properties: clock-names: maxItems
> > >
> > > This patch fixes the problem.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > > ---
> > >  Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Still failing in linux-next...

Sorry, as a standalone fix, I incorrectly thought you'd merge it.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree. I'll send a pull request to linux-media when the
merge window closes.
  
Rob Herring June 4, 2021, 7:38 p.m. UTC | #4
On Tue, Apr 27, 2021 at 3:08 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> On Tue, Apr 27, 2021 at 01:02:57PM -0500, Rob Herring wrote:
> > On Fri, Apr 9, 2021 at 1:54 PM Rob Herring wrote:
> > > On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > > > dt_binding_check reports the below error with the latest schema:
> > > >
> > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > >   properties:clock-names:maxItems: False schema does not allow 1
> > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > >   ignoring, error in schema: properties: clock-names: maxItems
> > > >
> > > > This patch fixes the problem.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > >
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > Still failing in linux-next...
>
> Sorry, as a standalone fix, I incorrectly thought you'd merge it.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree. I'll send a pull request to linux-media when the
> merge window closes.

Still failing in linux-next. It's also a failure in Linus' tree, so it
needs to go in as a fix.

Rob
  
Laurent Pinchart June 4, 2021, 10:05 p.m. UTC | #5
Hi Rob,

On Fri, Jun 04, 2021 at 02:38:36PM -0500, Rob Herring wrote:
> On Tue, Apr 27, 2021 at 3:08 PM Laurent Pinchart wrote:
> > On Tue, Apr 27, 2021 at 01:02:57PM -0500, Rob Herring wrote:
> > > On Fri, Apr 9, 2021 at 1:54 PM Rob Herring wrote:
> > > > On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > > > > dt_binding_check reports the below error with the latest schema:
> > > > >
> > > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > > >   properties:clock-names:maxItems: False schema does not allow 1
> > > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > > >   ignoring, error in schema: properties: clock-names: maxItems
> > > > >
> > > > > This patch fixes the problem.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> > > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > > >
> > > >
> > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > >
> > > Still failing in linux-next...
> >
> > Sorry, as a standalone fix, I incorrectly thought you'd merge it.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > and applied to my tree. I'll send a pull request to linux-media when the
> > merge window closes.
> 
> Still failing in linux-next. It's also a failure in Linus' tree, so it
> needs to go in as a fix.

Sorry, been overwhelmed. Feel free to take the patch through your tree
as a fix.
  
Rob Herring (Arm) June 9, 2021, 1:04 a.m. UTC | #6
On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> dt_binding_check reports the below error with the latest schema:
> 
> Documentation/devicetree/bindings/media/renesas,drif.yaml:
>   properties:clock-names:maxItems: False schema does not allow 1
> Documentation/devicetree/bindings/media/renesas,drif.yaml:
>   ignoring, error in schema: properties: clock-names: maxItems
> 
> This patch fixes the problem.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>  Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Applied, thanks!
  

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
index f1bdaeab4053..e28396f35ee6 100644
--- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -67,9 +67,7 @@  properties:
     maxItems: 1
 
   clock-names:
-    maxItems: 1
-    items:
-      - const: fck
+    const: fck
 
   resets:
     maxItems: 1