mbox series

[RFC,0/4] use v4l2_get_link_freq() in CSI receiver drivers

Message ID 20210303180817.12285-1-andrey.konovalov@linaro.org (mailing list archive)
Headers
Series use v4l2_get_link_freq() in CSI receiver drivers |

Message

Andrey Konovalov March 3, 2021, 6:08 p.m. UTC 
  This patchset continues the work discussed in the "[RFC] Repurpose
V4L2_CID_PIXEL_RATE for the sampling rate in the pixel array" thread [1].

This patchset follows up the patchset for camss driver [2] of the same
purpose, and makes the rest of the receiver drivers in drivers/media
and drivers/staging/media to use v4l2_get_link_freq() instead of
V4L2_CID_PIXEL_RATE.

This patchset has been build tested only, as I don't have access to the
hardware. Most of the changes are fairly straightforward except for the
ones in the omap4iss driver. I would appreciate if people with better
knowledge of the omap4iss driver reviewed the last patch in this series,
and checked if I got the logic in the driver right.

[1] https://www.spinics.net/lists/linux-media/msg183183.html
[2] "[PATCH v3 0/3] media: qcom: camss: V4L2_CID_PIXEL_RATE/LINK_FREQ fixes"
    posted earlier today

Comments

Sakari Ailus March 5, 2021, 3:42 p.m. UTC | #1 
On Wed, Mar 03, 2021 at 09:08:13PM +0300, Andrey Konovalov wrote:
> This patchset continues the work discussed in the "[RFC] Repurpose
> V4L2_CID_PIXEL_RATE for the sampling rate in the pixel array" thread [1].
> 
> This patchset follows up the patchset for camss driver [2] of the same
> purpose, and makes the rest of the receiver drivers in drivers/media
> and drivers/staging/media to use v4l2_get_link_freq() instead of
> V4L2_CID_PIXEL_RATE.
> 
> This patchset has been build tested only, as I don't have access to the
> hardware. Most of the changes are fairly straightforward except for the
> ones in the omap4iss driver. I would appreciate if people with better
> knowledge of the omap4iss driver reviewed the last patch in this series,
> and checked if I got the logic in the driver right.

To me this looks good, hopefully people could test the set, too.