| Message ID | 1276547208-26569-9-git-send-email-justinmattock@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Mon, 14 Jun 2010 20:28:19 +0000 Received: from bombadil.infradead.org [18.85.46.34] by localhost with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Tue, 15 Jun 2010 07:59:46 +0300 (EEST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OOGGZ-0004yF-EM; Mon, 14 Jun 2010 20:28:19 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755994Ab0FNU1K (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 14 Jun 2010 16:27:10 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:52855 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755821Ab0FNU1F (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 14 Jun 2010 16:27:05 -0400 Received: by mail-pv0-f174.google.com with SMTP id 16so3067678pvg.19 for <multiple recipients>; Mon, 14 Jun 2010 13:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=5fjEbiM0S8vS87iuoU1+lxigqp1GyGa9IhHtF02fslE=; b=OgpeNAavGLjelsCy/W6G+7yDuegcKqTG5FPJzhbjsYPiP6RuA92uk5fzbC8c5GDKzq xC2BqeIsbDmRYCPIKANqoCVrJ8DvIG0oDmrqU/3tPV1xIr1TvtLZm4YOk/xcdvo/YUex YEc23vEYsD3MTMblpP+zBFjJJdzgKx7cLt4SM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=Qf+t5siyMRBNFMJZM0ryEQyKt6iz5V9IoN8bVnIihDMNvTAumvJtZbFRkFW9y9o89+ fbAyc1nfZQjZJUQsOfxJzAC5W1ULpE7DR972a/ezOIV3D2BvOrDdS4XPn2IKhBiF7O/L SpACNc0oxdNqZPdzMIW8Zx5xNaoisyraYPMdc= Received: by 10.115.66.34 with SMTP id t34mr4933979wak.6.1276547225184; Mon, 14 Jun 2010 13:27:05 -0700 (PDT) Received: from localhost.localdomain ([76.91.45.220]) by mx.google.com with ESMTPS id r20sm58982854wam.5.2010.06.14.13.27.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Jun 2010 13:27:04 -0700 (PDT) From: "Justin P. Mattock" <justinmattock@gmail.com> To: linux-kernel@vger.kernel.org Cc: reiserfs-devel@vger.kernel.org, linux-bluetooth@vger.kernel.org, clemens@ladisch.de, debora@linux.vnet.ibm.com, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org, "Justin P. Mattock" <justinmattock@gmail.com> Subject: [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' set but not used Date: Mon, 14 Jun 2010 13:26:48 -0700 Message-Id: <1276547208-26569-9-git-send-email-justinmattock@gmail.com> X-Mailer: git-send-email 1.7.1.rc1.21.gf3bd6 In-Reply-To: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> References: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Justin P. Mattock
June 14, 2010, 8:26 p.m. UTC
not sure if this is correct or not for
fixing this warning:
CC [M] drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/media/common/tuners/tuner-simple.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
Comments
Em 14-06-2010 23:26, Justin P. Mattock escreveu: > not sure if this is correct or not for > fixing this warning: > CC [M] drivers/media/common/tuners/tuner-simple.o > drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq': > drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- > drivers/media/common/tuners/tuner-simple.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c > index 8abbcc5..4465b99 100644 > --- a/drivers/media/common/tuners/tuner-simple.c > +++ b/drivers/media/common/tuners/tuner-simple.c > @@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe, > struct tuner_simple_priv *priv = fe->tuner_priv; > u8 config, cb; > u16 div; > - struct tunertype *tun; > u8 buffer[4]; > int rc, IFPCoff, i; > enum param_type desired_type; > struct tuner_params *t_params; > > - tun = priv->tun; > - > + Why are you adding an extra blank line here? Except for that, the patch looks sane. > /* IFPCoff = Video Intermediate Frequency - Vif: > 940 =16*58.75 NTSC/J (Japan) > 732 =16*45.75 M/N STD -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote: > > > Em 14-06-2010 23:26, Justin P. Mattock escreveu: >> not sure if this is correct or not for >> fixing this warning: >> CC [M] drivers/media/common/tuners/tuner-simple.o >> drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq': >> drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used >> >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> >> >> --- >> drivers/media/common/tuners/tuner-simple.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c >> index 8abbcc5..4465b99 100644 >> --- a/drivers/media/common/tuners/tuner-simple.c >> +++ b/drivers/media/common/tuners/tuner-simple.c >> @@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe, >> struct tuner_simple_priv *priv = fe->tuner_priv; >> u8 config, cb; >> u16 div; >> - struct tunertype *tun; >> u8 buffer[4]; >> int rc, IFPCoff, i; >> enum param_type desired_type; >> struct tuner_params *t_params; >> >> - tun = priv->tun; >> - >> + > Why are you adding an extra blank line here? Except for that, the patch > looks sane. > I think I was doing something wrong when creating these patches. i.g. I just hightlight the code then move the cursor highlight all the way to the right before pressing "x". normally would be o.k. but for some reason seems to be doing this. found if I highlight left to ; (or the end of the code I want to delete) then git commit creates the patch properly. >> /* IFPCoff = Video Intermediate Frequency - Vif: >> 940 =16*58.75 NTSC/J (Japan) >> 732 =16*45.75 M/N STD > > I'll resend this. Thanks for having a look. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote: > > > Em 14-06-2010 23:26, Justin P. Mattock escreveu: >> not sure if this is correct or not for >> fixing this warning: >> CC [M] drivers/media/common/tuners/tuner-simple.o >> drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq': >> drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used >> >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> >> >> --- >> drivers/media/common/tuners/tuner-simple.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c >> index 8abbcc5..4465b99 100644 >> --- a/drivers/media/common/tuners/tuner-simple.c >> +++ b/drivers/media/common/tuners/tuner-simple.c >> @@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe, >> struct tuner_simple_priv *priv = fe->tuner_priv; >> u8 config, cb; >> u16 div; >> - struct tunertype *tun; >> u8 buffer[4]; >> int rc, IFPCoff, i; >> enum param_type desired_type; >> struct tuner_params *t_params; >> >> - tun = priv->tun; >> - >> + > Why are you adding an extra blank line here? Except for that, the patch > looks sane. > >> /* IFPCoff = Video Intermediate Frequency - Vif: >> 940 =16*58.75 NTSC/J (Japan) >> 732 =16*45.75 M/N STD > > o.k. resent this.. I ended up doing a git reset do make sure things dont get funky etc.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c index 8abbcc5..4465b99 100644 --- a/drivers/media/common/tuners/tuner-simple.c +++ b/drivers/media/common/tuners/tuner-simple.c @@ -545,14 +545,12 @@ static int simple_set_tv_freq(struct dvb_frontend *fe, struct tuner_simple_priv *priv = fe->tuner_priv; u8 config, cb; u16 div; - struct tunertype *tun; u8 buffer[4]; int rc, IFPCoff, i; enum param_type desired_type; struct tuner_params *t_params; - tun = priv->tun; - + /* IFPCoff = Video Intermediate Frequency - Vif: 940 =16*58.75 NTSC/J (Japan) 732 =16*45.75 M/N STD