Message ID | 20210114233345.160223-1-heiko@sntech.de (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1l0C8y-00FPWO-Em; Thu, 14 Jan 2021 23:35:09 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730847AbhANXev (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 14 Jan 2021 18:34:51 -0500 Received: from gloria.sntech.de ([185.11.138.130]:53476 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730612AbhANXev (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 14 Jan 2021 18:34:51 -0500 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=phil.sntech) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <heiko@sntech.de>) id 1l0C81-0001lf-4a; Fri, 15 Jan 2021 00:34:09 +0100 From: Heiko Stuebner <heiko@sntech.de> To: dafna.hirschfeld@collabora.com, helen.koike@collabora.com, linux-media@vger.kernel.org, mchehab@kernel.org, Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl Cc: linux-rockchip@lists.infradead.org, ezequiel@collabora.com, christoph.muellner@theobroma-systems.com, heiko@sntech.de, tfiga@chromium.org Subject: [PATCH v2 0/2] Fix the rkisp1 userspace API for later IP versions Date: Fri, 15 Jan 2021 00:33:40 +0100 Message-Id: <20210114233345.160223-1-heiko@sntech.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
Fix the rkisp1 userspace API for later IP versions
|
|
Message
Heiko Stuebner
Jan. 14, 2021, 11:33 p.m. UTC
This NEEDs to go into 5.11 while we can still adapt the uapi during its RC-cycle. When looking into supporting the rkisp1 of the px30 I noticed that some fields got bigger in the uapi, caused by bigger number of samples for example for histograms or gamma values. The rkisp1 was destaged with 5.11-rc1 so we have still time during the 5.11 cycle to fix that without big hassles. This was discussed previously in a mail [0] and a rfc series [1] and this two-part series now splits out the important parts that really should become part of a 5.11-rc and thus the final 5.11. changes since v1: - drop duplicate isp_ver storage, hw_revision is enough - document multiple maximum sizes in uapi - document usage of hw_revision field - zero fields transmitted to userspace before adding data - use _V10 field sizes when filling fields, as there is only v10 for now changes since rfc: - move rkisp1_version enum into uapo - show version in media-api hw_revision - introduce constants for versions and make max use the biggest [0] http://lore.kernel.org/r/3342088.iIbC2pHGDl@diego [1] https://lore.kernel.org/r/20210108193311.3423236-2-heiko@sntech.de Heiko Stuebner (2): media: rockchip: rkisp1: carry ip version information media: rockchip: rkisp1: extend uapi array sizes Documentation/admin-guide/media/rkisp1.rst | 15 +++++++ .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++++---- .../platform/rockchip/rkisp1/rkisp1-params.c | 2 +- .../platform/rockchip/rkisp1/rkisp1-stats.c | 10 ++++- include/uapi/linux/rkisp1-config.h | 43 ++++++++++++++++--- 5 files changed, 74 insertions(+), 17 deletions(-)
Comments
This NEEDs to go into 5.11 while we can still adapt the uapi during its RC-cycle. When looking into supporting the rkisp1 of the px30 I noticed that some fields got bigger in the uapi, caused by bigger number of samples for example for histograms or gamma values. The rkisp1 was destaged with 5.11-rc1 so we have still time during the 5.11 cycle to fix that without big hassles. This was discussed previously in a mail [0] and a rfc series [1] and this two-part series now splits out the important parts that really should become part of a 5.11-rc and thus the final 5.11. [0] http://lore.kernel.org/r/3342088.iIbC2pHGDl@diego [1] https://lore.kernel.org/r/20210108193311.3423236-2-heiko@sntech.de Heiko Stuebner (2): media: rockchip: rkisp1: carry ip version information media: rockchip: rkisp1: extend uapi array sizes .../platform/rockchip/rkisp1/rkisp1-common.h | 1 + .../platform/rockchip/rkisp1/rkisp1-dev.c | 22 +++++++++------- include/uapi/linux/rkisp1-config.h | 25 ++++++++++++++++--- 3 files changed, 35 insertions(+), 13 deletions(-)
Hi, please only look at the patches marked "v2" of course, I somehow made git-send-email also grab the old v1 patches from a subdir by accident. Thanks Heiko Am Freitag, 15. Januar 2021, 00:33:43 CET schrieb Heiko Stuebner: > This NEEDs to go into 5.11 while we can still adapt the uapi > during its RC-cycle. > > > When looking into supporting the rkisp1 of the px30 I noticed that > some fields got bigger in the uapi, caused by bigger number of samples > for example for histograms or gamma values. > > The rkisp1 was destaged with 5.11-rc1 so we have still time during > the 5.11 cycle to fix that without big hassles. > > This was discussed previously in a mail [0] and a rfc series [1] > and this two-part series now splits out the important parts that > really should become part of a 5.11-rc and thus the final 5.11. > > > [0] http://lore.kernel.org/r/3342088.iIbC2pHGDl@diego > [1] https://lore.kernel.org/r/20210108193311.3423236-2-heiko@sntech.de > > Heiko Stuebner (2): > media: rockchip: rkisp1: carry ip version information > media: rockchip: rkisp1: extend uapi array sizes > > .../platform/rockchip/rkisp1/rkisp1-common.h | 1 + > .../platform/rockchip/rkisp1/rkisp1-dev.c | 22 +++++++++------- > include/uapi/linux/rkisp1-config.h | 25 ++++++++++++++++--- > 3 files changed, 35 insertions(+), 13 deletions(-) > >