Message ID | 1272380899-30398-1-git-send-email-saaguirre@ti.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Tue, 27 Apr 2010 15:03:19 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for <mchehab@localhost> (single-drop); Tue, 27 Apr 2010 12:07:21 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O6mJj-0000Yg-B2; Tue, 27 Apr 2010 15:03:19 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157Ab0D0PDR (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Tue, 27 Apr 2010 11:03:17 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:38184 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254Ab0D0PDQ (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 27 Apr 2010 11:03:16 -0400 Received: from dlep36.itg.ti.com ([157.170.170.91]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id o3RF3CFn005673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 27 Apr 2010 10:03:12 -0500 Received: from legion.dal.design.ti.com (localhost [127.0.0.1]) by dlep36.itg.ti.com (8.13.8/8.13.8) with ESMTP id o3RF3BfC027874; Tue, 27 Apr 2010 10:03:12 -0500 (CDT) Received: from localhost (dtx0091359-ubuntu-1.am.dhcp.ti.com [128.247.78.240]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id o3RF3BZ28151; Tue, 27 Apr 2010 10:03:11 -0500 (CDT) From: Sergio Aguirre <saaguirre@ti.com> To: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com> Cc: linux-media@vger.kernel.org, Sergio Aguirre <saaguirre@ti.com> Subject: [PATCH] V4L: Events: Include slab.h explicitly Date: Tue, 27 Apr 2010 10:08:19 -0500 Message-Id: <1272380899-30398-1-git-send-email-saaguirre@ti.com> X-Mailer: git-send-email 1.6.3.3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Aguirre Rodriguez, Sergio Alberto
April 27, 2010, 3:08 p.m. UTC
After commit ID:
commit de380b55f92986c1a84198149cb71b7228d15fbd
Author: Tejun Heo <tj@kernel.org>
Date: Wed Mar 24 17:06:43 2010 +0900
percpu: don't implicitly include slab.h from percpu.h
slab.h include was not longer implicitly included with sched.h.
So, now we have to include slab.h explicitly.
Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
---
drivers/media/video/v4l2-event.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Comments
Sakari, This patch is based on your event branch: http://gitorious.org/omap3camera/mainline/commits/event And is required on latest kernel to compile v4l2-event.c, to make use of kmalloc and other slab.h functions/defines. Regards, Sergio > -----Original Message----- > From: Aguirre, Sergio > Sent: Tuesday, April 27, 2010 10:08 AM > To: Sakari Ailus > Cc: linux-media@vger.kernel.org; Aguirre, Sergio > Subject: [PATCH] V4L: Events: Include slab.h explicitly > > After commit ID: > > commit de380b55f92986c1a84198149cb71b7228d15fbd > Author: Tejun Heo <tj@kernel.org> > Date: Wed Mar 24 17:06:43 2010 +0900 > > percpu: don't implicitly include slab.h from percpu.h > > slab.h include was not longer implicitly included with sched.h. > > So, now we have to include slab.h explicitly. > > Signed-off-by: Sergio Aguirre <saaguirre@ti.com> > --- > drivers/media/video/v4l2-event.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2- > event.c > index aea4332..7f31cd2 100644 > --- a/drivers/media/video/v4l2-event.c > +++ b/drivers/media/video/v4l2-event.c > @@ -26,6 +26,7 @@ > #include <media/v4l2-fh.h> > #include <media/v4l2-event.h> > > +#include <linux/slab.h> > #include <linux/sched.h> > > int v4l2_event_init(struct v4l2_fh *fh) > -- > 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Aguirre, Sergio wrote: > Sakari, > > This patch is based on your event branch: > > http://gitorious.org/omap3camera/mainline/commits/event > > And is required on latest kernel to compile v4l2-event.c, to make use of kmalloc and other slab.h functions/defines. True. Sakari, Please, add this patch on your series before any Makefile entries that would try to compile the events interface (or just fold it to the patch that added v4l2-event.c). Cheers, Mauro. > Regards, > Sergio > >> -----Original Message----- >> From: Aguirre, Sergio >> Sent: Tuesday, April 27, 2010 10:08 AM >> To: Sakari Ailus >> Cc: linux-media@vger.kernel.org; Aguirre, Sergio >> Subject: [PATCH] V4L: Events: Include slab.h explicitly >> >> After commit ID: >> >> commit de380b55f92986c1a84198149cb71b7228d15fbd >> Author: Tejun Heo <tj@kernel.org> >> Date: Wed Mar 24 17:06:43 2010 +0900 >> >> percpu: don't implicitly include slab.h from percpu.h >> >> slab.h include was not longer implicitly included with sched.h. >> >> So, now we have to include slab.h explicitly. >> >> Signed-off-by: Sergio Aguirre <saaguirre@ti.com> >> --- >> drivers/media/video/v4l2-event.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2- >> event.c >> index aea4332..7f31cd2 100644 >> --- a/drivers/media/video/v4l2-event.c >> +++ b/drivers/media/video/v4l2-event.c >> @@ -26,6 +26,7 @@ >> #include <media/v4l2-fh.h> >> #include <media/v4l2-event.h> >> >> +#include <linux/slab.h> >> #include <linux/sched.h> >> >> int v4l2_event_init(struct v4l2_fh *fh) >> -- >> 1.6.3.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Mauro Carvalho Chehab wrote: > Aguirre, Sergio wrote: >> Sakari, >> >> This patch is based on your event branch: >> >> http://gitorious.org/omap3camera/mainline/commits/event >> >> And is required on latest kernel to compile v4l2-event.c, to make use of kmalloc and other slab.h functions/defines. > > > True. > > Sakari, > > Please, add this patch on your series before any Makefile entries that would try to compile > the events interface (or just fold it to the patch that added v4l2-event.c). Unfortunately the Makefile changes are in the same patch than the missing linux/slab.h.
Sakari Ailus wrote: > Mauro Carvalho Chehab wrote: >> Aguirre, Sergio wrote: >>> Sakari, >>> >>> This patch is based on your event branch: >>> >>> http://gitorious.org/omap3camera/mainline/commits/event >>> >>> And is required on latest kernel to compile v4l2-event.c, to make use of kmalloc and other slab.h functions/defines. >> >> True. >> >> Sakari, >> >> Please, add this patch on your series before any Makefile entries that would try to compile >> the events interface (or just fold it to the patch that added v4l2-event.c). > > Unfortunately the Makefile changes are in the same patch than the > missing linux/slab.h. > So, you'll need to fold his patch, or breaking the Makefile changes into another, otherwise, you'll break git bisect.
Hi Mauro, Mauro Carvalho Chehab wrote: > Sakari Ailus wrote: >> Mauro Carvalho Chehab wrote: >>> Aguirre, Sergio wrote: >>>> Sakari, >>>> >>>> This patch is based on your event branch: >>>> >>>> http://gitorious.org/omap3camera/mainline/commits/event >>>> >>>> And is required on latest kernel to compile v4l2-event.c, to make use of kmalloc and other slab.h functions/defines. >>> >>> True. >>> >>> Sakari, >>> >>> Please, add this patch on your series before any Makefile entries that would try to compile >>> the events interface (or just fold it to the patch that added v4l2-event.c). >> >> Unfortunately the Makefile changes are in the same patch than the >> missing linux/slab.h. >> > So, you'll need to fold his patch, or breaking the Makefile changes into another, otherwise, you'll > break git bisect. Did you receive my new pull request? It has this change included in the fourth patch. Regards,
Sergio Aguirre wrote: > After commit ID: > > commit de380b55f92986c1a84198149cb71b7228d15fbd > Author: Tejun Heo <tj@kernel.org> > Date: Wed Mar 24 17:06:43 2010 +0900 > > percpu: don't implicitly include slab.h from percpu.h > > slab.h include was not longer implicitly included with sched.h. > > So, now we have to include slab.h explicitly. > > Signed-off-by: Sergio Aguirre <saaguirre@ti.com> > --- > drivers/media/video/v4l2-event.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c > index aea4332..7f31cd2 100644 > --- a/drivers/media/video/v4l2-event.c > +++ b/drivers/media/video/v4l2-event.c > @@ -26,6 +26,7 @@ > #include <media/v4l2-fh.h> > #include <media/v4l2-event.h> > > +#include <linux/slab.h> > #include <linux/sched.h> > > int v4l2_event_init(struct v4l2_fh *fh) Thanks for the patch, Sergio! I was going to say that I'll send a new pull request but apparently forgot to send this one in time. Anyway, this is now included in the patchset, merged with another patch. Regards,
diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index aea4332..7f31cd2 100644 --- a/drivers/media/video/v4l2-event.c +++ b/drivers/media/video/v4l2-event.c @@ -26,6 +26,7 @@ #include <media/v4l2-fh.h> #include <media/v4l2-event.h> +#include <linux/slab.h> #include <linux/sched.h> int v4l2_event_init(struct v4l2_fh *fh)