Message ID | 20201109162244.16531-1-linkmauve@linkmauve.fr (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1kcC2u-004jV5-0l; Mon, 09 Nov 2020 18:37:41 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730185AbgKIShg (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 9 Nov 2020 13:37:36 -0500 Received: from 82-65-109-163.subs.proxad.net ([82.65.109.163]:40064 "EHLO luna.linkmauve.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729493AbgKIShg (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 9 Nov 2020 13:37:36 -0500 X-Greylist: delayed 1483 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Nov 2020 13:37:35 EST Received: by luna.linkmauve.fr (Postfix, from userid 1000) id E06F2F4158B; Mon, 9 Nov 2020 17:23:06 +0100 (CET) From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> To: Ezequiel Garcia <ezequiel@collabora.com>, Philipp Zabel <p.zabel@pengutronix.de>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Subject: [RESEND PATCH 0/2] media: uapi: Expose VP8 probability lengths as defines Date: Mon, 9 Nov 2020 17:22:42 +0100 Message-Id: <20201109162244.16531-1-linkmauve@linkmauve.fr> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
media: uapi: Expose VP8 probability lengths as defines
|
|
Message
Emmanuel Gil Peyrot
Nov. 9, 2020, 4:22 p.m. UTC
These values will be used by various drivers implementing the VP8 stateless API. This had been suggested by Ezequiel Garcia for the Cedrus VP8 driver. The only driver using this API (until now) has also been updated to use these new defines. This is a resend because I forgot to include most maintainers, sorry for that. It’s my very first patch to the kernel, I didn’t know about scripts/get_maintainers.pl Emmanuel Gil Peyrot (2): media: uapi: Expose probability lengths as defines media: hantro: Use VP8 lengths defined in uapi drivers/staging/media/hantro/hantro_vp8.c | 4 ++-- include/media/vp8-ctrls.h | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-)
Comments
Hi Emmanuel, Thanks for the patch. On Mon, 9 Nov 2020 at 15:37, Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> wrote: > > These values will be used by various drivers implementing the VP8 > stateless API. > > This had been suggested by Ezequiel Garcia for the Cedrus VP8 driver. > > The only driver using this API (until now) has also been updated to use > these new defines. > > This is a resend because I forgot to include most maintainers, sorry for > that. It’s my very first patch to the kernel, I didn’t know about > scripts/get_maintainers.pl > I haven't validated these two patches, but on a first look, it seems it's a low-hanging fruit nice cleanup. Thanks for that! Since it seems you are looking for interesting things to contribute, note that the vp8-ctrls.h header is lacking some nice documentation on each structure. This should be done by looking at the VP8 syntax spec and documenting things appropriately. See how it's done for H.264 and VP9: https://patchwork.linuxtv.org/project/linux-media/patch/20200928201433.327068-1-ezequiel@collabora.com/ https://patchwork.kernel.org/project/linux-rockchip/patch/20201102190551.1223389-3-adrian.ratiu@collabora.com/ Thanks, Ezequiel > Emmanuel Gil Peyrot (2): > media: uapi: Expose probability lengths as defines > media: hantro: Use VP8 lengths defined in uapi > > drivers/staging/media/hantro/hantro_vp8.c | 4 ++-- > include/media/vp8-ctrls.h | 6 ++++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > -- > 2.29.2 >