saa7134 and �¼PD61151 MPEG2 coder
Commit Message
Comments
Hi Dmitri,
Just a quick note: the video4linux mailinglist is obsolete, just use linux-media.
On Wednesday 27 January 2010 06:36:37 Dmitri Belimov wrote:
> Hi Hans.
>
> I finished saa7134 part of SPI. Please review saa7134-spi.c and diff saa7134-core and etc.
> I wrote config of SPI to board structure. Use this config for register master and slave devices.
>
> SPI other then I2C, do not need call request_module. Udev do it.
> I spend 10 days for understanding :(
I'm almost certain that spi works the same way as i2c and that means that you
must call request_module. Yes, udev will load it for you, but that is a delayed
load: i.e. the module may not be loaded when we need it. The idea behind this
is that usually i2c or spi modules are standalone, but in the context of v4l
such modules are required to be present before the bridge can properly configure
itself.
The easiest way to ensure the correct load sequence is to do a request_module
at the start.
Now, I haven't compiled this, but I think this will work:
struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev,
struct spi_master *master, struct spi_board_info *info)
{
struct v4l2_subdev *sd = NULL;
struct spi_device *spi;
BUG_ON(!v4l2_dev);
if (module_name)
request_module(module_name);
spi = spi_new_device(master, info);
if (spi == NULL || spi->dev.driver == NULL)
goto error;
if (!try_module_get(spi->dev.driver->owner))
goto error;
sd = spi_get_drvdata(spi);
/* Register with the v4l2_device which increases the module's
use count as well. */
if (v4l2_device_register_subdev(v4l2_dev, sd))
sd = NULL;
/* Decrease the module use count to match the first try_module_get. */
module_put(spi->dev.driver->owner);
error:
/* If we have a client but no subdev, then something went wrong and
we must unregister the client. */
if (spi && sd == NULL)
spi_unregister_device(spi);
return sd;
}
EXPORT_SYMBOL_GPL(v4l2_spi_new_subdev);
Note that you mixed up the spi master and spi client in your original code. So
it is no wonder you experienced crashes.
Also note that there is no need for a separate v4l2_spi_new_subdev_board function.
And in v4l2_spi_subdev_init() you should use spi_set_drvdata instead of
dev_set_drvdata.
I hope this helps.
Regards,
Hans
>
> I need help with v4l2-common.c -> function v4l2_spi_new_subdev_board
> The module of SPI slave loading after some time and spi device hasn't v4l2_subdev structure
> for v4l2_device_register_subdev.
>
> Now I get kernel crash when call v4l2_device_register_subdev.
>
> Need use a callback metod or other. I don't know.
>
> Copy to Mauro Carvalho Chehab and mailing lists for review my code too.
>
> Dmesg log without call v4l2_device_register_subdev.
> [ 4.742279] Linux video capture interface: v2.00
> [ 4.816171] saa7130/34: v4l2 driver version 0.2.15 loaded
> [ 4.816253] saa7134 0000:04:01.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
> [ 4.816304] saa7133[0]: found at 0000:04:01.0, rev: 209, irq: 19, latency: 32, mmio: 0xe5100000
> [ 4.816363] saa7133[0]: subsystem: 5ace:7595, board: Beholder BeholdTV X7 [card=171,autodetected]
> [ 4.816430] saa7133[0]: board init: gpio is 200000
> [ 4.816481] IRQ 19/saa7133[0]: IRQF_DISABLED is not guaranteed on shared IRQs
> [ 4.976010] saa7133[0]: i2c eeprom 00: ce 5a 95 75 54 20 00 00 00 00 00 00 00 00 00 01
> [ 4.976635] saa7133[0]: i2c eeprom 10: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.977231] saa7133[0]: i2c eeprom 20: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.977827] saa7133[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.978423] saa7133[0]: i2c eeprom 40: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.979019] saa7133[0]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.979615] saa7133[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.980223] saa7133[0]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.980820] saa7133[0]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.981416] saa7133[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.982012] saa7133[0]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.982608] saa7133[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.983204] saa7133[0]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.983800] saa7133[0]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.984437] saa7133[0]: i2c eeprom e0: 00 00 00 00 ff ff ff ff ff ff ff ff ff ff ff ff
> [ 4.985033] saa7133[0]: i2c eeprom f0: 42 54 56 30 30 30 30 ff ff ff ff ff ff ff ff ff
> [ 5.008041] tuner 1-0061: chip found @ 0xc2 (saa7133[0])
> [ 5.024036] HDA Intel 0000:00:1b.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
> [ 5.024109] HDA Intel 0000:00:1b.0: setting latency timer to 64
> [ 5.066725] xc5000 1-0061: creating new instance
> [ 5.076009] xc5000: Successfully identified at address 0x61
> [ 5.076060] xc5000: Firmware has not been loaded previously
>
> [ 33.381216] saa7134 0000:04:01.0: spi master registered: bus_num=32766 num_chipselect=1
> [ 33.381274] saa7133[0]: found muPD61151 MPEG encoder
> [ 33.381430] saa7133[0]: registered device video0 [v4l2]
> [ 33.381491] saa7133[0]: registered device vbi0
> [ 33.381551] saa7133[0]: registered device radio0
> [ 33.406256] saa7133[0]: registered device video1 [mpeg]
> [ 33.407628] upd61151_probe function
> [ 33.407672] Read test REG 0xD8 :
> [ 33.409502] REG = 0x0
> [ 33.409547] Write test 0x03 to REG 0xD8 :
> [ 33.411353] Next read test REG 0xD8 :
> [ 33.413176] REG = 0x3
> [ 33.431308] saa7134 ALSA driver for DMA sound loaded
> [ 33.431363] IRQ 19/saa7133[0]: IRQF_DISABLED is not guaranteed on shared IRQs
> [ 33.431425] saa7133[0]/alsa: saa7133[0] at 0xe5100000 irq 19 registered as card -1
>
> [ 48.657067] xc5000: I2C write failed (len=4)
> [ 48.760018] xc5000: I2C write failed (len=4)
> [ 48.762960] xc5000: I2C read failed
> [ 48.763011] xc5000: I2C read failed
> [ 48.763054] xc5000: waiting for firmware upload (dvb-fe-xc5000-1.6.114.fw)...
> [ 48.763102] saa7134 0000:04:01.0: firmware: requesting dvb-fe-xc5000-1.6.114.fw
> [ 48.802473] xc5000: firmware read 12401 bytes.
> [ 48.802477] xc5000: firmware uploading...
> [ 49.328504] eth0: no IPv6 routers present
> [ 52.132007] xc5000: firmware upload complete...
> [ 53.366772] ------------[ cut here ]------------
> [ 53.366820] kernel BUG at lib/kernel_lock.c:126!
> [ 53.366865] invalid opcode: 0000 [#1] SMP
> [ 53.366973] last sysfs file: /sys/class/firmware/0000:04:01.0/loading
> [ 53.367019] Modules linked in: ipv6 dm_snapshot dm_mirror dm_region_hash dm_log dm_mod loop saa7134_alsa upd61151 saa7134_empress ir_kbd_i2c snd_hda_codec_realtek xc5000 snd_hda_intel snd_hda_codec tuner snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy snd_seq_oss snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq saa7134 snd_timer ir_common v4l2_common videodev snd_seq_device v4l1_compat videobuf_dma_sg videobuf_core spi_bitbang psmouse snd ir_core serio_raw tveeprom soundcore parport_pc parport processor i2c_i801 button snd_page_alloc i2c_core intel_agp agpgart rng_core pcspkr evdev ext3 jbd mbcache sg sr_mod cdrom sd_mod ata_generic ata_piix libata scsi_mod ide_pci_generic ide_core ehci_hcd uhci_hcd r8169 mii usbcore thermal fan thermal_sys [last unloaded: scsi_wait_scan]
> [ 53.369624]
> [ 53.369666] Pid: 2659, comm: hald-probe-vide Not tainted (2.6.30.5 #1) G31M-ES2L
> [ 53.369721] EIP: 0060:[<c02f81e3>] EFLAGS: 00010286 CPU: 0
> [ 53.369770] EIP is at unlock_kernel+0xd/0x24
> [ 53.369814] EAX: f6bc26ac EBX: f6bc2000 ECX: f6bc26ac EDX: f707e4d0
> [ 53.369860] ESI: 00000000 EDI: f6aa90c0 EBP: f6bc26ac ESP: f65b1e68
> [ 53.369906] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> [ 53.369952] Process hald-probe-vide (pid: 2659, ti=f65b0000 task=f707e4d0 task.ti=f65b0000)
> [ 53.370008] Stack:
> [ 53.370049] f873e9c9 00000000 f687c804 f6aa90c0 00000000 f848e309 00000000 f6b4d680
> [ 53.370298] f6b4d680 c0190049 f6aa90c0 f6a144e4 00000000 f6aa90c0 00000000 f6a144e4
> [ 53.370298] c018ff24 c018c3b9 f701ef40 f6d11a5c f6aa90c0 f65b1f0c f65b1f0c 00008001
> [ 53.370298] Call Trace:
> [ 53.370298] [<f873e9c9>] ? ts_open+0x8c/0x93 [saa7134_empress]
> [ 53.370298] [<f848e309>] ? v4l2_open+0x65/0x78 [videodev]
> [ 53.370298] [<c0190049>] ? chrdev_open+0x125/0x13c
> [ 53.370298] [<c018ff24>] ? chrdev_open+0x0/0x13c
> [ 53.370298] [<c018c3b9>] ? __dentry_open+0x119/0x208
> [ 53.370298] [<c018c539>] ? nameidata_to_filp+0x29/0x3c
> [ 53.370298] [<c0197338>] ? do_filp_open+0x41e/0x7bc
> [ 53.370298] [<c017bb3c>] ? handle_mm_fault+0x294/0x5fd
> [ 53.370298] [<c019e267>] ? alloc_fd+0x52/0xb8
> [ 53.370298] [<c018c1d1>] ? do_sys_open+0x44/0xb4
> [ 53.370298] [<c018c285>] ? sys_open+0x1e/0x23
> [ 53.370298] [<c0102f74>] ? sysenter_do_call+0x12/0x28
> [ 53.370298] Code: 0f c1 05 e0 4b 3e c0 38 e0 74 09 f3 90 a0 e0 4b 3e c0 eb f3 64 a1 00 b0 43 c0 89 50 14 c3 64 8b 15 00 b0 43 c0 83 7a 14 00 79 04 <0f> 0b eb fe 8b 42 14 48 85 c0 89 42 14 79 07 f0 fe 05 e0 4b 3e
> [ 53.370298] EIP: [<c02f81e3>] unlock_kernel+0xd/0x24 SS:ESP 0068:f65b1e68
> [ 53.374302] ---[ end trace 05965e9e089c46c7 ]---
>
>
> With my best regards, Dmitry.
>
HIi Hans
> Hi Dmitri,
>
> Just a quick note: the video4linux mailinglist is obsolete, just use
> linux-media.
OK
> On Wednesday 27 January 2010 06:36:37 Dmitri Belimov wrote:
> > Hi Hans.
> >
> > I finished saa7134 part of SPI. Please review saa7134-spi.c and
> > diff saa7134-core and etc. I wrote config of SPI to board
> > structure. Use this config for register master and slave devices.
> >
> > SPI other then I2C, do not need call request_module. Udev do it.
> > I spend 10 days for understanding :(
>
> I'm almost certain that spi works the same way as i2c and that means
> that you must call request_module. Yes, udev will load it for you,
> but that is a delayed load: i.e. the module may not be loaded when we
> need it. The idea behind this is that usually i2c or spi modules are
> standalone, but in the context of v4l such modules are required to be
> present before the bridge can properly configure itself.
>
> The easiest way to ensure the correct load sequence is to do a
> request_module at the start.
>
> Now, I haven't compiled this, but I think this will work:
>
> struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev,
> struct spi_master *master, struct spi_board_info *info)
> {
> struct v4l2_subdev *sd = NULL;
> struct spi_device *spi;
>
> BUG_ON(!v4l2_dev);
>
> if (module_name)
> request_module(module_name);
>
> spi = spi_new_device(master, info);
>
> if (spi == NULL || spi->dev.driver == NULL)
> goto error;
>
> if (!try_module_get(spi->dev.driver->owner))
> goto error;
>
> sd = spi_get_drvdata(spi);
>
> /* Register with the v4l2_device which increases the module's
> use count as well. */
>
> if (v4l2_device_register_subdev(v4l2_dev, sd))
> sd = NULL;
>
> /* Decrease the module use count to match the first
> try_module_get. */ module_put(spi->dev.driver->owner);
>
> error:
> /* If we have a client but no subdev, then something went
> wrong and we must unregister the client. */
>
> if (spi && sd == NULL)
> spi_unregister_device(spi);
>
> return sd;
> }
> EXPORT_SYMBOL_GPL(v4l2_spi_new_subdev);
Not work
[ 6.048195] Linux video capture interface: v2.00
[ 6.112987] saa7130/34: v4l2 driver version 0.2.15 loaded
[ 6.113067] saa7134 0000:04:01.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
[ 6.113117] saa7133[0]: found at 0000:04:01.0, rev: 209, irq: 19, latency: 32, mmio: 0xe5100000
[ 6.113176] saa7133[0]: subsystem: 5ace:7595, board: Beholder BeholdTV X7 [card=171,autodetected]
[ 6.113241] saa7133[0]: board init: gpio is 200000
[ 6.113292] IRQ 19/saa7133[0]: IRQF_DISABLED is not guaranteed on shared IRQs
[ 6.264512] saa7133[0]: i2c eeprom 00: ce 5a 95 75 54 20 00 00 00 00 00 00 00 00 00 01
[ 6.265136] saa7133[0]: i2c eeprom 10: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.265731] saa7133[0]: i2c eeprom 20: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.266327] saa7133[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.266922] saa7133[0]: i2c eeprom 40: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.267517] saa7133[0]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.268113] saa7133[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.268718] saa7133[0]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.269313] saa7133[0]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.269908] saa7133[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.270503] saa7133[0]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.271098] saa7133[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.271693] saa7133[0]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.272289] saa7133[0]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.272895] saa7133[0]: i2c eeprom e0: 00 00 00 00 ff ff ff ff ff ff ff ff ff ff ff ff
[ 6.273490] saa7133[0]: i2c eeprom f0: 42 54 56 30 30 30 30 ff ff ff ff ff ff ff ff ff
[ 6.360023] tuner 1-0061: chip found @ 0xc2 (saa7133[0])
[ 6.401952] xc5000 1-0061: creating new instance
[ 6.412005] xc5000: Successfully identified at address 0x61
[ 6.412054] xc5000: Firmware has not been loaded previously
[ 6.477742] HDA Intel 0000:00:1b.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
[ 6.477816] HDA Intel 0000:00:1b.0: setting latency timer to 64
[ 34.752763] saa7134 0000:04:01.0: spi master registered: bus_num=32766 num_chipselect=1
[ 34.752823] saa7133[0]: found muPD61151 MPEG encoder
[ 34.752883] befor request_module
[ 240.476013] INFO: task modprobe:1404 blocked for more than 120 seconds.
[ 240.476016] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[ 240.476018] modprobe D f6b913c0 0 1404 1
[ 240.476021] c200f0c0 00000086 00989680 f6b913c0 c011b1fd c043f0c0 00000003 00000000
[ 240.476027] f711faa0 f711fc54 00000000 0001ecac 176f9ddf 00000008 f711facc f711faa0
[ 240.476031] f7070490 c011cc8e 00000000 c200f0c0 c02ff658 00000001 f7070490 00000046
[ 240.476036] Call Trace:
[ 240.476042] [<c011b1fd>] ? wakeup_preempt_entity+0xf0/0x110
[ 240.476046] [<c011cc8e>] ? check_preempt_wakeup+0x139/0x173
[ 240.476050] [<c02f6984>] ? schedule+0x5/0x13
[ 240.476052] [<c02f6ab0>] ? schedule_timeout+0x15/0x16a
[ 240.476055] [<c011bba4>] ? __wake_up_common+0x34/0x59
[ 240.476057] [<c011c477>] ? __wake_up+0x29/0x39
[ 240.476060] [<c02f6069>] ? wait_for_common+0xba/0x115
[ 240.476063] [<c0122170>] ? default_wake_function+0x0/0x8
[ 240.476067] [<c0133e10>] ? call_usermodehelper_exec+0x6e/0xae
[ 240.476069] [<c0133fd5>] ? __request_module+0xdb/0xee
[ 240.476076] [<f847c647>] ? spi_bitbang_setup+0xe7/0xfb [spi_bitbang]
[ 240.476082] [<f84c8f3b>] ? v4l2_spi_new_subdev_board+0x2e/0x35 [v4l2_common]
[ 240.476086] [<f84c8fa6>] ? v4l2_spi_new_subdev+0x64/0x6c [v4l2_common]
[ 240.476099] [<f852c0b5>] ? saa7134_initdev+0x6dd/0xa96 [saa7134]
[ 240.476103] [<c0213045>] ? local_pci_probe+0xb/0xc
[ 240.476105] [<c02139bd>] ? pci_device_probe+0x41/0x63
[ 240.476109] [<c026d03c>] ? driver_probe_device+0x76/0xfe
[ 240.476112] [<c026d104>] ? __driver_attach+0x40/0x5b
[ 240.476115] [<c026cad8>] ? bus_for_each_dev+0x37/0x5f
[ 240.476117] [<c026cf23>] ? driver_attach+0x11/0x13
[ 240.476120] [<c026d0c4>] ? __driver_attach+0x0/0x5b
[ 240.476122] [<c026c56a>] ? bus_add_driver+0xcb/0x1ee
[ 240.476131] [<f854b000>] ? saa7134_init+0x0/0x3b [saa7134]
[ 240.476134] [<c026d31f>] ? driver_register+0x87/0xe0
[ 240.476143] [<f854b000>] ? saa7134_init+0x0/0x3b [saa7134]
[ 240.476146] [<c0213cf5>] ? __pci_register_driver+0x33/0x8a
[ 240.476154] [<f854b000>] ? saa7134_init+0x0/0x3b [saa7134]
[ 240.476157] [<c010112d>] ? do_one_initcall+0x44/0x111
[ 240.476160] [<c016107f>] ? tracepoint_module_notify+0x21/0x24
[ 240.476164] [<c013a5b6>] ? notifier_call_chain+0x2a/0x47
[ 240.476167] [<c013a80b>] ? __blocking_notifier_call_chain+0x3f/0x49
[ 240.476171] [<c0147a67>] ? sys_init_module+0x87/0x187
[ 240.476173] [<c0102f74>] ? sysenter_do_call+0x12/0x28
[ 240.476177] INFO: task modprobe:1705 blocked for more than 120 seconds.
[ 240.476178] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[ 240.476180] modprobe D f6a54040 0 1705 1704
[ 240.476182] c200f0c0 00000082 c0202b29 f6a54040 c04b8eb0 c043f0c0 c019c7f4 00000001
[ 240.476187] f7188450 f7188604 00000000 c04b8ea0 1894fb69 00000008 00000001 f7020774
[ 240.476192] c0202998 f68e7e68 c04b8ea0 00000006 00000001 00000000 ffffffc1 00000001
[ 240.476196] Call Trace:
[ 240.476199] [<c0202b29>] ? ida_get_new_above+0xd4/0x178
[ 240.476203] [<c019c7f4>] ? find_inode+0x1b/0x56
[ 240.476205] [<c0202998>] ? idr_get_empty_slot+0x145/0x202
[ 240.476208] [<c0202b29>] ? ida_get_new_above+0xd4/0x178
[ 240.476211] [<c02f6984>] ? schedule+0x5/0x13
[ 240.476213] [<c02f6ab0>] ? schedule_timeout+0x15/0x16a
[ 240.476216] [<c019c44c>] ? iput+0x21/0x4a
[ 240.476219] [<c01cad13>] ? sysfs_addrm_finish+0x46/0x1a6
[ 240.476221] [<c01caa40>] ? sysfs_add_one+0x10/0xad
[ 240.476224] [<c02f761e>] ? __down+0x4e/0x73
[ 240.476227] [<c013a54c>] ? down+0x1f/0x2a
[ 240.476229] [<c026d0eb>] ? __driver_attach+0x27/0x5b
[ 240.476232] [<c026cad8>] ? bus_for_each_dev+0x37/0x5f
[ 240.476234] [<c026cf23>] ? driver_attach+0x11/0x13
[ 240.476237] [<c026d0c4>] ? __driver_attach+0x0/0x5b
[ 240.476239] [<c026c56a>] ? bus_add_driver+0xcb/0x1ee
[ 240.476243] [<f874f000>] ? init_upd61151+0x0/0xa [upd61151]
[ 240.476245] [<c026d31f>] ? driver_register+0x87/0xe0
[ 240.476248] [<f874f000>] ? init_upd61151+0x0/0xa [upd61151]
[ 240.476250] [<c010112d>] ? do_one_initcall+0x44/0x111
[ 240.476253] [<c016107f>] ? tracepoint_module_notify+0x21/0x24
[ 240.476256] [<c013a5b6>] ? notifier_call_chain+0x2a/0x47
[ 240.476259] [<c013a80b>] ? __blocking_notifier_call_chain+0x3f/0x49
[ 240.476261] [<c0147a67>] ? sys_init_module+0x87/0x187
[ 240.476264] [<c0102f74>] ? sysenter_do_call+0x12/0x28
[ 240.476267] [<c013007b>] ? prepare_signal+0x10f/0x184
[ 240.476269] [<c0130000>] ? prepare_signal+0x94/0x184
Module not load successfull. As I see spi_register_driver in upd61151.c not finished a long long long time
and killed by kernel. I see this message last 10 days befor removing request_module from function.
> Note that you mixed up the spi master and spi client in your original
> code. So it is no wonder you experienced crashes.
Yes, this is my error you are right. :((
struct spi_device *spi;
spi = spi_new_device(master, info);
> And in v4l2_spi_subdev_init() you should use spi_set_drvdata instead
> of dev_set_drvdata.
Ok
> I hope this helps.
Thank you.
> Regards,
>
> Hans
>
> >
> > I need help with v4l2-common.c -> function v4l2_spi_new_subdev_board
> > The module of SPI slave loading after some time and spi device
> > hasn't v4l2_subdev structure for v4l2_device_register_subdev.
> >
> > Now I get kernel crash when call v4l2_device_register_subdev.
> >
> > Need use a callback metod or other. I don't know.
> >
> > Copy to Mauro Carvalho Chehab and mailing lists for review my code
> > too.
> >
> > Dmesg log without call v4l2_device_register_subdev.
> > [ 4.742279] Linux video capture interface: v2.00
> > [ 4.816171] saa7130/34: v4l2 driver version 0.2.15 loaded
> > [ 4.816253] saa7134 0000:04:01.0: PCI INT A -> GSI 19 (level,
> > low) -> IRQ 19 [ 4.816304] saa7133[0]: found at 0000:04:01.0,
> > rev: 209, irq: 19, latency: 32, mmio: 0xe5100000 [ 4.816363]
> > saa7133[0]: subsystem: 5ace:7595, board: Beholder BeholdTV X7
> > [card=171,autodetected] [ 4.816430] saa7133[0]: board init: gpio
> > is 200000 [ 4.816481] IRQ 19/saa7133[0]: IRQF_DISABLED is not
> > guaranteed on shared IRQs [ 4.976010] saa7133[0]: i2c eeprom 00:
> > ce 5a 95 75 54 20 00 00 00 00 00 00 00 00 00 01 [ 4.976635]
> > saa7133[0]: i2c eeprom 10: ff ff ff ff ff ff ff ff ff ff ff ff ff
> > ff ff ff [ 4.977231] saa7133[0]: i2c eeprom 20: ff ff ff ff ff
> > ff ff ff ff ff ff ff ff ff ff ff [ 4.977827] saa7133[0]: i2c
> > eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> > [ 4.978423] saa7133[0]: i2c eeprom 40: ff ff ff ff ff ff ff ff
> > ff ff ff ff ff ff ff ff [ 4.979019] saa7133[0]: i2c eeprom 50:
> > ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 4.979615]
> > saa7133[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff
> > ff ff ff [ 4.980223] saa7133[0]: i2c eeprom 70: ff ff ff ff ff
> > ff ff ff ff ff ff ff ff ff ff ff [ 4.980820] saa7133[0]: i2c
> > eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> > [ 4.981416] saa7133[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff
> > ff ff ff ff ff ff ff ff [ 4.982012] saa7133[0]: i2c eeprom a0:
> > ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 4.982608]
> > saa7133[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff
> > ff ff ff [ 4.983204] saa7133[0]: i2c eeprom c0: ff ff ff ff ff
> > ff ff ff ff ff ff ff ff ff ff ff [ 4.983800] saa7133[0]: i2c
> > eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> > [ 4.984437] saa7133[0]: i2c eeprom e0: 00 00 00 00 ff ff ff ff
> > ff ff ff ff ff ff ff ff [ 4.985033] saa7133[0]: i2c eeprom f0:
> > 42 54 56 30 30 30 30 ff ff ff ff ff ff ff ff ff [ 5.008041]
> > tuner 1-0061: chip found @ 0xc2 (saa7133[0]) [ 5.024036] HDA
> > Intel 0000:00:1b.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
> > [ 5.024109] HDA Intel 0000:00:1b.0: setting latency timer to 64
> > [ 5.066725] xc5000 1-0061: creating new instance [ 5.076009]
> > xc5000: Successfully identified at address 0x61 [ 5.076060]
> > xc5000: Firmware has not been loaded previously
> >
> > [ 33.381216] saa7134 0000:04:01.0: spi master registered:
> > bus_num=32766 num_chipselect=1 [ 33.381274] saa7133[0]: found
> > muPD61151 MPEG encoder [ 33.381430] saa7133[0]: registered device
> > video0 [v4l2] [ 33.381491] saa7133[0]: registered device vbi0
> > [ 33.381551] saa7133[0]: registered device radio0
> > [ 33.406256] saa7133[0]: registered device video1 [mpeg]
> > [ 33.407628] upd61151_probe function
> > [ 33.407672] Read test REG 0xD8 :
> > [ 33.409502] REG = 0x0
> > [ 33.409547] Write test 0x03 to REG 0xD8 :
> > [ 33.411353] Next read test REG 0xD8 :
> > [ 33.413176] REG = 0x3
> > [ 33.431308] saa7134 ALSA driver for DMA sound loaded
> > [ 33.431363] IRQ 19/saa7133[0]: IRQF_DISABLED is not guaranteed
> > on shared IRQs [ 33.431425] saa7133[0]/alsa: saa7133[0] at
> > 0xe5100000 irq 19 registered as card -1
> >
> > [ 48.657067] xc5000: I2C write failed (len=4)
> > [ 48.760018] xc5000: I2C write failed (len=4)
> > [ 48.762960] xc5000: I2C read failed
> > [ 48.763011] xc5000: I2C read failed
> > [ 48.763054] xc5000: waiting for firmware upload
> > (dvb-fe-xc5000-1.6.114.fw)... [ 48.763102] saa7134 0000:04:01.0:
> > firmware: requesting dvb-fe-xc5000-1.6.114.fw [ 48.802473]
> > xc5000: firmware read 12401 bytes. [ 48.802477] xc5000: firmware
> > uploading... [ 49.328504] eth0: no IPv6 routers present
> > [ 52.132007] xc5000: firmware upload complete...
> > [ 53.366772] ------------[ cut here ]------------
> > [ 53.366820] kernel BUG at lib/kernel_lock.c:126!
> > [ 53.366865] invalid opcode: 0000 [#1] SMP
> > [ 53.366973] last sysfs
> > file: /sys/class/firmware/0000:04:01.0/loading [ 53.367019]
> > Modules linked in: ipv6 dm_snapshot dm_mirror dm_region_hash dm_log
> > dm_mod loop saa7134_alsa upd61151 saa7134_empress ir_kbd_i2c
> > snd_hda_codec_realtek xc5000 snd_hda_intel snd_hda_codec tuner
> > snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy snd_seq_oss
> > snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq saa7134
> > snd_timer ir_common v4l2_common videodev snd_seq_device v4l1_compat
> > videobuf_dma_sg videobuf_core spi_bitbang psmouse snd ir_core
> > serio_raw tveeprom soundcore parport_pc parport processor i2c_i801
> > button snd_page_alloc i2c_core intel_agp agpgart rng_core pcspkr
> > evdev ext3 jbd mbcache sg sr_mod cdrom sd_mod ata_generic ata_piix
> > libata scsi_mod ide_pci_generic ide_core ehci_hcd uhci_hcd r8169
> > mii usbcore thermal fan thermal_sys [last unloaded: scsi_wait_scan]
> > [ 53.369624] [ 53.369666] Pid: 2659, comm: hald-probe-vide Not
> > tainted (2.6.30.5 #1) G31M-ES2L [ 53.369721] EIP:
> > 0060:[<c02f81e3>] EFLAGS: 00010286 CPU: 0 [ 53.369770] EIP is at
> > unlock_kernel+0xd/0x24 [ 53.369814] EAX: f6bc26ac EBX: f6bc2000
> > ECX: f6bc26ac EDX: f707e4d0 [ 53.369860] ESI: 00000000 EDI:
> > f6aa90c0 EBP: f6bc26ac ESP: f65b1e68 [ 53.369906] DS: 007b ES:
> > 007b FS: 00d8 GS: 0033 SS: 0068 [ 53.369952] Process
> > hald-probe-vide (pid: 2659, ti=f65b0000 task=f707e4d0
> > task.ti=f65b0000) [ 53.370008] Stack: [ 53.370049] f873e9c9
> > 00000000 f687c804 f6aa90c0 00000000 f848e309 00000000 f6b4d680
> > [ 53.370298] f6b4d680 c0190049 f6aa90c0 f6a144e4 00000000
> > f6aa90c0 00000000 f6a144e4 [ 53.370298] c018ff24 c018c3b9
> > f701ef40 f6d11a5c f6aa90c0 f65b1f0c f65b1f0c 00008001
> > [ 53.370298] Call Trace: [ 53.370298] [<f873e9c9>] ?
> > ts_open+0x8c/0x93 [saa7134_empress] [ 53.370298] [<f848e309>] ?
> > v4l2_open+0x65/0x78 [videodev] [ 53.370298] [<c0190049>] ?
> > chrdev_open+0x125/0x13c [ 53.370298] [<c018ff24>] ?
> > chrdev_open+0x0/0x13c [ 53.370298] [<c018c3b9>] ?
> > __dentry_open+0x119/0x208 [ 53.370298] [<c018c539>] ?
> > nameidata_to_filp+0x29/0x3c [ 53.370298] [<c0197338>] ?
> > do_filp_open+0x41e/0x7bc [ 53.370298] [<c017bb3c>] ?
> > handle_mm_fault+0x294/0x5fd [ 53.370298] [<c019e267>] ?
> > alloc_fd+0x52/0xb8 [ 53.370298] [<c018c1d1>] ?
> > do_sys_open+0x44/0xb4 [ 53.370298] [<c018c285>] ?
> > sys_open+0x1e/0x23 [ 53.370298] [<c0102f74>] ?
> > sysenter_do_call+0x12/0x28 [ 53.370298] Code: 0f c1 05 e0 4b 3e
> > c0 38 e0 74 09 f3 90 a0 e0 4b 3e c0 eb f3 64 a1 00 b0 43 c0 89 50
> > 14 c3 64 8b 15 00 b0 43 c0 83 7a 14 00 79 04 <0f> 0b eb fe 8b 42 14
> > 48 85 c0 89 42 14 79 07 f0 fe 05 e0 4b 3e [ 53.370298] EIP:
> > [<c02f81e3>] unlock_kernel+0xd/0x24 SS:ESP 0068:f65b1e68
> > [ 53.374302] ---[ end trace 05965e9e089c46c7 ]---
> >
> >
> > With my best regards, Dmitry.
> >
>
> --
> Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 28 January 2010 03:09:41 Dmitri Belimov wrote:
> HIi Hans
>
> > Hi Dmitri,
> >
> > Just a quick note: the video4linux mailinglist is obsolete, just use
> > linux-media.
>
> OK
>
> > On Wednesday 27 January 2010 06:36:37 Dmitri Belimov wrote:
> > > Hi Hans.
> > >
> > > I finished saa7134 part of SPI. Please review saa7134-spi.c and
> > > diff saa7134-core and etc. I wrote config of SPI to board
> > > structure. Use this config for register master and slave devices.
> > >
> > > SPI other then I2C, do not need call request_module. Udev do it.
> > > I spend 10 days for understanding :(
> >
> > I'm almost certain that spi works the same way as i2c and that means
> > that you must call request_module. Yes, udev will load it for you,
> > but that is a delayed load: i.e. the module may not be loaded when we
> > need it. The idea behind this is that usually i2c or spi modules are
> > standalone, but in the context of v4l such modules are required to be
> > present before the bridge can properly configure itself.
> >
> > The easiest way to ensure the correct load sequence is to do a
> > request_module at the start.
> >
> > Now, I haven't compiled this, but I think this will work:
> >
> > struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev,
> > struct spi_master *master, struct spi_board_info *info)
> > {
> > struct v4l2_subdev *sd = NULL;
> > struct spi_device *spi;
> >
> > BUG_ON(!v4l2_dev);
> >
> > if (module_name)
> > request_module(module_name);
There is one thing missing here: module_name should be passed in as argument
to v4l2_spi_new_subdev. Does this code actually compile? If so, then I suspect
module_name must be some global variable with some bogus value which causes
request_module to time out.
> [ 240.476082] [<f84c8f3b>] ? v4l2_spi_new_subdev_board+0x2e/0x35 [v4l2_common]
> [ 240.476086] [<f84c8fa6>] ? v4l2_spi_new_subdev+0x64/0x6c [v4l2_common]
Remove v4l2_spi_new_subdev_board. Just have a v4l2_spi_new_subdev as in my code.
Regards,
Hans
Hi I get trouble with my Kworld em28xx device, anyone can help any
kernel issue found somewhere about that?
Bus 001 Device 005: ID eb1a:2860 eMPIA Technology, Inc.
The device seems to go to usb1 hub and its usb2
Using kernel : 2.6.27-7-generic
LSUSB
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 005: ID eb1a:2860 eMPIA Technology, Inc.
Bus 001 Device 004: ID 046d:c404 Logitech, Inc. TrackMan Wheel
Bus 001 Device 003: ID 04d9:1603 Holtek Semiconductor, Inc.
Bus 001 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
DMESG
[ 2.429146] usbcore: registered new interface driver usbfs
[ 2.429164] usbcore: registered new interface driver hub
[ 2.429216] usbcore: registered new device driver usb
[ 2.518153] usb usb1: configuration #1 chosen from 1 choice
[ 2.900018] usb 1-1: new low speed USB device using ohci_hcd and
address 2
[ 2.912659] usb usb2: configuration #1 chosen from 1 choice
[ 3.576015] usb 2-3: new high speed USB device using ehci_hcd and
address 4
[ 4.096019] usb 2-3: device not accepting address 4, error -71
[ 4.208015] usb 2-3: new high speed USB device using ehci_hcd and
address 5
[ 4.340706] usb 2-3: configuration #1 chosen from 1 choice
[ 4.644571] usb 1-1: new low speed USB device using ohci_hcd and
address 3
[ 4.876163] usb 1-1: configuration #1 chosen from 1 choice
[ 5.180015] usb 1-2: new low speed USB device using ohci_hcd and
address 4
[ 5.393407] usb 1-2: configuration #1 chosen from 1 choice
[ 5.396625] usb 2-3: USB disconnect, address 5
[ 5.636017] usb 2-3: new high speed USB device using ehci_hcd and
address 6
[ 5.768459] usb 2-3: configuration #1 chosen from 1 choice
[ 5.768794] usbcore: registered new interface driver hiddev
[ 5.772486] usb 2-3: USB disconnect, address 6
[ 5.781319] input: USB Keyboard as
/devices/pci0000:00/0000:00:02.0/usb1/1-1/1-1:1.0/input/input1
[ 5.784136] input,hidraw0: USB HID v1.10 Keyboard [ USB Keyboard] on
usb-0000:00:02.0-1
[ 5.807105] input: USB Keyboard as
/devices/pci0000:00/0000:00:02.0/usb1/1-1/1-1:1.1/input/input2
[ 5.807351] input,hidraw1: USB HID v1.10 Device [ USB Keyboard] on
usb-0000:00:02.0-1
[ 5.814365] input: Logitech Trackball as
/devices/pci0000:00/0000:00:02.0/usb1/1-2/1-2:1.0/input/input3
[ 5.814594] input,hidraw2: USB HID v1.10 Mouse [Logitech Trackball]
on usb-0000:00:02.0-2
[ 5.814611] usbcore: registered new interface driver usbhid
[ 5.814614] usbhid: v2.6:USB HID core driver
[ 6.048518] usb 2-3: new high speed USB device using ehci_hcd and
address 7
[ 6.568017] usb 2-3: device not accepting address 7, error -71
[ 6.680026] usb 2-3: new high speed USB device using ehci_hcd and
address 8
[ 7.192521] usb 1-3: new full speed USB device using ohci_hcd and
address 5
[ 7.393043] usb 1-3: not running at top speed; connect to a high
speed hub
[ 7.399169] usb 1-3: configuration #1 chosen from 1 choice
[ 13.927208] em28xx Doesn't have usb audio class
[ 14.934118] input: em28xx snapshot button as
/devices/pci0000:00/0000:00:02.0/usb1/1-3/input/input7
[ 16.785083] usbcore: registered new interface driver em28xx
[ 16.909506] em28xx-audio.c: probing for em28x1 non standard usbaudio
[ 18.609828] usbcore: usbfs: unrecognised mount option "default" or
missing value
[ 18.609834] usbcore: usbfs: mount parameter error:
LSPCI
00:00.0 RAM memory: nVidia Corporation MCP61 Memory Controller (rev a1)
00:01.0 ISA bridge: nVidia Corporation MCP61 LPC Bridge (rev a2)
00:01.1 SMBus: nVidia Corporation MCP61 SMBus (rev a2)
00:01.2 RAM memory: nVidia Corporation MCP61 Memory Controller (rev a2)
00:02.0 USB Controller: nVidia Corporation MCP61 USB Controller (rev a3)
00:02.1 USB Controller: nVidia Corporation MCP61 USB Controller (rev a3)
00:04.0 PCI bridge: nVidia Corporation MCP61 PCI bridge (rev a1)
00:05.0 Audio device: nVidia Corporation MCP61 High Definition Audio
(rev a2)
00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2)
00:08.0 IDE interface: nVidia Corporation MCP61 SATA Controller (rev a2)
00:09.0 PCI bridge: nVidia Corporation MCP61 PCI Express bridge (rev a2)
00:0b.0 PCI bridge: nVidia Corporation MCP61 PCI Express bridge (rev a2)
00:0c.0 PCI bridge: nVidia Corporation MCP61 PCI Express bridge (rev a2)
00:0d.0 VGA compatible controller: nVidia Corporation GeForce 6150SE
nForce 430 (rev a2)
00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
HyperTransport Technology Configuration
00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Address Map
00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
DRAM Controller
00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Miscellaneous Control
01:07.0 Ethernet controller: VIA Technologies, Inc. VT6105/VT6106S
[Rhine-III] (rev 86)
--
This message has been verified by LastSpam (http://www.lastspam.com) eMail security service, provided by SoluLAN
Ce courriel a ete verifie par le service de securite pour courriels LastSpam (http://www.lastspam.com), fourni par SoluLAN (http://www.solulan.com)
www.solulan.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 22, 2010 at 5:38 PM, j <jlafontaine@ctecworld.com> wrote:
> Hi I get trouble with my Kworld em28xx device, anyone can help any kernel
> issue found somewhere about that?
Hi J,
Is this device plugged directly into the USB port on the motherboard?
Or do you have a USB hub that the device is connected to. Sometimes
low quality USB hubs will not work properly with high speed isoc
devices.
Also, I would suggest that you leave the device unplugged when
powering up the system. Then once it is up, plug it in and send the
full dmesg output. This will make it easier to analyze the dmesg
output because the driver will not be initializing at the same time as
all the other USB devices.
Also, please provide the *full* dmesg output, so we have more context
information about the system (things such as the kernel version, etc).
Cheers,
Devin
Hi,
I have the KWorld DVB-T 305U, an em28xx device. Only the video works for me under Linux, no audio. In case anyone wants to see it, I have attached the full dmesg text, solely from this device.
Cheers,
Dean
Devin Heitmueller wrote:
> ....
> Also, please provide the *full* dmesg output, so we have more context
> information about the system (things such as the kernel version, etc).
>
> Cheers,
>
> Devin
>
On Tue, Feb 23, 2010 at 1:37 AM, Dean <red1@linuxstation.net> wrote:
> Hi,
>
> I have the KWorld DVB-T 305U, an em28xx device. Only the video works for me under Linux, no audio. In case anyone wants to see it, I have attached the full dmesg text, solely from this device.
>
> Cheers,
> Dean
Hi Dean,
How are you testing the audio, and under what video standard are you
trying to use the device (NTSC/PAL/SECAM)?
Devin
Devin Heitmueller wrote:
> On Tue, Feb 23, 2010 at 1:37 AM, Dean <red1@linuxstation.net> wrote:
>> Hi,
>>
>> I have the KWorld DVB-T 305U, an em28xx device. Only the video works for me under Linux, no audio. In case anyone wants to see it, I have attached the full dmesg text, solely from this device.
>>
>> Cheers,
>> Dean
>
> Hi Dean,
>
> How are you testing the audio, and under what video standard are you
> trying to use the device (NTSC/PAL/SECAM)?
>
> Devin
>
Devin
I am receiving NTSC TV signals. I test with mplayer. Example;
mplayer tv://9 -tv driver=v4l2:alsa:immediatemode=0:adevice=hw.Em28xxAudio,0:norm=ntsc:chanlist=us-cable -vf pp=ci
The above command works fine (both audio and video) with my Hauppauge HVR-850, but for the Kworld 305U I must change 'immediatemode=0' to 'immediatemode=1' otherwise the video frame rate is about 1/2 normal speed and about 1 minute later mplayer starts printing 'video buffer full - dropping frame'.
According to dmesg the Kworld 305U loads the same firmware as my Hauppauge HVR-850, and (during separate test sessions) installs the same ALSA device;
card 1: Em28xxAudio [Em28xx Audio], device 0: Em28xx Audio [Empia 28xx Capture]
Subdevices: 0/1
Subdevice #0: subdevice #0
Dean
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 23, 2010 at 4:17 PM, Dean <red1@linuxstation.net> wrote:
> I am receiving NTSC TV signals. I test with mplayer. Example;
>
> mplayer tv://9 -tv driver=v4l2:alsa:immediatemode=0:adevice=hw.Em28xxAudio,0:norm=ntsc:chanlist=us-cable -vf pp=ci
>
> The above command works fine (both audio and video) with my Hauppauge HVR-850, but for the Kworld 305U I must change 'immediatemode=0' to 'immediatemode=1' otherwise the video frame rate is about 1/2 normal speed and about 1 minute later mplayer starts printing 'video buffer full - dropping frame'.
>
> According to dmesg the Kworld 305U loads the same firmware as my Hauppauge HVR-850, and (during separate test sessions) installs the same ALSA device;
>
> card 1: Em28xxAudio [Em28xx Audio], device 0: Em28xx Audio [Empia 28xx Capture]
> Subdevices: 0/1
> Subdevice #0: subdevice #0
Try this: open em28xx-cards.c, and change the board profile for the
entry EM2880_BOARD_KWORLD_DVB_305U such that it includes the following
field:
.mts_firmware = 1,
Then recompile and see if it starts working.
Devin
@@ -1,9 +1,9 @@
saa7134-objs := saa7134-cards.o saa7134-core.o saa7134-i2c.o \
saa7134-ts.o saa7134-tvaudio.o saa7134-vbi.o \
- saa7134-video.o saa7134-input.o
+ saa7134-video.o saa7134-input.o saa7134-spi.o
-obj-$(CONFIG_VIDEO_SAA7134) += saa6752hs.o saa7134.o saa7134-empress.o
+obj-$(CONFIG_VIDEO_SAA7134) += saa6752hs.o saa7134.o saa7134-empress.o upd61151.o
obj-$(CONFIG_VIDEO_SAA7134_ALSA) += saa7134-alsa.o
@@ -4619,6 +4619,7 @@
.name = name_radio,
.amux = LINE2,
},
+ .encoder_type = SAA7134_ENCODER_SAA6752HS,
.mpeg = SAA7134_MPEG_EMPRESS,
.video_out = CCIR656,
.vid_port_opts = (SET_T_CODE_POLARITY_NON_INVERTED |
@@ -4656,6 +4657,7 @@
.name = name_radio,
.amux = LINE2,
},
+ .encoder_type = SAA7134_ENCODER_SAA6752HS,
.mpeg = SAA7134_MPEG_EMPRESS,
.video_out = CCIR656,
.vid_port_opts = (SET_T_CODE_POLARITY_NON_INVERTED |
@@ -4695,6 +4697,7 @@
.name = name_radio,
.amux = LINE2,
},
+ .encoder_type = SAA7134_ENCODER_SAA6752HS,
.mpeg = SAA7134_MPEG_EMPRESS,
.video_out = CCIR656,
.vid_port_opts = (SET_T_CODE_POLARITY_NON_INVERTED |
@@ -5279,23 +5282,51 @@
.tuner_addr = ADDR_UNSET,
.radio_addr = ADDR_UNSET,
.mpeg = SAA7134_MPEG_DVB,
+ .gpiomask = 0x00860000,
.inputs = { {
.name = name_tv,
.vmux = 2,
.amux = TV,
.tv = 1,
- }, {
- .name = name_comp1,
- .vmux = 0,
- .amux = LINE1,
+ .gpio = 0x00860000
+ }, {
+ .name = name_comp1,
+ .vmux = 0,
+ .amux = LINE1,
+ .gpio = 0x00860000
}, {
.name = name_svideo,
.vmux = 9,
.amux = LINE1,
- } },
- .radio = {
- .name = name_radio,
- .amux = TV,
+ .gpio = 0x00860000
+ } },
+ .radio = {
+ .name = name_radio,
+ .amux = TV,
+ .gpio = 0x00860000
+ },
+ .encoder_type = SAA7134_ENCODER_muPD61151,
+ .mpeg = SAA7134_MPEG_EMPRESS,
+ .video_out = CCIR656,
+ .vid_port_opts = (SET_T_CODE_POLARITY_NON_INVERTED |
+ SET_CLOCK_NOT_DELAYED |
+ SET_CLOCK_INVERTED |
+ SET_VSYNC_OFF),
+ .spi = {
+ .cs = 17,
+ .clock = 18,
+ .mosi = 23,
+ .miso = 21,
+ .num_chipselect = 1,
+ .spi_enable = 1,
+ },
+ .spi_conf = {
+ .modalias = "upd61151",
+ .max_speed_hz = 10000000,
+ .chip_select = 0,
+ .mode = SPI_MODE_0,
+ .controller_data = NULL,
+ .platform_data = NULL,
},
},
[SAA7134_BOARD_ZOLID_HYBRID_PCI] = {
@@ -139,6 +139,18 @@
break;
}
}
+
+unsigned long saa7134_get_gpio(struct saa7134_dev *dev)
+{
+ unsigned long status;
+
+ /* rising SAA7134_GPIO_GPRESCAN reads the status */
+ saa_andorb(SAA7134_GPIO_GPMODE3,SAA7134_GPIO_GPRESCAN,0);
+ saa_andorb(SAA7134_GPIO_GPMODE3,SAA7134_GPIO_GPRESCAN,SAA7134_GPIO_GPRESCAN);
+ status = saa_readl(SAA7134_GPIO_GPSTATUS0 >> 2) & 0xfffffff;
+ return status;
+}
+
/* ------------------------------------------------------------------ */
@@ -1057,12 +1069,42 @@
saa7134_hwinit2(dev);
- /* load i2c helpers */
+ /* initialize software SPI bus */
+ if (saa7134_boards[dev->board].spi.spi_enable)
+ {
+ dev->spi = saa7134_boards[dev->board].spi;
+
+ /* register SPI master and SPI slave */
+ if (saa7134_spi_register(dev, &saa7134_boards[dev->board].spi_conf))
+ saa7134_boards[dev->board].spi.spi_enable = 0;
+ }
+
+ /* load bus helpers */
if (card_is_empress(dev)) {
- struct v4l2_subdev *sd =
- v4l2_i2c_new_subdev(&dev->v4l2_dev, &dev->i2c_adap,
+ struct v4l2_subdev *sd = NULL;
+
+ dev->encoder_type = saa7134_boards[dev->board].encoder_type;
+
+ switch (dev->encoder_type) {
+ case SAA7134_ENCODER_muPD61151:
+ {
+ printk(KERN_INFO "%s: found muPD61151 MPEG encoder\n", dev->name);
+
+ if (saa7134_boards[dev->board].spi.spi_enable)
+ sd = v4l2_spi_new_subdev(&dev->v4l2_dev, dev->spi_adap, &saa7134_boards[dev->board].spi_conf);
+ }
+ break;
+ case SAA7134_ENCODER_SAA6752HS:
+ {
+ sd = v4l2_i2c_new_subdev(&dev->v4l2_dev, &dev->i2c_adap,
"saa6752hs", "saa6752hs",
saa7134_boards[dev->board].empress_addr, NULL);
+ }
+ break;
+ default:
+ printk(KERN_INFO "%s: MPEG encoder is not configured\n", dev->name);
+ break;
+ }
if (sd)
sd->grp_id = GRP_EMPRESS;
@@ -1139,6 +1181,8 @@
return 0;
fail4:
+ if ((card_is_empress(dev)) && (dev->encoder_type == SAA7134_ENCODER_muPD61151))
+ saa7134_spi_unregister(dev);
saa7134_unregister_video(dev);
saa7134_i2c_unregister(dev);
free_irq(pci_dev->irq, dev);
@@ -1412,6 +1456,7 @@
/* ----------------------------------------------------------- */
EXPORT_SYMBOL(saa7134_set_gpio);
+EXPORT_SYMBOL(saa7134_get_gpio);
EXPORT_SYMBOL(saa7134_boards);
/* ----------------- for the DMA sound modules --------------- */
@@ -30,6 +30,13 @@
#include <linux/notifier.h>
#include <linux/delay.h>
#include <linux/mutex.h>
+
+/* ifdef software SPI insert here start */
+#include <linux/platform_device.h>
+#include <linux/spi/spi.h>
+#include <linux/spi/spi_gpio.h>
+#include <linux/spi/spi_bitbang.h>
+/* ifdef software SPI insert here stop */
#include <asm/io.h>
@@ -337,6 +344,21 @@
SAA7134_MPEG_TS_SERIAL,
};
+enum saa7134_encoder_type {
+ SAA7134_ENCODER_UNUSED,
+ SAA7134_ENCODER_SAA6752HS,
+ SAA7134_ENCODER_muPD61151,
+};
+
+struct saa7134_software_spi {
+ unsigned char cs:5;
+ unsigned char clock:5;
+ unsigned char mosi:5;
+ unsigned char miso:5;
+ unsigned char num_chipselect:3;
+ unsigned char spi_enable:1;
+};
+
struct saa7134_board {
char *name;
unsigned int audio_clock;
@@ -355,6 +377,10 @@
unsigned char empress_addr;
unsigned char rds_addr;
+ /* SPI info */
+ struct saa7134_software_spi spi;
+ struct spi_board_info spi_conf;
+
unsigned int tda9887_conf;
unsigned int tuner_config;
@@ -362,6 +388,7 @@
enum saa7134_video_out video_out;
enum saa7134_mpeg_type mpeg;
enum saa7134_mpeg_ts_type ts_type;
+ enum saa7134_encoder_type encoder_type;
unsigned int vid_port_opts;
unsigned int ts_force_val:1;
};
@@ -506,6 +533,12 @@
void (*signal_change)(struct saa7134_dev *dev);
};
+struct saa7134_spi_gpio {
+ struct spi_bitbang bitbang;
+ struct spi_master *master;
+ struct saa7134_dev *controller_data;
+};
+
/* global device status */
struct saa7134_dev {
struct list_head devlist;
@@ -553,6 +586,10 @@
struct i2c_client i2c_client;
unsigned char eedata[256];
int has_rds;
+
+ /* software spi */
+ struct saa7134_software_spi spi;
+ struct spi_master *spi_adap;
/* video overlay */
struct v4l2_framebuffer ovbuf;
@@ -615,6 +652,7 @@
atomic_t empress_users;
struct work_struct empress_workqueue;
int empress_started;
+ enum saa7134_encoder_type encoder_type;
#if defined(CONFIG_VIDEO_SAA7134_DVB) || defined(CONFIG_VIDEO_SAA7134_DVB_MODULE)
/* SAA7134_MPEG_DVB only */
@@ -681,6 +719,7 @@
void saa7134_track_gpio(struct saa7134_dev *dev, char *msg);
void saa7134_set_gpio(struct saa7134_dev *dev, int bit_no, int value);
+unsigned long saa7134_get_gpio(struct saa7134_dev *dev);
#define SAA7134_PGTABLE_SIZE 4096
@@ -726,6 +765,11 @@
int saa7134_i2c_register(struct saa7134_dev *dev);
int saa7134_i2c_unregister(struct saa7134_dev *dev);
+/* ----------------------------------------------------------- */
+/* saa7134-spi.c */
+
+int saa7134_spi_register(struct saa7134_dev *dev, struct spi_board_info *info);
+int saa7134_spi_unregister(struct saa7134_dev *dev);
/* ----------------------------------------------------------- */
/* saa7134-video.c */
@@ -51,6 +51,7 @@
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/i2c.h>
+#include <linux/spi/spi.h>
#include <asm/uaccess.h>
#include <asm/system.h>
#include <asm/pgtable.h>
@@ -1069,6 +1070,87 @@
#endif /* defined(CONFIG_I2C) */
+//#if defined(CONFIG_SPI) || (defined(CONFIG_SPI_MODULE) && defined(MODULE)) + SPI_BITBANG
+
+/* Load an spi sub-device. */
+
+void v4l2_spi_subdev_init(struct v4l2_subdev *sd, struct spi_device *spi,
+ const struct v4l2_subdev_ops *ops)
+{
+ v4l2_subdev_init(sd, ops);
+ sd->flags |= V4L2_SUBDEV_FL_IS_SPI;
+ /* the owner is the same as the spi_device's driver owner */
+ sd->owner = spi->dev.driver->owner;
+ /* spi_device and v4l2_subdev point to one another */
+ v4l2_set_subdevdata(sd, spi);
+ dev_set_drvdata(&spi->dev, sd);
+ /* initialize name */
+ snprintf(sd->name, sizeof(sd->name), "%s",
+ spi->dev.driver->name);
+}
+EXPORT_SYMBOL_GPL(v4l2_spi_subdev_init);
+
+struct v4l2_subdev *v4l2_spi_new_subdev_board(struct v4l2_device *v4l2_dev,
+ struct spi_master *spi, struct spi_board_info *info)
+{
+ struct v4l2_subdev *sd = NULL;
+
+ BUG_ON(!v4l2_dev);
+
+ if (spi == NULL)
+ goto error;
+
+ spi_new_device(spi,info);
+
+#if 0
+ if (module_name)
+ request_module(module_name);
+
+ if (!try_module_get(spi->dev.driver->owner))
+ goto error;
+
+ sd = dev_get_drvdata(&spi->dev);
+
+ /* Register with the v4l2_device which increases the module's
+ use count as well. */
+
+ if (v4l2_device_register_subdev(v4l2_dev, sd))
+ sd = NULL;
+
+ /* Decrease the module use count to match the first try_module_get. */
+ module_put(spi->dev.driver->owner);
+#endif
+error:
+ /* If we have a client but no subdev, then something went wrong and
+ we must unregister the client. */
+#if 0
+ if (spi && sd == NULL)
+ spi_unregister_device(spi);
+#endif
+ return sd;
+}
+EXPORT_SYMBOL_GPL(v4l2_spi_new_subdev_board);
+
+struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev,
+ struct spi_master *spi, struct spi_board_info *spi_slave)
+{
+ struct spi_board_info info;
+
+ memset(&info, 0, sizeof(info));
+ strlcpy(info.modalias,spi_slave->modalias,sizeof(info.modalias));
+ info.max_speed_hz = spi_slave->max_speed_hz;
+ info.chip_select = spi_slave->chip_select;
+ info.mode = spi_slave->mode;
+ info.bus_num = spi_slave->bus_num;
+ info.platform_data = spi_slave->platform_data;
+ info.controller_data = spi_slave->controller_data;
+
+ return v4l2_spi_new_subdev_board(v4l2_dev, spi, &info);
+}
+EXPORT_SYMBOL_GPL(v4l2_spi_new_subdev);
+
+//#endif /* defined(CONFIG_SPI) */
+
/* Clamp x to be between min and max, aligned to a multiple of 2^align. min
* and max don't have to be aligned, but there must be at least one valid
* value. E.g., min=17,max=31,align=4 is not allowed as there are no multiples
@@ -191,6 +191,28 @@
/* ------------------------------------------------------------------------- */
+/* SPI Helper functions */
+
+#include <linux/spi/spi.h>
+
+struct spi_device_id;
+struct spi_device;
+
+/* Load an spi module and return an initialized v4l2_subdev struct.
+ Only call request_module if module_name != NULL.
+ The client_type argument is the name of the chip that's on the adapter. */
+struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev,
+ struct spi_master *spi, struct spi_board_info *spi_slave);
+
+struct v4l2_subdev *v4l2_spi_new_subdev_board(struct v4l2_device *v4l2_dev,
+ struct spi_master *spi, struct spi_board_info *info);
+
+/* Initialize an v4l2_subdev with data from an spi_device struct */
+void v4l2_spi_subdev_init(struct v4l2_subdev *sd, struct spi_device *spi,
+ const struct v4l2_subdev_ops *ops);
+
+/* ------------------------------------------------------------------------- */
+
/* Note: these remaining ioctls/structs should be removed as well, but they are
still used in tuner-simple.c (TUNER_SET_CONFIG), cx18/ivtv (RESET) and
v4l2-int-device.h (v4l2_routing). To remove these ioctls some more cleanup
@@ -387,6 +387,8 @@
/* Set this flag if this subdev is a i2c device. */
#define V4L2_SUBDEV_FL_IS_I2C (1U << 0)
+/* Set this flag if this subdev is a spi device. */
+#define V4L2_SUBDEV_FL_IS_SPI (1U << 1)
/* Each instance of a subdev driver should create this struct, either
stand-alone or embedded in a larger struct.