diff mbox

[1/1] DVB: ngene, fix memset parameters

Message ID 1265844762-17730-1-git-send-email-jslaby@suse.cz (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jiri Slaby Feb. 10, 2010, 11:32 p.m. UTC 
  Switch second and third memset parameter to stamp the length buffer bytes
by 0xff's, not 255 bytes by low 8 bits of Length.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Matthias Benesch <twoof7@freenet.de>
Cc: Ralph Metzler <rjkm@metzlerbros.de>
Cc: Oliver Endriss <o.endriss@gmx.de>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
---
 drivers/media/dvb/ngene/ngene-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Oliver Endriss Feb. 11, 2010, 4:20 a.m. UTC | #1 
Jiri Slaby wrote:
> Switch second and third memset parameter to stamp the length buffer bytes
> by 0xff's, not 255 bytes by low 8 bits of Length.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Matthias Benesch <twoof7@freenet.de>
> Cc: Ralph Metzler <rjkm@metzlerbros.de>
> Cc: Oliver Endriss <o.endriss@gmx.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
>  drivers/media/dvb/ngene/ngene-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index cb5982e..0150dfe 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
>  {
>  	u32 *ptr = Buffer;
>  
> -	memset(Buffer, Length, 0xff);
> +	memset(Buffer, 0xff, Length);
>  	while (Length > 0) {
>  		if (Flags & DF_SWAP32)
>  			*ptr = 0x471FFF10;
> -- 
> 1.6.6.1

Acked-by: Oliver Endriss <o.endriss@gmx.de>

CU
Oliver
diff mbox

Patch

diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index cb5982e..0150dfe 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -564,7 +564,7 @@  static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
 {
 	u32 *ptr = Buffer;
 
-	memset(Buffer, Length, 0xff);
+	memset(Buffer, 0xff, Length);
 	while (Length > 0) {
 		if (Flags & DF_SWAP32)
 			*ptr = 0x471FFF10;