Message ID | 20200807083548.204360-19-dwlsalmeida@gmail.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Hans Verkuil |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1k3xn8-00BQh1-Nk; Fri, 07 Aug 2020 08:31:55 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728068AbgHGIhO (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 7 Aug 2020 04:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728061AbgHGIhN (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 7 Aug 2020 04:37:13 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D83C061574; Fri, 7 Aug 2020 01:37:12 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id t6so406503qvw.1; Fri, 07 Aug 2020 01:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BzKR9fHjZx1AaQExoBve0sSYuiasNViTLdv1o+mD+6Q=; b=H3y29rNHBwvSlWePlB/j3lgL0GjywETBOcirj8u4yKtxpdyL3bfjuzj1jNQ5EEbIun yhuCUnuG1aS3fZd5k7Ll4pnVuJ/Lut2dxUG3V4WAYa9n3k+AFbapYGVfbvzJTPyGwf3x hVZgn2zlMhyv2vEvd/QwgvwRLDpfeGQGJyFilALVa8YkBuhRaHznJew8B+qNMNfuDHyc aGyswHBFi65Nzq8yIpvnrdufwDnYODviRJBL8w3qT/JqAtQ35Dq8KZ+hTvowLeHDG9s1 MgfZDBqal0gzosrEpu724SkueW2C+0n47rBuuwq8FBmACGHdaD8m2raBsXY1fMgoyFYW Qjdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BzKR9fHjZx1AaQExoBve0sSYuiasNViTLdv1o+mD+6Q=; b=WIdCUUsMwNK0iaeZ3IhPXaI7m9ooZ7Yooft5koBC/3r8bOwKsujJplbAZeifE+J/m9 bo11fxGkRHnr0ETPJ5qvVbPfN159lR+yfa+hyqjHTMXIs9pO3oSyrMK6Wz+KffMIn+J5 tYeu8HSkwLZbEDa/I9fEKAwFzXCNMSpgqdYFryMdhK8n2XK1oLKdMFwjHdUIXbOvhyv1 XzfMLfqGSAQ/R+ycfdfYsz0HeS0bSC6AUrrK/1T1u3uuHugPFNT4BTqY2QU3kRn/ssvE FvxWqbvQ/+XSyJpSiLqk+6lNBFIIEZ4vAMpP3WeTb/u7DTu9y5PUEj1eiab10FdHHmZd 5+pQ== X-Gm-Message-State: AOAM533ZHYk8jQZtKx/KANveEpWmf9tw0lXVT3CYH/SoYysR6mQgXX54 i3wmthtlatg/kXLcr4oV7+s= X-Google-Smtp-Source: ABdhPJyPXSw1O5XN5M+Y93vNG6SmqTGTE+fS2tcUjgOTE1aFXJcHY99JP5iwSURFXJyCOfKPclrqbw== X-Received: by 2002:ad4:54d4:: with SMTP id j20mr13485713qvx.6.1596789432215; Fri, 07 Aug 2020 01:37:12 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:da15:c0bd:33c1:e2ad]) by smtp.gmail.com with ESMTPSA id c42sm7846728qte.5.2020.08.07.01.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 01:37:11 -0700 (PDT) From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com> X-Google-Original-From: Daniel W. S. Almeida To: Benoit Parrot <bparrot@ti.com> Cc: skhan@linuxfoundation.org, "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool Date: Fri, 7 Aug 2020 05:35:46 -0300 Message-Id: <20200807083548.204360-19-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
[01/20] media: sunxi: sun8i-rotate.c: remove useless error message
|
|
Commit Message
Daniel Almeida
Aug. 7, 2020, 8:35 a.m. UTC
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com> Fix the following coccinelle report: drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING: Comparison to bool Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com> --- drivers/media/platform/ti-vpe/vpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Daniel W. S. Almeida <dwlsalmeida@gmail.com> wrote on Fri [2020-Aug-07 05:35:46 -0300]: > From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com> > > Fix the following coccinelle report: > > drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING: > Comparison to bool > > Found using - Coccinelle (http://coccinelle.lip6.fr) > > Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com> Reviewed-by: Benoit Parrot <bparrot@ti.com> > --- > drivers/media/platform/ti-vpe/vpdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c > index 2e5148ae7a0f..de600ffffbbc 100644 > --- a/drivers/media/platform/ti-vpe/vpdma.c > +++ b/drivers/media/platform/ti-vpe/vpdma.c > @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv) > > spin_lock_irqsave(&vpdma->lock, flags); > for (i = 0; i < VPDMA_MAX_NUM_LIST && > - vpdma->hwlist_used[i] == true; i++) > + vpdma->hwlist_used[i]; i++) > ; > > if (i < VPDMA_MAX_NUM_LIST) { > -- > 2.28.0 >
On Tue, 2020-08-11 at 07:57 -0500, Benoit Parrot wrote: > Daniel W. S. Almeida <dwlsalmeida@gmail.com> wrote on Fri [2020-Aug-07 05:35:46 -0300]: > > From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com> > > > > Fix the following coccinelle report: > > > > drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING: > > Comparison to bool > > > > Found using - Coccinelle (http://coccinelle.lip6.fr) [] > > diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c [] > > @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv) > > > > spin_lock_irqsave(&vpdma->lock, flags); > > for (i = 0; i < VPDMA_MAX_NUM_LIST && > > - vpdma->hwlist_used[i] == true; i++) > > + vpdma->hwlist_used[i]; i++) > > ; A more typical way to write this loop is not testing i < VPDMA_MAX_NUM_LIST multiple times like the below: --- drivers/media/platform/ti-vpe/vpdma.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c index 2e5148ae7a0f..5893917ce50d 100644 --- a/drivers/media/platform/ti-vpe/vpdma.c +++ b/drivers/media/platform/ti-vpe/vpdma.c @@ -942,14 +942,13 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv) unsigned long flags; spin_lock_irqsave(&vpdma->lock, flags); - for (i = 0; i < VPDMA_MAX_NUM_LIST && - vpdma->hwlist_used[i] == true; i++) - ; - - if (i < VPDMA_MAX_NUM_LIST) { + for (i = 0; i < VPDMA_MAX_NUM_LIST; i++) { + if (vpdma->hwlist_used[i]) + continue; list_num = i; vpdma->hwlist_used[i] = true; vpdma->hwlist_priv[i] = priv; + break; } spin_unlock_irqrestore(&vpdma->lock, flags);
diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c index 2e5148ae7a0f..de600ffffbbc 100644 --- a/drivers/media/platform/ti-vpe/vpdma.c +++ b/drivers/media/platform/ti-vpe/vpdma.c @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv) spin_lock_irqsave(&vpdma->lock, flags); for (i = 0; i < VPDMA_MAX_NUM_LIST && - vpdma->hwlist_used[i] == true; i++) + vpdma->hwlist_used[i]; i++) ; if (i < VPDMA_MAX_NUM_LIST) {