Message ID | 1573728085-29016-10-git-send-email-chunfeng.yun@mediatek.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1iVCZh-00011a-11; Thu, 14 Nov 2019 10:42:05 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbfKNKl7 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 14 Nov 2019 05:41:59 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:42059 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726983AbfKNKl6 (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 14 Nov 2019 05:41:58 -0500 X-UUID: 744dca403fdd4e1e855ad41f91a2f7d3-20191114 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=/v3ZAT8MMQQn1PPsfQoog57z7OcnmZ7w9uOMGarZugY=; b=eap7G/NVuy9vJuwCgJ8lFLXvSvWTTAMnIs+sxZ8hfdw/o693knpzrYo4rLSob4715mhnjagrjXDy7e/hwObz91K0gK7sLcnaNiqRPC39tHHzT6Vsz1iVsPt8wu9OySnZ4EgSi5yoXCFOsbb/ndjZokyfXL15S+wl9jH7s6Lti2A=; X-UUID: 744dca403fdd4e1e855ad41f91a2f7d3-20191114 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from <chunfeng.yun@mediatek.com>) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1787366391; Thu, 14 Nov 2019 18:41:54 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Nov 2019 18:41:53 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 14 Nov 2019 18:41:48 +0800 From: Chunfeng Yun <chunfeng.yun@mediatek.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Felipe Balbi <balbi@kernel.org> CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Peter Chen <Peter.Chen@nxp.com>, Minas Harutyunyan <hminas@synopsys.com>, Cristian Birsan <cristian.birsan@microchip.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Kevin Cernekee <cernekee@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, <bcm-kernel-feedback-list@broadcom.com>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Bin Liu <b-liu@ti.com>, Matthias Brugger <matthias.bgg@gmail.com>, Stephen Boyd <swboyd@chromium.org>, Chunfeng Yun <chunfeng.yun@mediatek.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, Colin Ian King <colin.king@canonical.com>, Biju Das <biju.das@bp.renesas.com>, Fabrizio Castro <fabrizio.castro@bp.renesas.com>, "Gustavo A. R. Silva" <gustavo@embeddedor.com>, Yangtao Li <tiny.windzz@gmail.com>, <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org> Subject: [PATCH v3 10/13] usb: gadget: udc: renesas_usb3: create debugfs directory under usb root Date: Thu, 14 Nov 2019 18:41:22 +0800 Message-ID: <1573728085-29016-10-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1573728085-29016-1-git-send-email-chunfeng.yun@mediatek.com> References: <1573728085-29016-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: 662CFFC5D757F574D8AD256B9DEA6AC1A087CE590745DB105BB6C8C4E4FE39652000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Series |
[v3,01/13] media: uvcvideo: drop error check of debugfs_create_dir()
|
|
Commit Message
Chunfeng Yun
Nov. 14, 2019, 10:41 a.m. UTC
Now the USB gadget subsystem can use the USB debugfs root directory,
so move it's directory from the root of the debugfs filesystem into
the root of usb
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: no changes
v2:
1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root
---
drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Chunfeng-san, > From: Chunfeng Yun, Sent: Thursday, November 14, 2019 7:41 PM > > Now the USB gadget subsystem can use the USB debugfs root directory, > so move it's directory from the root of the debugfs filesystem into > the root of usb > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Thank you for the patch! When I apply this patch on the Greg's usb.git / usb-next branch, the following warning happens: $ patch -p1 < ~/Downloads/v3-10-13-usb-gadget-udc-renesas_usb3-create-debugfs-directory-under-usb-root.patch patching file drivers/usb/gadget/udc/renesas_usb3.c Hunk #1 succeeded at 2536 (offset 1 line). I'm not sure we should fix it strictly though, this patch seems good to me. So, Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> And, I tested this patch on my environment and confirmed that the debug file moved from /sys/kernel/debug to /sys/kernel/debug/usb. So, Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda > --- > v3: no changes > > v2: > 1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root > --- > drivers/usb/gadget/udc/renesas_usb3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c > index e098f16c01cb..4dde69e7f6b1 100644 > --- a/drivers/usb/gadget/udc/renesas_usb3.c > +++ b/drivers/usb/gadget/udc/renesas_usb3.c > @@ -2535,7 +2535,7 @@ static const struct file_operations renesas_usb3_b_device_fops = { > static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3, > struct device *dev) > { > - usb3->dentry = debugfs_create_dir(dev_name(dev), NULL); > + usb3->dentry = debugfs_create_dir(dev_name(dev), usb_debug_root); > > debugfs_create_file("b_device", 0644, usb3->dentry, usb3, > &renesas_usb3_b_device_fops); > -- > 2.23.0
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index e098f16c01cb..4dde69e7f6b1 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2535,7 +2535,7 @@ static const struct file_operations renesas_usb3_b_device_fops = { static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3, struct device *dev) { - usb3->dentry = debugfs_create_dir(dev_name(dev), NULL); + usb3->dentry = debugfs_create_dir(dev_name(dev), usb_debug_root); debugfs_create_file("b_device", 0644, usb3->dentry, usb3, &renesas_usb3_b_device_fops);