Message ID | 20191030094902.32582-1-manivannan.sadhasivam@linaro.org (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1iPkcQ-0005O5-0v; Wed, 30 Oct 2019 09:50:22 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbfJ3JuS (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 30 Oct 2019 05:50:18 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:39944 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbfJ3JuS (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 30 Oct 2019 05:50:18 -0400 Received: by mail-pl1-f193.google.com with SMTP id p5so750818plr.7 for <linux-media@vger.kernel.org>; Wed, 30 Oct 2019 02:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=dxdq8UVKYIoWezTIVtNtXNzC1j7K03aSUVKZV0KfYRw=; b=YnXmlhvmJfVKB0QmBFuEk1Dm6DSXTswd+nqgqBYqzmGyWTUPCNZxiLaZ6OveR3YPSE IW2bdz58hEfhH1XY8lrAtgzQa2fz9t7PRS1LVa8dzzm95V2ktPvt4+u7Zsd8pQHkGerw 6Lx+ce3tDBWdv3koWwURnOQutmFyd+s9QK1OsuJaiTcO7x3Q4ZII363HZpWB2+/O30mM SwYaPJ53x/pu5UyACmPBtEsATFQ6TYlmatUqqXiEIK0VOFLxKD4M+O8AjMSnD0+cq/nF o33Vv7TjeO+rV/OuPdcUyYEgIuw33LFtFrUkyk6bqnwzC30I3hcbeeOjPBA4wQCfXtGU Ch2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dxdq8UVKYIoWezTIVtNtXNzC1j7K03aSUVKZV0KfYRw=; b=byAiMRSNU66fCBl41FDbpWY2iJvvmo4kqKNED8W0R5ggr0iS/FJwi64UH4uHdE47LY 4gCuGkxMllBgwJxquSCMbwA9h3UhpRf2ObFQYcJnXwm876j7iuQOV/i8GLHxeOiSm8g7 TigmS9Ijj04uU1OPdTJzUZL0lUxpusmJRuZGL7ElwAyS3RgpRROiEbKAvAUY0Ayi9T46 Jwn9aWzphAiDS5Pgiqgoq2DF5d/pi80gMeQaekLlTRk8IUZSgx1xO8F8rOSs1cqqyU0v GpCKAeDpP/dfWd5uIy3PGqpFyGkIP4Ej1F5ZkvPJttumHquDHhC6cFF5ggunwOkJfUTp SO7A== X-Gm-Message-State: APjAAAXdVh4X8CJepbF6PKpDh3UKtCY3SbIbbWL/ibBH3ALf5kDGyXkM hsLRdOXaVTAfW24rJWHI1VdD X-Google-Smtp-Source: APXvYqw4kJLQKZSWO1XO57Sx5aIe0oheAiqfVnYm2K1VgupBhhuZBmqESudgkztCyR7WtYQb6nqZTQ== X-Received: by 2002:a17:902:8d86:: with SMTP id v6mr3621909plo.79.1572429015669; Wed, 30 Oct 2019 02:50:15 -0700 (PDT) Received: from localhost.localdomain ([2409:4072:618e:77d9:c9fa:423a:3851:8df4]) by smtp.gmail.com with ESMTPSA id n23sm2301329pff.137.2019.10.30.02.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 02:50:15 -0700 (PDT) From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: mchehab@kernel.org, robh+dt@kernel.org, sakari.ailus@iki.fi Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Subject: [PATCH v4 0/2] Add IMX296 CMOS image sensor support Date: Wed, 30 Oct 2019 15:19:00 +0530 Message-Id: <20191030094902.32582-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Series |
Add IMX296 CMOS image sensor support
|
|
Message
Manivannan Sadhasivam
Oct. 30, 2019, 9:49 a.m. UTC
Hello, This patchset adds support for IMX296 CMOS image sensor from Sony. Sensor can be programmed through I2C and 4-wire interface but the current driver only supports I2C interface. The sensor is capable of outputting frames in CSI2 format (1 Lane). In the case of sensor resolution, driver only supports 1440x1088 at 30 FPS. The driver has been validated using Framos IMX296 module interfaced to 96Boards Dragonboard410c. Thanks, Mani Changes in v4: * Fixed issues related to gain settings and few misc cleanups in driver * Documented port node and removed maxItems, default prop from dt binding as per the review Changes in v3: * Fixed the reference to video-interfaces.txt in binding. Changes in v2: * Switched to YAML binding Manivannan Sadhasivam (2): dt-bindings: media: i2c: Add IMX296 CMOS sensor binding media: i2c: Add IMX296 CMOS image sensor driver .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++ MAINTAINERS | 8 + drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/imx296.c | 715 ++++++++++++++++++ 5 files changed, 829 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml create mode 100644 drivers/media/i2c/imx296.c
Comments
Hi Mani, Thank you for the patches. On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote: > Hello, > > This patchset adds support for IMX296 CMOS image sensor from Sony. > Sensor can be programmed through I2C and 4-wire interface but the > current driver only supports I2C interface. The sensor is > capable of outputting frames in CSI2 format (1 Lane). In the case > of sensor resolution, driver only supports 1440x1088 at 30 FPS. > > The driver has been validated using Framos IMX296 module interfaced to > 96Boards Dragonboard410c. I've just been made aware of your work. I also worked on an IMX296 sensor driver in parallel, which I will post to the list. My driver doesn't hardcode the resolution but computes register values at runtime, so I wonder if it could be a better option. I'll post it now. > Changes in v4: > > * Fixed issues related to gain settings and few misc cleanups in driver > * Documented port node and removed maxItems, default prop from dt binding > as per the review > > Changes in v3: > > * Fixed the reference to video-interfaces.txt in binding. > > Changes in v2: > > * Switched to YAML binding > > Manivannan Sadhasivam (2): > dt-bindings: media: i2c: Add IMX296 CMOS sensor binding > media: i2c: Add IMX296 CMOS image sensor driver > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++ > MAINTAINERS | 8 + > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/imx296.c | 715 ++++++++++++++++++ > 5 files changed, 829 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > create mode 100644 drivers/media/i2c/imx296.c
Hi Laurent, On Thu, Oct 31, 2019 at 03:16:44PM +0200, Laurent Pinchart wrote: > Hi Mani, > > Thank you for the patches. > > On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This patchset adds support for IMX296 CMOS image sensor from Sony. > > Sensor can be programmed through I2C and 4-wire interface but the > > current driver only supports I2C interface. The sensor is > > capable of outputting frames in CSI2 format (1 Lane). In the case > > of sensor resolution, driver only supports 1440x1088 at 30 FPS. > > > > The driver has been validated using Framos IMX296 module interfaced to > > 96Boards Dragonboard410c. > > I've just been made aware of your work. I also worked on an IMX296 > sensor driver in parallel, which I will post to the list. My driver > doesn't hardcode the resolution but computes register values at runtime, > so I wonder if it could be a better option. I'll post it now. > I'm fine with it. The reason the driver is simple in the first place is, that's how my usual workflow is. Start small and build it big ;-) Anyway, I'm happy if your driver gets in. Thanks, Mani > > Changes in v4: > > > > * Fixed issues related to gain settings and few misc cleanups in driver > > * Documented port node and removed maxItems, default prop from dt binding > > as per the review > > > > Changes in v3: > > > > * Fixed the reference to video-interfaces.txt in binding. > > > > Changes in v2: > > > > * Switched to YAML binding > > > > Manivannan Sadhasivam (2): > > dt-bindings: media: i2c: Add IMX296 CMOS sensor binding > > media: i2c: Add IMX296 CMOS image sensor driver > > > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++ > > MAINTAINERS | 8 + > > drivers/media/i2c/Kconfig | 11 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/imx296.c | 715 ++++++++++++++++++ > > 5 files changed, 829 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > create mode 100644 drivers/media/i2c/imx296.c > > -- > Regards, > > Laurent Pinchart
Hi Mani, On Thu, Oct 31, 2019 at 06:53:52PM +0530, Manivannan Sadhasivam wrote: > On Thu, Oct 31, 2019 at 03:16:44PM +0200, Laurent Pinchart wrote: > > On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote: > > > Hello, > > > > > > This patchset adds support for IMX296 CMOS image sensor from Sony. > > > Sensor can be programmed through I2C and 4-wire interface but the > > > current driver only supports I2C interface. The sensor is > > > capable of outputting frames in CSI2 format (1 Lane). In the case > > > of sensor resolution, driver only supports 1440x1088 at 30 FPS. > > > > > > The driver has been validated using Framos IMX296 module interfaced to > > > 96Boards Dragonboard410c. > > > > I've just been made aware of your work. I also worked on an IMX296 > > sensor driver in parallel, which I will post to the list. My driver > > doesn't hardcode the resolution but computes register values at runtime, > > so I wonder if it could be a better option. I'll post it now. > > I'm fine with it. The reason the driver is simple in the first place is, that's > how my usual workflow is. Start small and build it big ;-) > > Anyway, I'm happy if your driver gets in. My driver sometimes has trouble finding the sensor at probe time, so I'll study and try your code too. It could be a problem specific to my platform (I'm testing on a custom i.MX7 board). > > > Changes in v4: > > > > > > * Fixed issues related to gain settings and few misc cleanups in driver > > > * Documented port node and removed maxItems, default prop from dt binding > > > as per the review > > > > > > Changes in v3: > > > > > > * Fixed the reference to video-interfaces.txt in binding. > > > > > > Changes in v2: > > > > > > * Switched to YAML binding > > > > > > Manivannan Sadhasivam (2): > > > dt-bindings: media: i2c: Add IMX296 CMOS sensor binding > > > media: i2c: Add IMX296 CMOS image sensor driver > > > > > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++ > > > MAINTAINERS | 8 + > > > drivers/media/i2c/Kconfig | 11 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/imx296.c | 715 ++++++++++++++++++ > > > 5 files changed, 829 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > create mode 100644 drivers/media/i2c/imx296.c
Hi Mani, Laurent, On Thu, Oct 31, 2019 at 03:28:01PM +0200, Laurent Pinchart wrote: > Hi Mani, > > On Thu, Oct 31, 2019 at 06:53:52PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Oct 31, 2019 at 03:16:44PM +0200, Laurent Pinchart wrote: > > > On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote: > > > > Hello, > > > > > > > > This patchset adds support for IMX296 CMOS image sensor from Sony. > > > > Sensor can be programmed through I2C and 4-wire interface but the > > > > current driver only supports I2C interface. The sensor is > > > > capable of outputting frames in CSI2 format (1 Lane). In the case > > > > of sensor resolution, driver only supports 1440x1088 at 30 FPS. > > > > > > > > The driver has been validated using Framos IMX296 module interfaced to > > > > 96Boards Dragonboard410c. > > > > > > I've just been made aware of your work. I also worked on an IMX296 > > > sensor driver in parallel, which I will post to the list. My driver > > > doesn't hardcode the resolution but computes register values at runtime, > > > so I wonder if it could be a better option. I'll post it now. > > > > I'm fine with it. The reason the driver is simple in the first place is, that's > > how my usual workflow is. Start small and build it big ;-) > > > > Anyway, I'm happy if your driver gets in. > > My driver sometimes has trouble finding the sensor at probe time, so > I'll study and try your code too. It could be a problem specific to my > platform (I'm testing on a custom i.MX7 board). Based on this discussion I'll mark the second patch of the set obsolete in Patchwork. Laurent: please see my comments on the driver as well.