media: i2c: ov5695: Modify the function of async register subdev related devices
Commit Message
This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
sensor related devices such as actuator/VCM.
Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
---
drivers/media/i2c/ov5695.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu@mediatek.com> wrote:
>
> This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> sensor related devices such as actuator/VCM.
nit: The description should be wrapped around the 80th column.
Sakari, do we need to resent or you could just rewrap when applying?
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
> drivers/media/i2c/ov5695.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> index e65a943..b6ee62c 100644
> --- a/drivers/media/i2c/ov5695.c
> +++ b/drivers/media/i2c/ov5695.c
> @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
> goto err_power_off;
> #endif
>
> - ret = v4l2_async_register_subdev(sd);
> + ret = v4l2_async_register_subdev_sensor_common(sd);
> if (ret) {
> dev_err(dev, "v4l2 async register subdev failed\n");
> goto err_clean_entity;
> --
> 2.9.2
>
Otherwise:
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
Hi Tomasz, Dongchun,
(Removed randomly cc'd people from distribution.)
On Sat, Sep 28, 2019 at 09:17:11PM +0900, Tomasz Figa wrote:
> On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu@mediatek.com> wrote:
> >
> > This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> > sensor related devices such as actuator/VCM.
>
> nit: The description should be wrapped around the 80th column.
>
> Sakari, do we need to resent or you could just rewrap when applying?
I'll rewrap.
>
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > ---
> > drivers/media/i2c/ov5695.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> > index e65a943..b6ee62c 100644
> > --- a/drivers/media/i2c/ov5695.c
> > +++ b/drivers/media/i2c/ov5695.c
> > @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
> > goto err_power_off;
> > #endif
> >
> > - ret = v4l2_async_register_subdev(sd);
> > + ret = v4l2_async_register_subdev_sensor_common(sd);
> > if (ret) {
> > dev_err(dev, "v4l2 async register subdev failed\n");
> > goto err_clean_entity;
> > --
> > 2.9.2
> >
>
> Otherwise:
>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Thanks!
@@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
goto err_power_off;
#endif
- ret = v4l2_async_register_subdev(sd);
+ ret = v4l2_async_register_subdev_sensor_common(sd);
if (ret) {
dev_err(dev, "v4l2 async register subdev failed\n");
goto err_clean_entity;