| Message ID | 1301948324-27186-2-git-send-email-stefan.ringel@arcor.de (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Mon, 04 Apr 2011 17:21:11 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1Q6qGt-000392-0E for mchehab@pedra; Mon, 04 Apr 2011 17:21:11 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Mon, 04 Apr 2011 17:21:10 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Q6qFf-0003TH-Ls; Mon, 04 Apr 2011 20:19:56 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597Ab1DDUTB (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 4 Apr 2011 16:19:01 -0400 Received: from mail-in-14.arcor-online.net ([151.189.21.54]:35115 "EHLO mail-in-14.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755450Ab1DDUS7 (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 4 Apr 2011 16:18:59 -0400 Received: from mail-in-14-z2.arcor-online.net (mail-in-14-z2.arcor-online.net [151.189.8.31]) by mx.arcor.de (Postfix) with ESMTP id 1A91D9BEF5; Mon, 4 Apr 2011 22:18:57 +0200 (CEST) Received: from mail-in-02.arcor-online.net (mail-in-02.arcor-online.net [151.189.21.42]) by mail-in-14-z2.arcor-online.net (Postfix) with ESMTP id 0B92B1BB2C2; Mon, 4 Apr 2011 22:18:57 +0200 (CEST) Received: from localhost.localdomain (dslb-094-222-027-138.pools.arcor-ip.net [94.222.27.138]) (Authenticated sender: stefan.ringel@arcor.de) by mail-in-02.arcor-online.net (Postfix) with ESMTPA id B9D7030D3A; Mon, 4 Apr 2011 22:18:56 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-02.arcor-online.net B9D7030D3A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1301948336; bh=PCf3+W19jAW2//+UhB4D/J+kphdTUYr5nvb3Ew1Ilvw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=YzOU2gSkRe1tGyN1xg65jzy+k04Te/wfR188vcvNjyGs3r/2xClnC2uAedroB3LR4 btj2qoipfGSQRiF6xIXRBPKAXI+/r/WFE+YqyEhyI7s0l8MBfavEOr+j+XCABlMHjM Y6sPBfbiH7SQSqppDidg6/Ne854rIY6oNb6hEzJE= From: stefan.ringel@arcor.de To: linux-media@vger.kernel.org Cc: mchehab@redhat.com, d.belimov@gmail.com, Stefan Ringel <stefan.ringel@arcor.de> Subject: [PATCH 2/5] tm6000: add dtv78 parameter Date: Mon, 4 Apr 2011 22:18:41 +0200 Message-Id: <1301948324-27186-2-git-send-email-stefan.ringel@arcor.de> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> References: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Stefan Ringel
April 4, 2011, 8:18 p.m. UTC
From: Stefan Ringel <stefan.ringel@arcor.de> add dtv78 parameter Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de> --- drivers/staging/tm6000/tm6000-cards.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-)
Comments
Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: > From: Stefan Ringel <stefan.ringel@arcor.de> > > add dtv78 parameter The dtv78 entry is a hack meant for card usage in Australia, that speeds up channel detection there. Again, it should be specified only when needed, and at per-board basis. > > > Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de> > --- > drivers/staging/tm6000/tm6000-cards.c | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c > index eef58da..cf2e76c 100644 > --- a/drivers/staging/tm6000/tm6000-cards.c > +++ b/drivers/staging/tm6000/tm6000-cards.c > @@ -65,6 +65,9 @@ static unsigned int xc2028_mts; > module_param(xc2028_mts, int, 0644); > MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); > > +static unsigned int xc2028_dtv78; > +module_param(xc2028_dtv78, int, 0644); > +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)"); > > struct tm6000_board { > char *name; > @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev) > ctl.read_not_reliable = 0; > ctl.msleep = 10; > ctl.demod = XC3028_FE_ZARLINK456; > - ctl.vhfbw7 = 1; > - ctl.uhfbw8 = 1; > + > + if (xc2028_dtv78) { > + ctl.vhfbw7 = 1; > + ctl.uhfbw8 = 1; > + } > + > if (xc2028_mts) > ctl.mts = 1; > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab: > Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >> From: Stefan Ringel<stefan.ringel@arcor.de> >> >> add dtv78 parameter > The dtv78 entry is a hack meant for card usage in Australia, that > speeds up channel detection there. Again, it should be specified > only when needed, and at per-board basis. I have test and auto detect doesn't work right. That is also region specific staff and it's better to set outside. In other words in Germany it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia). >> >> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >> --- >> drivers/staging/tm6000/tm6000-cards.c | 11 +++++++++-- >> 1 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c >> index eef58da..cf2e76c 100644 >> --- a/drivers/staging/tm6000/tm6000-cards.c >> +++ b/drivers/staging/tm6000/tm6000-cards.c >> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts; >> module_param(xc2028_mts, int, 0644); >> MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); >> >> +static unsigned int xc2028_dtv78; >> +module_param(xc2028_dtv78, int, 0644); >> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)"); >> >> struct tm6000_board { >> char *name; >> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev) >> ctl.read_not_reliable = 0; >> ctl.msleep = 10; >> ctl.demod = XC3028_FE_ZARLINK456; >> - ctl.vhfbw7 = 1; >> - ctl.uhfbw8 = 1; >> + >> + if (xc2028_dtv78) { >> + ctl.vhfbw7 = 1; >> + ctl.uhfbw8 = 1; >> + } >> + >> if (xc2028_mts) >> ctl.mts = 1; >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 20.04.2011 14:38, schrieb Mauro Carvalho Chehab: > Em 20-04-2011 05:19, Stefan Ringel escreveu: >> Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab: >>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>> From: Stefan Ringel<stefan.ringel@arcor.de> >>>> >>>> add dtv78 parameter >>> The dtv78 entry is a hack meant for card usage in Australia, that >>> speeds up channel detection there. Again, it should be specified >>> only when needed, and at per-board basis. >> I have test and auto detect doesn't work right. That is also region >> specific staff and it's better to set outside. In other words in Germany >> it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia). > xc3028 has a logic to detect and work on both Australia and Europe. > If that logic is broken, we should fix it, not adding a manual > parameter for it. > It positively a bug. When I use lower band (7MHz, load DTV7 SCODE) it doesn't work, then I go in the high band (8MHz, load DTV78, DTV8 SCODE) and have channels and can watch TV. If I go now in the lower band (7MHz, don't reload SCODE) it works. This effect is for me a bug. >>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>>> --- >>>> drivers/staging/tm6000/tm6000-cards.c | 11 +++++++++-- >>>> 1 files changed, 9 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c >>>> index eef58da..cf2e76c 100644 >>>> --- a/drivers/staging/tm6000/tm6000-cards.c >>>> +++ b/drivers/staging/tm6000/tm6000-cards.c >>>> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts; >>>> module_param(xc2028_mts, int, 0644); >>>> MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); >>>> >>>> +static unsigned int xc2028_dtv78; >>>> +module_param(xc2028_dtv78, int, 0644); >>>> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)"); >>>> >>>> struct tm6000_board { >>>> char *name; >>>> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev) >>>> ctl.read_not_reliable = 0; >>>> ctl.msleep = 10; >>>> ctl.demod = XC3028_FE_ZARLINK456; >>>> - ctl.vhfbw7 = 1; >>>> - ctl.uhfbw8 = 1; >>>> + >>>> + if (xc2028_dtv78) { >>>> + ctl.vhfbw7 = 1; >>>> + ctl.uhfbw8 = 1; >>>> + } >>>> + >>>> if (xc2028_mts) >>>> ctl.mts = 1; >>>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em 20-04-2011 11:30, Stefan Ringel escreveu: > Am 20.04.2011 14:38, schrieb Mauro Carvalho Chehab: >> Em 20-04-2011 05:19, Stefan Ringel escreveu: >>> Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab: >>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>>> From: Stefan Ringel<stefan.ringel@arcor.de> >>>>> >>>>> add dtv78 parameter >>>> The dtv78 entry is a hack meant for card usage in Australia, that >>>> speeds up channel detection there. Again, it should be specified >>>> only when needed, and at per-board basis. >>> I have test and auto detect doesn't work right. That is also region >>> specific staff and it's better to set outside. In other words in Germany >>> it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia). >> xc3028 has a logic to detect and work on both Australia and Europe. >> If that logic is broken, we should fix it, not adding a manual >> parameter for it. >> > It positively a bug. When I use lower band (7MHz, load DTV7 SCODE) it doesn't work, then I go in the high band (8MHz, load DTV78, DTV8 SCODE) and have channels and can watch TV. If I go now in the lower band (7MHz, don't reload SCODE) it works. This effect is for me a bug. The fix for it should be at xc3028. Please propose a patch for it. Maybe we should add there a parameter for auto-detection, or to force it to use dtv78, if bandwith is > 6MHz. >>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>>>> --- >>>>> drivers/staging/tm6000/tm6000-cards.c | 11 +++++++++-- >>>>> 1 files changed, 9 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c >>>>> index eef58da..cf2e76c 100644 >>>>> --- a/drivers/staging/tm6000/tm6000-cards.c >>>>> +++ b/drivers/staging/tm6000/tm6000-cards.c >>>>> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts; >>>>> module_param(xc2028_mts, int, 0644); >>>>> MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); >>>>> >>>>> +static unsigned int xc2028_dtv78; >>>>> +module_param(xc2028_dtv78, int, 0644); >>>>> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)"); >>>>> >>>>> struct tm6000_board { >>>>> char *name; >>>>> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev) >>>>> ctl.read_not_reliable = 0; >>>>> ctl.msleep = 10; >>>>> ctl.demod = XC3028_FE_ZARLINK456; >>>>> - ctl.vhfbw7 = 1; >>>>> - ctl.uhfbw8 = 1; >>>>> + >>>>> + if (xc2028_dtv78) { >>>>> + ctl.vhfbw7 = 1; >>>>> + ctl.uhfbw8 = 1; >>>>> + } >>>>> + >>>>> if (xc2028_mts) >>>>> ctl.mts = 1; >>>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 03.05.2011 12:04, schrieb Mauro Carvalho Chehab: > Em 20-04-2011 11:30, Stefan Ringel escreveu: >> Am 20.04.2011 14:38, schrieb Mauro Carvalho Chehab: >>> Em 20-04-2011 05:19, Stefan Ringel escreveu: >>>> Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab: >>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>>>> From: Stefan Ringel<stefan.ringel@arcor.de> >>>>>> >>>>>> add dtv78 parameter >>>>> The dtv78 entry is a hack meant for card usage in Australia, that >>>>> speeds up channel detection there. Again, it should be specified >>>>> only when needed, and at per-board basis. >>>> I have test and auto detect doesn't work right. That is also region >>>> specific staff and it's better to set outside. In other words in Germany >>>> it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia). >>> xc3028 has a logic to detect and work on both Australia and Europe. >>> If that logic is broken, we should fix it, not adding a manual >>> parameter for it. >>> >> It positively a bug. When I use lower band (7MHz, load DTV7 SCODE) it doesn't work, then I go in the high band (8MHz, load DTV78, DTV8 SCODE) and have channels and can watch TV. If I go now in the lower band (7MHz, don't reload SCODE) it works. This effect is for me a bug. > The fix for it should be at xc3028. Please propose a patch for it. Maybe we should add there > a parameter for auto-detection, or to force it to use dtv78, if bandwith is> 6MHz. > > The last I have scanned and used in auto mode was last year. And now work fine :-) . When have you change the code? >>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de> >>>>>> --- >>>>>> drivers/staging/tm6000/tm6000-cards.c | 11 +++++++++-- >>>>>> 1 files changed, 9 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c >>>>>> index eef58da..cf2e76c 100644 >>>>>> --- a/drivers/staging/tm6000/tm6000-cards.c >>>>>> +++ b/drivers/staging/tm6000/tm6000-cards.c >>>>>> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts; >>>>>> module_param(xc2028_mts, int, 0644); >>>>>> MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); >>>>>> >>>>>> +static unsigned int xc2028_dtv78; >>>>>> +module_param(xc2028_dtv78, int, 0644); >>>>>> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)"); >>>>>> >>>>>> struct tm6000_board { >>>>>> char *name; >>>>>> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev) >>>>>> ctl.read_not_reliable = 0; >>>>>> ctl.msleep = 10; >>>>>> ctl.demod = XC3028_FE_ZARLINK456; >>>>>> - ctl.vhfbw7 = 1; >>>>>> - ctl.uhfbw8 = 1; >>>>>> + >>>>>> + if (xc2028_dtv78) { >>>>>> + ctl.vhfbw7 = 1; >>>>>> + ctl.uhfbw8 = 1; >>>>>> + } >>>>>> + >>>>>> if (xc2028_mts) >>>>>> ctl.mts = 1; >>>>>> >>>>> -- >>>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>>>> the body of a message to majordomo@vger.kernel.org >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c index eef58da..cf2e76c 100644 --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -65,6 +65,9 @@ static unsigned int xc2028_mts; module_param(xc2028_mts, int, 0644); MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); +static unsigned int xc2028_dtv78; +module_param(xc2028_dtv78, int, 0644); +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)"); struct tm6000_board { char *name; @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev) ctl.read_not_reliable = 0; ctl.msleep = 10; ctl.demod = XC3028_FE_ZARLINK456; - ctl.vhfbw7 = 1; - ctl.uhfbw8 = 1; + + if (xc2028_dtv78) { + ctl.vhfbw7 = 1; + ctl.uhfbw8 = 1; + } + if (xc2028_mts) ctl.mts = 1;