Message ID | 20181013151707.32210-8-hch@lst.de (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1gBLfY-00022Q-HM; Sat, 13 Oct 2018 15:17:32 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727350AbeJMWzC (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Sat, 13 Oct 2018 18:55:02 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33580 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbeJMWzB (ORCPT <rfc822;linux-media@vger.kernel.org>); Sat, 13 Oct 2018 18:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IVkBQvsZS3TE4cW5kvh+t4tiXvMmm+B1CJIcTNKU7uY=; b=hRd0LCPM/yewkRw5sWfXut1ZOo BWPFBKYDBcBjojSOcWY+qjGc66wMuNMA4zXuF11YN64RF8MXLpUoPZJR/OhztT5TzR3HFKFt4MZUZ UIMZVtluMQMJ62R9KLbFri0Dp+LIGKGoUCJadztJjBh48NIVG9Mu0ZDNtKllF1SxBlFQwJj5SQnE6 HAcKdRJHPjZ/+jOnp9GfOx/cu8x71vPP2PPrz/OZiPnxtu+JXvC2b68GRujibBKquViCZ+bYEQyXL D+OddSB2tXxBqZREZq3wqPE+p55zCor4j8AiYbX25YXiA/iqvIVCMoS5Vr6DOkRDIsaVqj1e3SdYP Ir7CzJqQ==; Received: from 089144199123.atnat0008.highway.a1.net ([89.144.199.123] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gBLfU-00053L-M9; Sat, 13 Oct 2018 15:17:29 +0000 From: Christoph Hellwig <hch@lst.de> To: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs Date: Sat, 13 Oct 2018 17:17:06 +0200 Message-Id: <20181013151707.32210-8-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181013151707.32210-1-hch@lst.de> References: <20181013151707.32210-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Christoph Hellwig
Oct. 13, 2018, 3:17 p.m. UTC
The DMA API does its own zone decisions based on the coherent_dma_mask.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > --- > drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c > index 26d9fa7aeb5f..4372abbb5950 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c > @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev) > > /* Allocate all the filters within a single memory page */ > size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER); > - base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, > + base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL, > DMA_ATTR_WRITE_COMBINE); > if (!base) > return -ENOMEM; > -- > 2.19.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Oct 15, 2018 at 11:12:55AM +0200, Benjamin Gaignard wrote: > Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Can you pick it up through the media tree?
Le mer. 17 oct. 2018 à 09:20, Christoph Hellwig <hch@lst.de> a écrit : > > On Mon, Oct 15, 2018 at 11:12:55AM +0200, Benjamin Gaignard wrote: > > Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > > Can you pick it up through the media tree? No but Mauros or Hans (in CC) can add it.
Em Thu, 18 Oct 2018 14:00:40 +0200 Benjamin Gaignard <benjamin.gaignard@linaro.org> escreveu: > Le mer. 17 oct. 2018 à 09:20, Christoph Hellwig <hch@lst.de> a écrit : > > > > On Mon, Oct 15, 2018 at 11:12:55AM +0200, Benjamin Gaignard wrote: > > > Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > > > > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > > > > Can you pick it up through the media tree? > > No but Mauros or Hans (in CC) can add it. I'm adding it. Sorry for the delay. All those trips for MS/KS made harder to handle it earlier. Thanks, Mauro
diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c index 26d9fa7aeb5f..4372abbb5950 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev) /* Allocate all the filters within a single memory page */ size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER); - base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, + base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL, DMA_ATTR_WRITE_COMBINE); if (!base) return -ENOMEM;