From patchwork Wed Feb 8 11:29:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 89711 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1pPidp-00011j-F1; Wed, 08 Feb 2023 11:29:33 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbjBHL3b (ORCPT + 1 other); Wed, 8 Feb 2023 06:29:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbjBHL3a (ORCPT ); Wed, 8 Feb 2023 06:29:30 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D904458BB; Wed, 8 Feb 2023 03:29:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675855768; x=1707391768; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=YOp7/xwpRbM1HsVxkj/oLzcILyXmsT17xldYoQVlStc=; b=kRt+Z2N+rjZe0ARRu5Nejljik/nGcBgG9gY9/ckKcc1MqHwZj8AvJZ60 9rdbLwxPZlybM5U0tSb/b4zPVYM8qKh7s/XfBUnX5T1QzsUoQsuSkzDwO wJ0F91YOa5NFsHcprLcLYZegItvbxNv+nFlUXOA4fwy5IncrhF8OV+c8s VE355WGJNSdJo7p3TbjvZBiAypGrEyiyJJPP1tEvjg/Pdo4xpP5p4AC0/ 9V4kam4naacH0CTObwEFu3PG11S4huJzWfWucmBbX/DW5QdDcTbbfL06O YRpfW3vdXdLbn7YpLZIzASkzctMCzQPTrZHIQJT1NqdusazrL7lQ0DuWk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="394364469" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="394364469" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 03:29:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="735909089" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="735909089" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 08 Feb 2023 03:29:21 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3EE231A6; Wed, 8 Feb 2023 13:29:59 +0200 (EET) From: Andy Shevchenko To: Sakari Ailus , Laurent Pinchart , Alexander Stein , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Manivannan Sadhasivam , Mauro Carvalho Chehab , Andy Shevchenko Subject: [PATCH v1 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24() Date: Wed, 8 Feb 2023 13:29:57 +0200 Message-Id: <20230208112957.15563-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no Since we have a proper endianness converters for LE 24-bit data use them. While at it, format the code using switch-cases as it's done for the rest of the endianness handlers. Signed-off-by: Andy Shevchenko --- drivers/media/i2c/imx290.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 49d6c8bdec41..330098a0772d 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -16,6 +16,9 @@ #include #include #include + +#include + #include #include #include @@ -466,18 +469,20 @@ static int __always_unused imx290_read(struct imx290 *imx290, u32 addr, u32 *val return ret; } - *value = (data[2] << 16) | (data[1] << 8) | data[0]; + *value = get_unaligned_le24(data); return 0; } static int imx290_write(struct imx290 *imx290, u32 addr, u32 value, int *err) { - u8 data[3] = { value & 0xff, (value >> 8) & 0xff, value >> 16 }; + u8 data[3]; int ret; if (err && *err) return *err; + put_unaligned_le24(value, data); + ret = regmap_raw_write(imx290->regmap, addr & IMX290_REG_ADDR_MASK, data, (addr >> IMX290_REG_SIZE_SHIFT) & 3); if (ret < 0) {