From patchwork Tue Aug 2 09:32:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Ser X-Patchwork-Id: 85217 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1oIoGt-000VTP-1Z; Tue, 02 Aug 2022 09:33:03 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236050AbiHBJdA (ORCPT + 1 other); Tue, 2 Aug 2022 05:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236397AbiHBJcg (ORCPT ); Tue, 2 Aug 2022 05:32:36 -0400 Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02AF04BD3E for ; Tue, 2 Aug 2022 02:32:34 -0700 (PDT) Date: Tue, 02 Aug 2022 09:32:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1659432753; x=1659691953; bh=EmWhWVTXXvx+GlVibywJmR4SG0k0OtM9AJn8GH7msF8=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=dE5nRd1yZ57ok1nB1BxFYCZVV9wGvJ3kkvr6VDUHpOh/RBu2S51KT+SBFGeWjIuNz 2/GTjYltouHXTgIDx4zHyBp8b7Dk2bAopsS/veUWeU7TZxAV/ABaOfygzwNCCbqBUT dhnVqUyyXv1LqJqkvjEZdvsk4kM813Hg7LAPMBKgahcCJQo0pPmLvd1DCYt9pcQ/ZY HdaZg4rmSxaLZ0aVoc9O9UsU7Nb1luqpMLGeizK8j6wITHiOxvU2BPIDZJuvNJNAV2 apUwhssLmg/xdUzyHu4F+6eIODbAwjkrbNGdhjf+MY0ek+00xU0Z0ysgbpwpCabiiC jJnlz7IqU5h6w== To: linux-media@vger.kernel.org From: Simon Ser Reply-To: Simon Ser Subject: [PATCH] edid-decode: downgrade missing display product name to warning Message-ID: <20220802093219.30599-1-contact@emersion.fr> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no The spec says: > The model name of the display product may be listed (optional > but recommended) in the Display Product Name (ASCII) String > Descriptor (tag #FCh). So a missing Display Product Name descriptor shouldn't fail conformance. Signed-off-by: Simon Ser --- parse-base-block.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 582c935652b0303b87ddad4551e6f97f8bb883ac diff --git a/parse-base-block.cpp b/parse-base-block.cpp index 9644577bab70..525cd4c02257 100644 --- a/parse-base-block.cpp +++ b/parse-base-block.cpp @@ -1673,7 +1673,7 @@ void edid_state::parse_base_block(const unsigned char *x) do_checksum("", x, EDID_PAGE_SIZE); if (base.edid_minor >= 3) { if (!base.has_name_descriptor) - fail("Missing Display Product Name.\n"); + warn("Missing Display Product Name.\n"); if ((base.edid_minor == 3 || base.supports_continuous_freq) && !base.has_display_range_descriptor) fail("Missing Display Range Limits Descriptor.\n");