From patchwork Fri Feb 4 06:47:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dikshita Agarwal X-Patchwork-Id: 80486 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1nFsOO-0042DY-Fe; Fri, 04 Feb 2022 06:48:24 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245183AbiBDGsW (ORCPT + 1 other); Fri, 4 Feb 2022 01:48:22 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:41231 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233514AbiBDGsW (ORCPT ); Fri, 4 Feb 2022 01:48:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1643957302; x=1675493302; h=from:to:cc:subject:date:message-id; bh=Kt8D96RsK5xOLidpkHnApgmeuBtb1rh/8v+/7rQ1d3M=; b=kUna3YKbfOjLz7F40RbD46PKTtsUyykEOAqrdTZGXPFXB7YrEsjtgpvl mNiFuJBJ6r8Zu0spCmo0PeoKYqh6PWloFz3mhmhFTNqeYPH0++dWFWiEZ OGk7JUFAeD+t+rmTdQFB+ufu3+06T4e68pl+At86Axd06qklvDZwuDwFE g=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 03 Feb 2022 22:48:22 -0800 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 03 Feb 2022 22:48:05 -0800 X-QCInternal: smtphost Received: from hu-dikshita-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.110.13]) by ironmsg02-blr.qualcomm.com with ESMTP; 04 Feb 2022 12:17:58 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 347544) id 484CF3BED; Fri, 4 Feb 2022 12:17:57 +0530 (+0530) From: Dikshita Agarwal To: hverkuil-cisco@xs4all.nl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, vgarodia@codeaurora.org, Dikshita Agarwal Subject: [PATCH] Add check for READ ONLY flag Date: Fri, 4 Feb 2022 12:17:48 +0530 Message-Id: <1643957268-6365-1-git-send-email-quic_dikshita@quicinc.com> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -7.5 (-------) X-LSpam-Report: No, score=-7.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_HI=-5 autolearn=ham autolearn_force=no Add a check for V4L2_CTRL_FLAG_READ_ONLY to avoid request testing for such controls. --- utils/v4l2-compliance/v4l2-test-buffers.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/v4l2-compliance/v4l2-test-buffers.cpp b/utils/v4l2-compliance/v4l2-test-buffers.cpp index fa8c37c..b8de7af 100644 --- a/utils/v4l2-compliance/v4l2-test-buffers.cpp +++ b/utils/v4l2-compliance/v4l2-test-buffers.cpp @@ -2032,7 +2032,8 @@ int testRequests(struct node *node, bool test_streaming) if (qctrl.type != V4L2_CTRL_TYPE_INTEGER && qctrl.type != V4L2_CTRL_TYPE_BOOLEAN) continue; - if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY) + if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY || + qctrl.flags & V4L2_CTRL_FLAG_READ_ONLY) continue; if (is_vivid && V4L2_CTRL_ID2WHICH(qctrl.id) == V4L2_CTRL_CLASS_VIVID) continue;