From patchwork Wed Jan 5 11:41:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 79786 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1n54fN-00EWso-0m; Wed, 05 Jan 2022 11:41:17 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235742AbiAELlP (ORCPT + 1 other); Wed, 5 Jan 2022 06:41:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235184AbiAELlO (ORCPT ); Wed, 5 Jan 2022 06:41:14 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C210C061761; Wed, 5 Jan 2022 03:41:14 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id c14-20020a17090a674e00b001b31e16749cso2065811pjm.4; Wed, 05 Jan 2022 03:41:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=W8qJ+gTWpAmAqccsu4VHP+qDqU+AE+afcLRoJrwVo6E=; b=b3QiHQH5Er4oKyc+54KGnd0tlcWe1qJ43yNX6bdDbwwVF2Vhgsj/nqEN5E0PdzPSgi i6L32JrWkLBNe0fjMhh6C321aYJKPKRZpaGo7L5b8OTJgxJR8tqwlImRO64uP+JrOiOI z0gX5qt78Zn0nEqZpP3OAMAe+EwYdkvKjgwPb2ceVOOeoGKqr0CJXWuDv0Yr9BYhy0vv ey9xGLkrfvf+qDKFQp15hpoQgEVnfCy3Kl8LvE73cvpDzTSV04d4nShIOgib6sv27j0Q YpPQp4QLol5SuP0GvJEv3hG+UzV9PmnKaTP+sGBsJzac2zQkfk2QiKWi2lBZ60DY7w7N wvXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=W8qJ+gTWpAmAqccsu4VHP+qDqU+AE+afcLRoJrwVo6E=; b=UtA+jW1Txb+LPdrFctJV1NbXCi9GPotA4iskbtM/vXZ7WqCPAW9HexA8TfFhLwqXZ4 h9Wkchp+qBLz4I1mDKdKl2beIY4Y4i0kBYiWfbQWOkPVg2eu29u8zJads9IU/dJJGLR0 4JA6vftypVymfuoMtrQ7IzTmdDHubXHBUmzC+6fhiV0bifH3y8uhDNIdIb3DHmy/MLEk pBjylkB/rnJTfS6N8hde66R+hyjogCEP2iqwpVVt23myHwpoNOwYYJXEhdzazk99bA/y zPG76z6YOelV3vYDZY00GEDDABWbxm/b7AB2WX+f62ORJhfheYAwCJ6ljYnx1+xZzxIq 45tQ== X-Gm-Message-State: AOAM5324zKNbDfNvWSBL+/gYzU3IlOlaltQ75WzVgEuggAaSu/QO7a3H DvUR5C5hSgSXLyL2KxB+mRM= X-Google-Smtp-Source: ABdhPJwuRDvftHGsqLhPtov6RcOWcaLCpjOn8GP37kisprl7fIKuAr5s6mzCXoBSAvQYRt69/GMU9w== X-Received: by 2002:a17:90b:1206:: with SMTP id gl6mr3625640pjb.228.1641382873733; Wed, 05 Jan 2022 03:41:13 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id t126sm36753254pgc.61.2022.01.05.03.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 03:41:13 -0800 (PST) From: Miaoqian Lin Cc: linmq006@gmail.com, Fabien Dessenne , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: bdisp: Fix PM disable depth imbalance in bdisp_probe Date: Wed, 5 Jan 2022 11:41:08 +0000 Message-Id: <20220105114108.10380-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.3 (--) X-LSpam-Report: No, score=-2.3 required=5.0 tests=BAYES_00=-1.9,DKIM_ADSP_CUSTOM_MED=0.001,DKIM_SIGNED=0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,T_DKIM_INVALID=0.01 autolearn=ham autolearn_force=no The pm_runtime_enable will increase power disable depth. If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable(). Fixes: 28ffeeb ("[media] bdisp: 2D blitter driver using v4l2 mem2mem framework") Signed-off-by: Miaoqian Lin --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index 7d467f2ba072..ded4d026f84c 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -1396,6 +1396,8 @@ static int bdisp_probe(struct platform_device *pdev) err_remove: bdisp_debugfs_remove(bdisp); v4l2_device_unregister(&bdisp->v4l2_dev); +disable_pm_runtime: + pm_runtime_disable(dev); err_clk: if (!IS_ERR(bdisp->clock)) clk_unprepare(bdisp->clock);