From patchwork Thu Dec 2 21:03:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 79106 X-Patchwork-Delegate: sakari.ailus@iki.fi Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1mstEx-003iNi-Ov; Thu, 02 Dec 2021 21:03:40 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243458AbhLBVHA (ORCPT + 1 other); Thu, 2 Dec 2021 16:07:00 -0500 Received: from mga04.intel.com ([192.55.52.120]:42478 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhLBVG7 (ORCPT ); Thu, 2 Dec 2021 16:06:59 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="235570998" X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; d="scan'208";a="235570998" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2021 13:03:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; d="scan'208";a="603125105" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 02 Dec 2021 13:03:33 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9C14C109; Thu, 2 Dec 2021 23:03:38 +0200 (EET) From: Andy Shevchenko To: Mauro Carvalho Chehab , Laurent Pinchart , Jacopo Mondi , Kieran Bingham , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Niklas_S=C3=B6derlund?= , Mauro Carvalho Chehab , Andy Shevchenko Subject: [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment Date: Thu, 2 Dec 2021 23:03:35 +0200 Message-Id: <20211202210335.78015-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove assignment here. For the details one may look into the of_gpio_dev_init() implementation. Signed-off-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- drivers/media/i2c/max9286.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 7c663fd587bb..a662d3aa0641 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_priv *priv) gpio->label = dev_name(dev); gpio->parent = dev; gpio->owner = THIS_MODULE; - gpio->of_node = dev->of_node; gpio->ngpio = 2; gpio->base = -1; gpio->set = max9286_gpio_set;